From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id mFCiFVmTBmM1ewAAbAwnHQ (envelope-from ) for ; Wed, 24 Aug 2022 23:08:41 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id SEyXFVmTBmMJVQEA9RJhRA (envelope-from ) for ; Wed, 24 Aug 2022 23:08:41 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 26B9E96C6 for ; Wed, 24 Aug 2022 23:08:41 +0200 (CEST) Received: from localhost ([::1]:44594 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oQxc8-0005kJ-9L for larch@yhetil.org; Wed, 24 Aug 2022 17:08:40 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:50952) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oQxar-0005Qm-Qk for guix-devel@gnu.org; Wed, 24 Aug 2022 17:07:21 -0400 Received: from cascadia.aikidev.net ([2600:3c01:e000:267:0:a171:de7:c]:59548) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oQxaq-0004O9-0P for guix-devel@gnu.org; Wed, 24 Aug 2022 17:07:21 -0400 Received: from localhost (unknown [IPv6:2600:3c01:e000:21:7:77:0:20]) (Authenticated sender: vagrant@cascadia.debian.net) by cascadia.aikidev.net (Postfix) with ESMTPSA id CFD4D1AC31; Wed, 24 Aug 2022 14:07:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=debian.org; s=1.vagrant.user; t=1661375236; bh=Lz/tXP5r0EgizwlUtStoN+bR/WUquR/aLjrdtQ7gxvE=; h=From:To:Subject:In-Reply-To:References:Date:From; b=UX1IMA8cUsk+Y7hIJL4IYr7jk3Qox9DBQOaj6+visYQVE9SGyNwUm5snx/m8dBt80 etd0vCLHIOBPyAJk5iMWsssBUtaZQMKc6B/HTrt7j/Y3M2cAnqqZE/g/RhkF20CKhx 2Uzui08EXtForPcZqiuwhemRAM1vPiEKav0x3ZlHfHO7CDLZ0y4vZnkQgQVnWUD37K f6+6bXyr8GriU4fkq099jsZ1zU+83IvGRYJKTGjXTyYuX04DF5mYD7Zj8QrrA/Jq9C YsdtniSATWE/+II7NzLKdKhcAIsQ2yuxshWND3UYlZ4W8w6BF96eesbXzfIUw343IN 7ioV9wk5NOO4w== From: Vagrant Cascadian To: zimoun , guix-devel@gnu.org Subject: Re: guix lint should support overrides In-Reply-To: <87h722xdvo.fsf@gmail.com> References: <87wnaya9de.fsf@contorta> <87h722xdvo.fsf@gmail.com> Date: Wed, 24 Aug 2022 14:06:57 -0700 Message-ID: <87ilmhic5q.fsf@contorta> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" Received-SPF: none client-ip=2600:3c01:e000:267:0:a171:de7:c; envelope-from=vagrant@debian.org; helo=cascadia.aikidev.net X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_NONE=0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: guix-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+larch=yhetil.org@gnu.org Sender: "Guix-devel" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1661375321; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=ep0VeuBDZL3QDcyjlCBuGMXNBzmfYgYIDGR1qgoDz+o=; b=HAzGz/AwPogTIyoFp0Su8kVD4zPaBl33ceq7MhS4GhM/HE+I3RJ2Ru4AvCGW2PzA6iJgZh 4lFd6h4eMu6xeS8vOO2iqkbuJ70cyVieNz8MizKgtvrYdgtG+21G3SGDJ/DIJnI2TBbddL kEwtPw+fVF2Enb51PWL/M5Qcjs+fErfPeLO5Mfc1e8FEz8j6c+ldjeGJ8vpOyYZg4oAEum G7ujML/iqpeHgb1bErTsQldpcFgHeNWsft1noL8IucnliYMFp72ojlibDedRLJs5XSf8Q1 Cgy7jcLTADr4CgZVXmsLlAkPDYDa+nFcsGwVBCRRZ+boB6bl1SaIfgl+pRbVcA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1661375321; a=rsa-sha256; cv=none; b=rnUPS8zMCuG1hQzjtB71s1fQH7MRZEzKKP8Fqmvfu78lIPoC+9QpzuRqGwHXP1j92xXR5a k4nz1lu7JZoXkS91OWrwgIKuz231t8JLPl+OPmSGFgTAc1d+KAxEUtATOaJbKk+zjFp/xY lEo0GMzNBessA+4Lh7Mp7pXRRpE1zd0/vaUPlAzK0akpi8+lF0LomBMf3yRADZgmUV4vaX fHefG8rjHuqKjOqt0mNlXv/HRPZXC0FjAORV8h/tCnwGd8bFDtkArm5yQhysn4c1z+UtsP xn+j3v/cS6MYoaYNuOhHP71m6sLADn95j0C/ewzOsC4lxqqEA88dePH/wdVqsw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=debian.org header.s=1.vagrant.user header.b=UX1IMA8c; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -10.41 Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=debian.org header.s=1.vagrant.user header.b=UX1IMA8c; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 26B9E96C6 X-Spam-Score: -10.41 X-Migadu-Scanner: scn0.migadu.com X-TUID: ixB3yJwwx7J3 --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 2022-08-24, zimoun wrote: > On Tue, 23 Aug 2022 at 15:22, Vagrant Cascadian wrot= e: > >> But, because there is no way to silence a particular inappropriate >> suggestion from guix lint, it becomes noise, and each person evaluating >> the results of the package in the future then needs to take time to >> figure out if guix lint is wrong, or something should be changed. > > Do you have some packages as example? In order to be concrete about the > false-positive and how to programatically fix them. Off the top of my head, no, though it came up in the course of a convesation on #guix recently, and it reminded me of advice I've gotten in the past to just ignore a particular check on a particular package. > For instance, do you mean exclude on specific checker for one specific > package? Yes, this! :) Maybe something like: (define-public thispackages (package (name "thispackages" ... (lint-overides (list ;; The upstream name is actually "This Packages", not a typo. "typo in description: 'This Packages' should be 'This Package'"))=20 And then guix lint would hide or ignore things that would otherwise emit the strings listed in lint-overrides ... or something like that. Maybe exact match, maybe get into a little pattern matching, not sure. Implementation is not my strong point here. :) You might also want to add a guix lint check for unused overrides (e.g. something that no longer triggers the issue, either fixed upstream in guix lint itself, or some other way). > Or teach one specific checker for one specific package in > order to avoid an error specific to this package running this specific > checker? No. Maybe in some cases this might make sense, but was not what I was suggesting. >> The downside is this becomes one more thing to maintain... in exchange >> for making the output having a higher degree of relevency in "guix lint" >> output, so you can be more confident that someone hasn't already looked >> at a given issue and decided it was best to just ignore it (not that >> that will not ever happen anymore, but still). > > The cost for a poor maintenance is low compared to the benefit, IMHO. > > For instance, it is boring to run massive lint: > > 1. because =E2=80=9Cguix lint=E2=80=9D does not support the option --man= ifest > 2. because =E2=80=9Cguix lint=E2=80=9D reports some false-positive messa= ges Yeah, my suggestion was mostly about trying to address aspects of point 2. live well, vagrant --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEARYKAB0WIQRlgHNhO/zFx+LkXUXcUY/If5cWqgUCYwaS8QAKCRDcUY/If5cW qvcbAQCUGFEgCNLbyY6XIjFDYrXg5R3Q+z/6HVoWvwjvgElehQEAzpjd3ZMZ+Q7B lYoaMtGgEAUcyd8MJtvQ/paSS9Qq4A4= =LUN4 -----END PGP SIGNATURE----- --=-=-=--