From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id aKVhNn0e1GOv7gAAbAwnHQ (envelope-from ) for ; Fri, 27 Jan 2023 19:57:01 +0100 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id uNNlNn0e1GNgMQEA9RJhRA (envelope-from ) for ; Fri, 27 Jan 2023 19:57:01 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id AFFA02CED0 for ; Fri, 27 Jan 2023 19:57:01 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pLTth-0001fN-Po; Fri, 27 Jan 2023 13:56:25 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pLTtg-0001fF-E9 for guix-devel@gnu.org; Fri, 27 Jan 2023 13:56:24 -0500 Received: from mail-wm1-x32c.google.com ([2a00:1450:4864:20::32c]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pLTte-0006hL-SM; Fri, 27 Jan 2023 13:56:24 -0500 Received: by mail-wm1-x32c.google.com with SMTP id d4-20020a05600c3ac400b003db1de2aef0so4159535wms.2; Fri, 27 Jan 2023 10:56:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:message-id:date:subject:to:from:from:to:cc:subject :date:message-id:reply-to; bh=IeWVDU7U79pAZMhiHWZG9hT8lO2gLTkEz614BkLoB3A=; b=SocUXXD4o8lO0WVtqYYzYdk/V5FXUxWeYyVDb2yCAIPbXR97UnRcQZxVrVowUau/M6 F5ZaFI71aCI8wck0Uyh783wrP8bk3OI3pTQ+md0pW3wcsfNiq5BQcxuSlSjE9J9BTuBN jB3WMLQ2EN3+bEVlUsv9gn7eCWYMkDBCT4ehvD4/D8k+h+YizgCrd3OlduAs9S7SaUT4 FeU+4i2qewkOKdiKZH6JR/LLb0mKF91a1SO6tJk0MMcT3mDxR+mlmO/TZIfHD+ubO/Gq kC8zcXnKRzHUaJqqvvLW70jRrawtQSfKSFfkOs8GQZPwwwRwjYfqQJG2OuWr0aYgcWKc W2Xw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:message-id:date:subject:to:from:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=IeWVDU7U79pAZMhiHWZG9hT8lO2gLTkEz614BkLoB3A=; b=12eTCjx9T4rcoq0T/2SgKWu70WkTT+pMZ7+H1l+LMPgX1a/6qec3gE3ShO5Z8nrsve ut7QEHzSpSkfVC9OJl9ySUOeCv5ckFyfs5lOJ8VWfKyP9C9aRYZAO/r+cld2cMuYAIe2 ommD7U1Ppxrq6e7X1OmpvT3LaZcZtc/z/Eoru/E0Dm8ayUeJW4cBi/xMchDvzRVcHMAy 2hKl4w3v3BMlx1IPC8tfE5v04cMFgQKhnLM9Il43m98bYBMFPeQPBpTE3IuFDdqnqAVM UDHvEVcjpu7ur3AOve445/Jgnoq4mWMLq6L5Ygijsldv4yV+PoTYUBS2O4SWAWVp0Q7B jNZg== X-Gm-Message-State: AO0yUKVCE5ejRUfCbW6X1I2NpFvcGtHNaFAVlp2BnkWagqWS4ZLwhmvE fUfMTKU5ern/L23wuPPVRhwHw6iTMjk= X-Google-Smtp-Source: AK7set8gPc+EWwGpVKiIiVl7QMcea1SfnH7YM+loDa/Gv0jJA6Q5rFV8WZfyUEu0tIDTIvM1K0XTqg== X-Received: by 2002:a05:600c:3c89:b0:3dc:3398:cf65 with SMTP id bg9-20020a05600c3c8900b003dc3398cf65mr1018371wmb.2.1674845781041; Fri, 27 Jan 2023 10:56:21 -0800 (PST) Received: from pfiuh07 ([193.48.40.241]) by smtp.gmail.com with ESMTPSA id v14-20020adfe4ce000000b002bfafadb22asm5000668wrm.87.2023.01.27.10.56.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 27 Jan 2023 10:56:20 -0800 (PST) From: Simon Tournier To: Guix Devel , Ludovic =?utf-8?Q?Court=C3=A8s?= Subject: Unexpected error with #~(modify-phases Date: Fri, 27 Jan 2023 19:55:42 +0100 Message-ID: <87ilgrn6xd.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=2a00:1450:4864:20::32c; envelope-from=zimon.toutoune@gmail.com; helo=mail-wm1-x32c.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: guix-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+larch=yhetil.org@gnu.org Sender: guix-devel-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1674845821; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=IeWVDU7U79pAZMhiHWZG9hT8lO2gLTkEz614BkLoB3A=; b=dbizd6kFGLLdvxNXt9Dws0QLqny9daYPotxM6eJ1pPWDwlS6kIiGsXSyrIaNywfMFajPfr p6tQos/RLXmpcsBHWje8ff56e0aOs6Gztd6TIn/dn1+XC+wrqd22iFH42SRxDePw0+WheH ruBVDqMtcUFu5voSGpXyDXqO0dnh7xOHx9mMVWXX2vjQJZGvszdpsgXnghPNn+l6M4Ig9d ftXdTapx3h3prHQqiCR4ZA77yVVR04n2iZ9UvCrL9G5hjsq76huw9vDwP1bLrAs/CvJWLC giay4SMW9t1Ym/snqT7y6Q0/7P9J3XJCZXRS8jr1zl7lv4/lXOOsOq2IBsE5+Q== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=SocUXXD4; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org" ARC-Seal: i=1; s=key1; d=yhetil.org; t=1674845821; a=rsa-sha256; cv=none; b=k2x2sdGTyliygdGBm9sfILwrQfZ3oy/lBf7/Wc+/1HKttstQtxG8+9tdlx5LlUUKikPrJR GaJXdKR5jfIm14DBJYmmi/Ji8AGuenaEm2JddAjaJTomE3S8QAUFUZf6rEici+3NU+b88P nPRgFUBWRXeNN0K7jpaml8e5rA6ZDypkNobTnhxq/6i8/GQ9UrdTBoNz4x+zCpcVjoQAeR FPPZD52Gg0IMDqZiegy2MXqeT8bNa1c2LzA/zN2eNjgaHQrQE3LiLeLrUlTUDP2wItqt8f N9LUXjIHCHfm2+ZysDgFopY6PYaKsRiu/XjLmORXGjF72+r3e8dWIP6FshRwnA== Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=SocUXXD4; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org" X-Migadu-Scanner: scn0.migadu.com X-Migadu-Spam-Score: -10.25 X-Spam-Score: -10.25 X-Migadu-Queue-Id: AFFA02CED0 X-TUID: i5V+mbf5sgpb Hi, Reviewing #59997 [1], there is something I am missing. Using the V2, all works as expected. But when I just modify with this diff: --8<---------------cut here---------------start------------->8--- 1 file changed, 2 insertions(+), 2 deletions(-) gnu/packages/minimacy.scm | 4 ++-- modified gnu/packages/minimacy.scm @@ -48,8 +48,8 @@ (define-public minimacy "X11" ;for GUI programs, with X11 and ALSA "X11GL")) ;for GUI programs, with X11, OpenGL, and ALSA (arguments - `(#:phases - (modify-phases %standard-phases + (list #:phases + #~(modify-phases %standard-phases (add-after 'unpack 'patch-path (lambda* (#:key outputs #:allow-other-keys) (substitute* "src/hw.c" --8<---------------cut here---------------end--------------->8--- then I get this error: --8<---------------cut here---------------start------------->8--- gnu/packages/minimacy.scm:59:9: error: (replace (quote build) (lambda _ (chdir "unix") (invoke "make" "nox") (for-each delete-file (find-files "../obj" "\\.o$")) (invoke "make" "x11") (for-each delete-file (find-files "../obj" "\\.o$")) (invoke "make" "x11gl") (chdir ".."))): 'replace' may only be used within 'modify-inputs' --8<---------------cut here---------------end--------------->8--- where the (unmodified) phase reads: --8<---------------cut here---------------start------------->8--- (add-after 'unpack 'patch-path [...] (delete 'configure) (replace 'build (lambda _ (chdir "unix") (invoke "make" "nox") (for-each delete-file (find-files "../obj" "\\.o$")) (invoke "make" "x11") (for-each delete-file (find-files "../obj" "\\.o$")) (invoke "make" "x11gl") (chdir ".."))) (replace 'install [...] --8<---------------cut here---------------end--------------->8--- What do I miss? 1: https://issues.guix.gnu.org/msgid/m1tu219bmo.fsf@fastmail.net Cheers, simon