* Re: 01/02: gnu: Add dlib.
[not found] ` <20250203121041.D9ED4C0C668@vcs2.savannah.gnu.org>
@ 2025-02-04 15:50 ` Ludovic Courtès
0 siblings, 0 replies; only message in thread
From: Ludovic Courtès @ 2025-02-04 15:50 UTC (permalink / raw)
To: guix-devel, Danny Milosavljevic
Hi Danny,
guix-commits@gnu.org skribis:
> commit 6cd15c83ab54b049f4bd3114ba971849ffe1fe66
> Author: Danny Milosavljevic <dannym@friendly-machines.com>
> AuthorDate: Mon Feb 3 12:54:34 2025 +0100
>
> gnu: Add dlib.
>
> * gnu/packages/machine-learning.scm (dlib): New variable.
>
> Change-Id: Id0240565dfe76c7cdf0d74917f1de6fcd2da9f24
[...]
> +(define-public dlib
> + (package
> + (name "dlib")
> + (version "19.24.6")
You may have seen this warning:
gnu/packages/machine-learning.scm:6413:0: warning: shadows previous definition of `dlib' at gnu/packages/machine-learning.scm:1841:0
This effectively means that you upgraded ‘dlib’ without noticing.
> + `(#:phases
> + (modify-phases %standard-phases
> + (add-after 'unpack 'chdir
> + (lambda _
> + (chdir "dlib")))
> + (replace 'check
> + (lambda _
> + ;; Following the instructions on the website.
> + (mkdir "../dlib/test/build")
> + (with-directory-excursion "../dlib/test/build"
> + (invoke "cmake" "..")
> + (invoke "cmake" "--build" "." "--config" "Release")
> + (invoke "./dtest" "--runall")))))))
Indentation is off here, I’d recommend using ‘guix style’.
Could you please either revert this commit or merge the two ‘dlib’
definitions, assuming the upgrade does not break any dependent? (You
can use ‘guix build -P1 dlib’ for example to check that.)
Thanks in advance,
Ludo’.
PS: I think it’s also a case showing how we could benefit from a
streamlined process where changes are merged only once they’ve had a
green light from CI.
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2025-02-04 15:51 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <173858464141.22255.17273165800293433293@vcs2.savannah.gnu.org>
[not found] ` <20250203121041.D9ED4C0C668@vcs2.savannah.gnu.org>
2025-02-04 15:50 ` 01/02: gnu: Add dlib Ludovic Courtès
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).