Re: [PATCH] pspp

[ludo@gnu.org (Ludovic Courtès)]

Hi John,

This looks great!  I just have minor stylistic notes:

John Darrington <john@darrington.wattle.id.au> skribis:

> From 69c6338775161fcba20f4ce9452b33fee90dc2d1 Mon Sep 17 00:00:00 2001
> From: John Darrington <john@darrington.wattle.id.au>
> Date: Sat, 30 Nov 2013 11:11:54 +0100
> Subject: [PATCH 1/2] gnu: Added gtksourceview
>
> * gnu/packages/gtk.scm: New package gtksourceview

Rather:

* gnu/packages/gtk.scm (gtksourceview): New variable.

> +            (uri (string-append "mirror://gnome/sources/gtksourceview/" (string-take version 4) "/gtksourceview-"
> +                                version ".tar.bz2"))

Please try to keep lines below 80 chars.

> +   (inputs
> +    `(
> +      ("intltool" ,intltool)
> +      ("pkg-config" ,pkg-config)
> +      ("gtk" ,gtk+-2)
> +      ("libxml2" ,libxml2)
> +
> +      ; These two are needed only to allow the tests to run successfully
> +      ("xorg-server" ,xorg-server)
> +      ("shared-mime-info" ,shared-mime-info)
> +    ))

[...]

> +   (arguments
> +    `(#:phases 
> +      ; Unfortunately, some of the tests in "make check" are highly dependent on the environment
> +      ; therefore, some black magic is required

Please use the same style as the rest; in particular, no line break
after an opening paren, no hanging closing parens, and two semicolons to
introduce comments that are on line of their own (see ‘HACKING’.)

(Nice that you managed to get the X tests running, BTW!)

> +   (synopsis "A text widget that extends the standard gtk+ 2.x
> +text widget GtkTextView.")

Rather like “Widget that extends GtkTextView from GTK+ 2.x” (no final
period, no “A”.)

> From 39f8989a6e9067002911257701f90776f5b5b608 Mon Sep 17 00:00:00 2001
> From: John Darrington <john@darrington.wattle.id.au>
> Date: Sat, 30 Nov 2013 13:54:46 +0100
> Subject: [PATCH 2/2] gnu: pspp: Enabled build of the gui
>
> * gnu/packages/math.scm (<pspp>): Removed the --without-gui flag
> and added the necessary inputs to build it.

Should be ‘pspp’, not ‘<pspp>’.

OK to apply modulo these cosmetic changes.  Could you post updated
patches?

Thanks!

Ludo’.