From: ludo@gnu.org (Ludovic Courtès)
To: John Darrington <john@darrington.wattle.id.au>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH 4/5] gnu: openssl: Fixed cross-compile issues.
Date: Sat, 14 Dec 2013 22:01:46 +0100 [thread overview]
Message-ID: <87haabtadh.fsf@gnu.org> (raw)
In-Reply-To: <20131214180259.GA6637@intra> (John Darrington's message of "Sat, 14 Dec 2013 19:02:59 +0100")
John Darrington <john@darrington.wattle.id.au> skribis:
> On Sat, Dec 14, 2013 at 06:57:59PM +0100, Ludovic Court??s wrote:
>
> > @@ -52,8 +52,8 @@
> > (string-append "--prefix=" out)))))
> > (alist-cons-before
> > 'patch-source-shebangs 'patch-tests
> > - (lambda* (#:key inputs #:allow-other-keys)
> > - (let ((bash (assoc-ref inputs "bash")))
> > + (lambda* (#:key inputs native-inputs #:allow-other-keys)
> > + (let ((bash (assoc-ref ,@(if (%current-target-system) '(native-inputs) '(inputs)) "bash")))
>
> This can???t possibly work.
>
> I did test it, both for native compilation and cross-compilation. In both cases
> it built succesfully (unlike before the patch).
Ah, sorry, I misread the unquoted part; apologies for that.
Still, I’d prefer the simpler (because it’s build-side code only):
(assoc-ref (or native-inputs inputs) "bash")
WDYT?
Could you send an updated patch if that’s fine with you?
Ludo’.
next prev parent reply other threads:[~2013-12-14 21:02 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-14 17:43 [PATCH 1/5] gnu: libxml2: Fixed cross-compilation John Darrington
2013-12-14 17:43 ` [PATCH 2/5] gnu: gnupg: Fixed cross-compile issues John Darrington
2013-12-14 18:19 ` Ludovic Courtès
2013-12-14 19:02 ` John Darrington
2013-12-14 21:06 ` Ludovic Courtès
2013-12-15 8:24 ` John Darrington
2013-12-15 8:39 ` [PATCH] gnu: gnupg: Fix " John Darrington
2013-12-15 21:24 ` Ludovic Courtès
2013-12-15 21:14 ` [PATCH 2/5] gnu: gnupg: Fixed " Ludovic Courtès
2014-01-07 10:32 ` John Darrington
2013-12-14 17:43 ` [PATCH 3/5] gnu: tzdata: Added "source" as input John Darrington
2013-12-14 18:24 ` Ludovic Courtès
2013-12-14 17:43 ` [PATCH 4/5] gnu: openssl: Fixed cross-compile issues John Darrington
2013-12-14 17:57 ` Ludovic Courtès
2013-12-14 18:02 ` John Darrington
2013-12-14 21:01 ` Ludovic Courtès [this message]
2013-12-15 8:03 ` [PATCH] gnu: openssl: Fix " John Darrington
2013-12-15 21:18 ` Ludovic Courtès
2013-12-14 17:43 ` [PATCH 5/5] gnu: Changed many "inputs" which should be "native-inputs" John Darrington
2013-12-14 21:48 ` Ludovic Courtès
2013-12-15 10:36 ` John Darrington
2013-12-15 11:01 ` [PATCH] gnu: Move numerous " John Darrington
2013-12-15 21:32 ` Ludovic Courtès
2013-12-14 17:48 ` [PATCH 1/5] gnu: libxml2: Fixed cross-compilation Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87haabtadh.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=guix-devel@gnu.org \
--cc=john@darrington.wattle.id.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).