Re: [PATCH 2/3] gnu: boost: New module

[ludo@gnu.org (Ludovic Courtès)]

Hi!

Thanks for looking into those big packages!

John Darrington <jmd@gnu.org> skribis:

> +       (alist-replace
> +        'configure 
> +        (lambda* (#:key outputs #:allow-other-keys) 
> +          (let ((out (assoc-ref outputs "out")))
> +            (substitute* '("libs/config/configure"
> +                           "libs/spirit/classic/phoenix/test/runtest.sh"
> +                           "tools/build/v2/doc/bjam.qbk"
> +                           "tools/build/v2/engine/boehm_gc/aclocal.m4"
> +                           "tools/build/v2/engine/boehm_gc/config.guess"
> +                           "tools/build/v2/engine/boehm_gc/configure"
> +                           "tools/build/v2/engine/boehm_gc/configure.ac"
> +                           "tools/build/v2/engine/boehm_gc/install-sh"
> +                           "tools/build/v2/engine/boehm_gc/libtool.m4"
> +                           "tools/build/v2/engine/boehm_gc/ltmain.sh"
> +                           "tools/build/v2/engine/boehm_gc/Makefile.direct"
> +                           "tools/build/v2/engine/boehm_gc/Makefile.dj"
> +                           "tools/build/v2/engine/boehm_gc/missing"
> +                           "tools/build/v2/engine/boehm_gc/PCR-Makefile"
> +                           "tools/build/v2/engine/execunix.c"
> +                           "tools/build/v2/engine/Jambase"
> +                           "tools/build/v2/engine/jambase.c")
> +              (("/bin/sh") (which "sh")))

Boehm GC doesn’t need patching, because it uses an Autoconf-generated
‘configure’, so it honors $SHELL and $CONFIG_SHELL.  Could you try
(setenv "CONFIG_SHELL" (which "sh"))?

Even better: can Boost be told to use our libgc instead of building its
own?

As for the other scripts, why do they need to be patched?  Normally the
patch-shebang phase should have taken care of the shebang of
‘libs/config/configure’, ‘runtest.sh’, etc.

> +            (setenv "SHELL" (which "sh"))
> +            
> +            (zero? (system* "./bootstrap.sh" 
> +                            (string-append "--prefix=" out) 
> +                            "--with-toolset=gcc"))))
> +        (alist-replace
> +         'build
> +         (lambda* (#:key outputs #:allow-other-keys #:rest args) 
> +           (zero? (system* "./b2" "threading=multi" "link=shared")))

Since both ‘outputs’ and ‘args’ are ignored, just write:

  (lambda _
    (zero? ...))

(where ‘_’ is by convention a placeholder.)

> +         (alist-replace
> +          'check
> +          (lambda* (#:key outputs #:allow-other-keys #:rest args) #t)

Just use #:tests? #f instead of replacing the ‘check’ phase.

> +    (synopsis "peer-reviewed portable C++ source libraries")

Capitalization.

> +    (description  "A collection of libraries intended to be widely useful, and usable across
> +    a broad spectrum of applications.")

Extra spaces, line too long.

Thanks,
Ludo’.