From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?utf-8?B?5a6L5paH5q2m?= Subject: Re: [PATCH] gnu: Add ninja. Date: Thu, 15 Jan 2015 19:15:55 +0800 Message-ID: <87h9vsxpjo.fsf@gmail.com> References: <1420810817-23613-1-git-send-email-iyzsong@gmail.com> <87fvbk3tvy.fsf@gnu.org> <87d26iyzi1.fsf@netris.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:44943) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YBiP9-0002sG-JS for guix-devel@gnu.org; Thu, 15 Jan 2015 06:16:00 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YBiP8-0006FO-LK for guix-devel@gnu.org; Thu, 15 Jan 2015 06:15:59 -0500 In-Reply-To: <87d26iyzi1.fsf@netris.org> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: Mark H Weaver , Ludovic =?utf-8?Q?Court=C3=A8s?= Cc: guix-devel@gnu.org Mark H Weaver writes: > ludo@gnu.org (Ludovic Court=C3=A8s) writes: > >> =E5=AE=8B=E6=96=87=E6=AD=A6 skribis: >> >>> * gnu/packages/ninja.scm: New file. >>> * gnu-system.am (GNU_SYSTEM_MODULES): Add it. >> >> [...] >> >>> + 'check >>> + (lambda _ >>> + (and (zero? (system "./configure.py")) >>> + (zero? (system "./ninja ninja_test")) >>> + ;; SubprocessTest.InterruptChild fail when using 'sys= tem*'. >>> + ;; SubprocessTest.SetWithLots was skipped. >>> + ;; XXX: Raise [ulimit -n] well above 1025 to make thi= s test go. >> >> Does it mean that the test is currently failing? > > This test failed during the core-updates x86_64 build on Hydra. We get: > > [166/183] SubprocessTest.InterruptChild > *** Failure in src/subprocess_test.cc:83 > ExitInterrupted =3D=3D subproc->Finish() > > In the hopes that it might be a transient failure, I restarted the > build, but the second time it failed in the same place. See: > > http://hydra.gnu.org/build/201077/nixlog/1/raw > http://hydra.gnu.org/build/201077/nixlog/2/raw > > It seems that using 'system' instead of 'system*' wasn't enough to make > it work reliably. Can you take another look? OK, I pushed a patch to disable the test. > > Thanks for your contributions! > > Mark