From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: Re: problem with building gcc-cross-4.8.3 for i686-pc-gnu
Date: Thu, 05 Feb 2015 13:38:48 +0100
Message-ID: <87h9v04jon.fsf@gnu.org>
References: <54CCADF7.6090708@gmail.com> <54CD5372.5090103@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:57506)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1YJLhx-0001rz-85
	for guix-devel@gnu.org; Thu, 05 Feb 2015 07:39:00 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1YJLht-0001Pz-DL
	for guix-devel@gnu.org; Thu, 05 Feb 2015 07:38:56 -0500
Received: from fencepost.gnu.org ([2001:4830:134:3::e]:45088)
	by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from <ludo@gnu.org>)
	id 1YJLht-0001Pv-B6
	for guix-devel@gnu.org; Thu, 05 Feb 2015 07:38:53 -0500
In-Reply-To: <54CD5372.5090103@gmail.com> (Marek Benc's message of "Sat, 31
	Jan 2015 23:13:06 +0100")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: Marek Benc <merkur32@gmail.com>
Cc: guix-devel@gnu.org

Marek Benc <merkur32@gmail.com> skribis:

> The attached patch does the following:
>   1.) Adds the name of the dynamic linker to gnu/packages/bootstrap.scm
>   2.) Adds code to gnu/package/gcc to substitute the default dynamic
> linker in gcc/config/arch/gnu.h for the one to be used.
>   3.) Changes how the build system arguments for cross-gcc are created:
>     A.) They're now in a separate procedure, reflecting how it's done
> in vanilla guix.
>     B.) A bug is fixed that caused the native ld.so to be picked over
> the target one.
>     C.) Fixed the 'set-cross-path phase so that it also checks for
> hurd-related packages, and checks package existence before passing
> anything to the string-handling functions.

This all looks good to me.  However, this should really be 5 different
patches so as to ease review, bisection, etc.  Could you do that?

Please prefer one message per patch, as with =E2=80=98git send-email=E2=80=
=99.

TIA!

Ludo=E2=80=99.