* Re: 01/01: download: Handle HTTP redirects to relative URI references.
[not found] ` <E1YOMXD-00024m-JG@vcs.savannah.gnu.org>
@ 2015-02-23 20:22 ` Ludovic Courtès
2015-02-24 5:44 ` Mark H Weaver
0 siblings, 1 reply; 3+ messages in thread
From: Ludovic Courtès @ 2015-02-23 20:22 UTC (permalink / raw)
To: Mark H Weaver; +Cc: guix-devel
"Mark H. Weaver" <mhw@netris.org> skribis:
> +;; XXX: Work around <http://bugs.gnu.org/19840>, present in Guile
> +;; up to 2.0.11.
> +(unless (or (> (string->number (major-version)) 2)
> + (> (string->number (minor-version)) 0)
> + (> (string->number (micro-version)) 11))
Just a minor nit: could you change that to use ‘guile-version>?’
instead? It is more concise and easier to search for.
Thanks for the fix!
Ludo’.
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: 01/01: download: Handle HTTP redirects to relative URI references.
2015-02-23 20:22 ` 01/01: download: Handle HTTP redirects to relative URI references Ludovic Courtès
@ 2015-02-24 5:44 ` Mark H Weaver
2015-02-24 22:59 ` Ludovic Courtès
0 siblings, 1 reply; 3+ messages in thread
From: Mark H Weaver @ 2015-02-24 5:44 UTC (permalink / raw)
To: Ludovic Courtès; +Cc: guix-devel
ludo@gnu.org (Ludovic Courtès) writes:
> "Mark H. Weaver" <mhw@netris.org> skribis:
>
>> +;; XXX: Work around <http://bugs.gnu.org/19840>, present in Guile
>> +;; up to 2.0.11.
>> +(unless (or (> (string->number (major-version)) 2)
>> + (> (string->number (minor-version)) 0)
>> + (> (string->number (micro-version)) 11))
>
> Just a minor nit: could you change that to use ‘guile-version>?’
> instead? It is more concise and easier to search for.
I thought about that, but it would involve importing (guix utils) from
(guix build download), and then arranging to add (guix utils) to the
list of imported modules in the derivation produced by 'url-fetch' in
(guix download), and maybe some other places.
Anyway, if we do this, we should also change the definition of
'post-2.0.7?' in the same file.
Mark
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: 01/01: download: Handle HTTP redirects to relative URI references.
2015-02-24 5:44 ` Mark H Weaver
@ 2015-02-24 22:59 ` Ludovic Courtès
0 siblings, 0 replies; 3+ messages in thread
From: Ludovic Courtès @ 2015-02-24 22:59 UTC (permalink / raw)
To: Mark H Weaver; +Cc: guix-devel
Mark H Weaver <mhw@netris.org> skribis:
> ludo@gnu.org (Ludovic Courtès) writes:
>
>> "Mark H. Weaver" <mhw@netris.org> skribis:
>>
>>> +;; XXX: Work around <http://bugs.gnu.org/19840>, present in Guile
>>> +;; up to 2.0.11.
>>> +(unless (or (> (string->number (major-version)) 2)
>>> + (> (string->number (minor-version)) 0)
>>> + (> (string->number (micro-version)) 11))
>>
>> Just a minor nit: could you change that to use ‘guile-version>?’
>> instead? It is more concise and easier to search for.
>
> I thought about that, but it would involve importing (guix utils) from
> (guix build download),
Oh sorry, I had overlooked that; this is indeed a showstopper.
No problem then!
Ludo’.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-02-24 22:59 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20150219083234.7923.57098@vcs.savannah.gnu.org>
[not found] ` <E1YOMXD-00024m-JG@vcs.savannah.gnu.org>
2015-02-23 20:22 ` 01/01: download: Handle HTTP redirects to relative URI references Ludovic Courtès
2015-02-24 5:44 ` Mark H Weaver
2015-02-24 22:59 ` Ludovic Courtès
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).