[PATCH 01/15] gnu: gtk-xfce-engine: Update to 2.10.0.

[PATCH 01/15] gnu: gtk-xfce-engine: Update to 2.10.0.

[宋文武]

* gnu/packages/xfce.scm (gtk-xfce-engine): Update to 2.10.0.
---
 gnu/packages/xfce.scm | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/gnu/packages/xfce.scm b/gnu/packages/xfce.scm
index fb5427c..1be28a7 100644
--- a/gnu/packages/xfce.scm
+++ b/gnu/packages/xfce.scm
@@ -1,5 +1,5 @@
 ;;; GNU Guix --- Functional package management for GNU
-;;; Copyright © 2014 Sou Bunnbu <iyzsong@gmail.com>
+;;; Copyright © 2014, 2015 Sou Bunnbu <iyzsong@gmail.com>
 ;;; Copyright © 2014 Mark H Weaver <mhw@netris.org>
 ;;;
 ;;; This file is part of GNU Guix.
@@ -43,14 +43,14 @@
 (define-public gtk-xfce-engine
   (package
     (name "gtk-xfce-engine")
-    (version "3.0.0")
+    (version "2.10.0")
     (source (origin
               (method url-fetch)
-              (uri (string-append "http://archive.xfce.org/xfce/4.10/src/"
+              (uri (string-append "http://archive.xfce.org/xfce/4.12/src/"
                                   name "-" version ".tar.bz2"))
               (sha256
                (base32
-                "13c3ajfqkdr6jlqjyhcp4nls0ddanypr83q9qib2ciffik78zq4h"))))
+                "0rqrnjxx1lzla7wp2fadyixs6jy0js6xh005pgwyqbigpl0v7hy1"))))
     (build-system gnu-build-system)
     (native-inputs
      `(("pkg-config" ,pkg-config)
-- 
2.1.2

[PATCH 02/15] gnu: libxfce4util: Update to 4.12.1.

[宋文武]

* gnu/packages/xfce.scm (libxfce4util): Update to 4.12.1.
---
 gnu/packages/xfce.scm | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/gnu/packages/xfce.scm b/gnu/packages/xfce.scm
index 1be28a7..3679eb0 100644
--- a/gnu/packages/xfce.scm
+++ b/gnu/packages/xfce.scm
@@ -65,7 +65,7 @@
 (define-public libxfce4util
   (package
     (name "libxfce4util")
-    (version "4.10.0")
+    (version "4.12.1")
     (source (origin
               (method url-fetch)
               (uri (string-append "http://archive.xfce.org/xfce/"
@@ -73,7 +73,7 @@
                                   "/src/" name "-" version ".tar.bz2"))
               (sha256
                (base32
-                "13k0wwbbqvdmbj4xmk4nxdlgvrdgr5y6r3dk380mzfw053hzwy89"))))
+                "07c8r3xwx5is298zk77m3r784gmr5y4mh8bbca5zdjqk5vxdwsw7"))))
     (build-system gnu-build-system)
     (native-inputs
      `(("pkg-config" ,pkg-config)
-- 
2.1.2

Re: [PATCH 02/15] gnu: libxfce4util: Update to 4.12.1.

[David Thompson]

宋文武 <iyzsong@gmail.com> writes:

> * gnu/packages/xfce.scm (libxfce4util): Update to 4.12.1.
> ---
>  gnu/packages/xfce.scm | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/gnu/packages/xfce.scm b/gnu/packages/xfce.scm
> index 1be28a7..3679eb0 100644
> --- a/gnu/packages/xfce.scm
> +++ b/gnu/packages/xfce.scm
> @@ -65,7 +65,7 @@
>  (define-public libxfce4util
>    (package
>      (name "libxfce4util")
> -    (version "4.10.0")
> +    (version "4.12.1")
>      (source (origin
>                (method url-fetch)
>                (uri (string-append "http://archive.xfce.org/xfce/"
> @@ -73,7 +73,7 @@
>                                    "/src/" name "-" version ".tar.bz2"))
>                (sha256
>                 (base32
> -                "13k0wwbbqvdmbj4xmk4nxdlgvrdgr5y6r3dk380mzfw053hzwy89"))))
> +                "07c8r3xwx5is298zk77m3r784gmr5y4mh8bbca5zdjqk5vxdwsw7"))))
>      (build-system gnu-build-system)
>      (native-inputs
>       `(("pkg-config" ,pkg-config)
> -- 
> 2.1.2
>
>

LGTM.

-- 
David Thompson
Web Developer - Free Software Foundation - http://fsf.org
GPG Key: 0FF1D807
Support the FSF: https://fsf.org/donate

[PATCH 03/15] gnu: xfconf: Update to 4.12.0.

[宋文武]

* gnu/packages/xfce.scm (xfconf): Update to 4.12.0.
  [arguments]: Add #:phases.  Remove #:parallel-tests? argument.
---
 gnu/packages/xfce.scm | 17 ++++++++++++++---
 1 file changed, 14 insertions(+), 3 deletions(-)

diff --git a/gnu/packages/xfce.scm b/gnu/packages/xfce.scm
index 3679eb0..0e45ee4 100644
--- a/gnu/packages/xfce.scm
+++ b/gnu/packages/xfce.scm
@@ -89,7 +89,7 @@ Xfce Desktop Environment.")
 (define-public xfconf
   (package
     (name "xfconf")
-    (version "4.10.0")
+    (version "4.12.0")
     (source (origin
               (method url-fetch)
               (uri (string-append "http://archive.xfce.org/xfce/"
@@ -97,9 +97,20 @@ Xfce Desktop Environment.")
                                   "/src/" name "-" version ".tar.bz2"))
               (sha256
                (base32
-                "0xh520z0qh0ib0ijgnyrgii9h5d4pc53n6mx1chhyzfc86j1jlhp"))))
+                "0mmi0g30aln3x98y5p507g17pipq0dj0bwypshan8cq5hkmfl44r"))))
     (build-system gnu-build-system)
-    (arguments '(#:parallel-tests? #f)) ; parallel tests failed
+    (arguments
+     '(#:phases
+       ;; Swap check and install phases.
+       (alist-cons-after
+        'install 'check
+        (lambda _
+          (setenv "HOME" (getenv "TMPDIR")) ; xfconfd requires a writable HOME
+          ;; Run test-suite under a dbus session.
+          (setenv "XDG_DATA_DIRS" ; for finding org.xfce.Xfconf.service
+                  (string-append %output "/share"))
+          (zero? (system* "dbus-launch" "make" "check")))
+        (alist-delete 'check %standard-phases))))
     (native-inputs
      `(("pkg-config" ,pkg-config)
        ("intltool" ,intltool)))
-- 
2.1.2

Re: [PATCH 03/15] gnu: xfconf: Update to 4.12.0.

[David Thompson]

宋文武 <iyzsong@gmail.com> writes:

> * gnu/packages/xfce.scm (xfconf): Update to 4.12.0.
>   [arguments]: Add #:phases.  Remove #:parallel-tests? argument.
> ---
>  gnu/packages/xfce.scm | 17 ++++++++++++++---
>  1 file changed, 14 insertions(+), 3 deletions(-)
>
> diff --git a/gnu/packages/xfce.scm b/gnu/packages/xfce.scm
> index 3679eb0..0e45ee4 100644
> --- a/gnu/packages/xfce.scm
> +++ b/gnu/packages/xfce.scm
> @@ -89,7 +89,7 @@ Xfce Desktop Environment.")
>  (define-public xfconf
>    (package
>      (name "xfconf")
> -    (version "4.10.0")
> +    (version "4.12.0")
>      (source (origin
>                (method url-fetch)
>                (uri (string-append "http://archive.xfce.org/xfce/"
> @@ -97,9 +97,20 @@ Xfce Desktop Environment.")
>                                    "/src/" name "-" version ".tar.bz2"))
>                (sha256
>                 (base32
> -                "0xh520z0qh0ib0ijgnyrgii9h5d4pc53n6mx1chhyzfc86j1jlhp"))))
> +                "0mmi0g30aln3x98y5p507g17pipq0dj0bwypshan8cq5hkmfl44r"))))
>      (build-system gnu-build-system)
> -    (arguments '(#:parallel-tests? #f)) ; parallel tests failed
> +    (arguments
> +     '(#:phases
> +       ;; Swap check and install phases.
> +       (alist-cons-after
> +        'install 'check
> +        (lambda _
> +          (setenv "HOME" (getenv "TMPDIR")) ; xfconfd requires a writable HOME
> +          ;; Run test-suite under a dbus session.
> +          (setenv "XDG_DATA_DIRS" ; for finding org.xfce.Xfconf.service
> +                  (string-append %output "/share"))
> +          (zero? (system* "dbus-launch" "make" "check")))
> +        (alist-delete 'check %standard-phases))))

So, tests need to be run *after* installation?  Weird...

>      (native-inputs
>       `(("pkg-config" ,pkg-config)
>         ("intltool" ,intltool)))
> -- 
> 2.1.2
>
>

LGTM!

-- 
David Thompson
Web Developer - Free Software Foundation - http://fsf.org
GPG Key: 0FF1D807
Support the FSF: https://fsf.org/donate

Re: [PATCH 03/15] gnu: xfconf: Update to 4.12.0.

[Mark H Weaver]

宋文武 <iyzsong@gmail.com> writes:

> * gnu/packages/xfce.scm (xfconf): Update to 4.12.0.
>   [arguments]: Add #:phases.  Remove #:parallel-tests? argument.

I'm sorry, but I pushed my own urgent update of 'xfconf' before noticing
that you had already proposed this commit, which is better than mine
because it preserves the test suite.

The problem is that you pushed the other updates before pushing this
one, which resulted in almost all of the xfce builds failing.  I then
felt compelled to quickly fix things up.

Would you like to change the 'xfconf' package to match what you have
below?  Also, please remember to add "2015" to your copyright line at
the top of xfce.scm.

    Thanks!
      Mark

> ---
>  gnu/packages/xfce.scm | 17 ++++++++++++++---
>  1 file changed, 14 insertions(+), 3 deletions(-)
>
> diff --git a/gnu/packages/xfce.scm b/gnu/packages/xfce.scm
> index 3679eb0..0e45ee4 100644
> --- a/gnu/packages/xfce.scm
> +++ b/gnu/packages/xfce.scm
> @@ -89,7 +89,7 @@ Xfce Desktop Environment.")
>  (define-public xfconf
>    (package
>      (name "xfconf")
> -    (version "4.10.0")
> +    (version "4.12.0")
>      (source (origin
>                (method url-fetch)
>                (uri (string-append "http://archive.xfce.org/xfce/"
> @@ -97,9 +97,20 @@ Xfce Desktop Environment.")
>                                    "/src/" name "-" version ".tar.bz2"))
>                (sha256
>                 (base32
> -                "0xh520z0qh0ib0ijgnyrgii9h5d4pc53n6mx1chhyzfc86j1jlhp"))))
> +                "0mmi0g30aln3x98y5p507g17pipq0dj0bwypshan8cq5hkmfl44r"))))
>      (build-system gnu-build-system)
> -    (arguments '(#:parallel-tests? #f)) ; parallel tests failed
> +    (arguments
> +     '(#:phases
> +       ;; Swap check and install phases.
> +       (alist-cons-after
> +        'install 'check
> +        (lambda _
> +          (setenv "HOME" (getenv "TMPDIR")) ; xfconfd requires a writable HOME
> +          ;; Run test-suite under a dbus session.
> +          (setenv "XDG_DATA_DIRS" ; for finding org.xfce.Xfconf.service
> +                  (string-append %output "/share"))
> +          (zero? (system* "dbus-launch" "make" "check")))
> +        (alist-delete 'check %standard-phases))))
>      (native-inputs
>       `(("pkg-config" ,pkg-config)
>         ("intltool" ,intltool)))

[PATCH 04/15] gnu: libxfce4ui: Update to 4.12.0.

[宋文武]

* gnu/packages/xfce.scm (libxfce4ui): Update to 4.12.0.
---
 gnu/packages/xfce.scm | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/gnu/packages/xfce.scm b/gnu/packages/xfce.scm
index 0e45ee4..7042518 100644
--- a/gnu/packages/xfce.scm
+++ b/gnu/packages/xfce.scm
@@ -131,7 +131,7 @@ storage system.")
 (define-public libxfce4ui
   (package
     (name "libxfce4ui")
-    (version "4.10.0")
+    (version "4.12.0")
     (source (origin
               (method url-fetch)
               (uri (string-append "http://archive.xfce.org/xfce/"
@@ -139,7 +139,7 @@ storage system.")
                                   "/src/" name "-" version ".tar.bz2"))
               (sha256
                (base32
-                "1qm31s6568cz4c8rl9fsfq0xmf7pldxm0ki62gx1cpybihlgmfd2"))))
+                "11rrhqxnfwx5jls3nlg9s2x8saag9f2zqk9cdm6hr3bs6cr9a781"))))
     (build-system gnu-build-system)
     (native-inputs
      `(("pkg-config" ,pkg-config)
-- 
2.1.2

Re: [PATCH 04/15] gnu: libxfce4ui: Update to 4.12.0.

[David Thompson]

宋文武 <iyzsong@gmail.com> writes:

> * gnu/packages/xfce.scm (libxfce4ui): Update to 4.12.0.
> ---
>  gnu/packages/xfce.scm | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/gnu/packages/xfce.scm b/gnu/packages/xfce.scm
> index 0e45ee4..7042518 100644
> --- a/gnu/packages/xfce.scm
> +++ b/gnu/packages/xfce.scm
> @@ -131,7 +131,7 @@ storage system.")
>  (define-public libxfce4ui
>    (package
>      (name "libxfce4ui")
> -    (version "4.10.0")
> +    (version "4.12.0")
>      (source (origin
>                (method url-fetch)
>                (uri (string-append "http://archive.xfce.org/xfce/"
> @@ -139,7 +139,7 @@ storage system.")
>                                    "/src/" name "-" version ".tar.bz2"))
>                (sha256
>                 (base32
> -                "1qm31s6568cz4c8rl9fsfq0xmf7pldxm0ki62gx1cpybihlgmfd2"))))
> +                "11rrhqxnfwx5jls3nlg9s2x8saag9f2zqk9cdm6hr3bs6cr9a781"))))
>      (build-system gnu-build-system)
>      (native-inputs
>       `(("pkg-config" ,pkg-config)
> -- 
> 2.1.2
>
>

LGTM.

-- 
David Thompson
Web Developer - Free Software Foundation - http://fsf.org
GPG Key: 0FF1D807
Support the FSF: https://fsf.org/donate

[PATCH 05/15] gnu: exo: Update to 0.10.3.

[宋文武]

* gnu/packages/xfce.scm (exo): Update to 0.10.3.
---
 gnu/packages/xfce.scm | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/gnu/packages/xfce.scm b/gnu/packages/xfce.scm
index 7042518..c2386b5 100644
--- a/gnu/packages/xfce.scm
+++ b/gnu/packages/xfce.scm
@@ -162,14 +162,14 @@ to share commonly used Xfce widgets amoung the Xfce applications.")
 (define-public exo
   (package
     (name "exo")
-    (version "0.8.0")
+    (version "0.10.3")
     (source (origin
               (method url-fetch)
-              (uri (string-append "http://archive.xfce.org/xfce/4.10/src/"
+              (uri (string-append "http://archive.xfce.org/xfce/4.12/src/"
                                   name "-" version ".tar.bz2"))
               (sha256
                (base32
-                "1c05pbagw14djv5zmqg34qfj40jav8sd10w2zi2wpzrad4qal8bf"))))
+                "1g9651ra395v2fmzb943l68b9pg0rfxc19x97a62crchxwa4nw4m"))))
     (build-system gnu-build-system)
     (native-inputs
      `(("pkg-config" ,pkg-config)
-- 
2.1.2

Re: [PATCH 05/15] gnu: exo: Update to 0.10.3.

[David Thompson]

宋文武 <iyzsong@gmail.com> writes:

> * gnu/packages/xfce.scm (exo): Update to 0.10.3.
> ---
>  gnu/packages/xfce.scm | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/gnu/packages/xfce.scm b/gnu/packages/xfce.scm
> index 7042518..c2386b5 100644
> --- a/gnu/packages/xfce.scm
> +++ b/gnu/packages/xfce.scm
> @@ -162,14 +162,14 @@ to share commonly used Xfce widgets amoung the Xfce applications.")
>  (define-public exo
>    (package
>      (name "exo")
> -    (version "0.8.0")
> +    (version "0.10.3")
>      (source (origin
>                (method url-fetch)
> -              (uri (string-append "http://archive.xfce.org/xfce/4.10/src/"
> +              (uri (string-append "http://archive.xfce.org/xfce/4.12/src/"
>                                    name "-" version ".tar.bz2"))
>                (sha256
>                 (base32
> -                "1c05pbagw14djv5zmqg34qfj40jav8sd10w2zi2wpzrad4qal8bf"))))
> +                "1g9651ra395v2fmzb943l68b9pg0rfxc19x97a62crchxwa4nw4m"))))
>      (build-system gnu-build-system)
>      (native-inputs
>       `(("pkg-config" ,pkg-config)
> -- 
> 2.1.2
>
>

LGTM.

-- 
David Thompson
Web Developer - Free Software Foundation - http://fsf.org
GPG Key: 0FF1D807
Support the FSF: https://fsf.org/donate

[PATCH 06/15] gnu: garcon: Update to 0.4.0.

[宋文武]

* gnu/packages/xfce.scm (garcon): Update to 0.4.0.
---
 gnu/packages/xfce.scm | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/gnu/packages/xfce.scm b/gnu/packages/xfce.scm
index c2386b5..afc190e 100644
--- a/gnu/packages/xfce.scm
+++ b/gnu/packages/xfce.scm
@@ -193,21 +193,21 @@ development.")
 (define-public garcon
   (package
     (name "garcon")
-    (version "0.2.0")
+    (version "0.4.0")
     (source (origin
               (method url-fetch)
-              (uri (string-append "http://archive.xfce.org/xfce/4.10/src/"
+              (uri (string-append "http://archive.xfce.org/xfce/4.12/src/"
                                   name "-" version ".tar.bz2"))
               (sha256
                (base32
-                "0v7pkvxcayi86z4f173z5l7w270f3g369sa88z59w0y0p7ns7ph2"))))
+                "0wm9pjbwq53s3n3nwvsyf0q8lbmhiy2ln3bn5ncihr9vf5cwhzbq"))))
     (build-system gnu-build-system)
     (native-inputs
      `(("pkg-config" ,pkg-config)
        ("intltool" ,intltool)
        ("glib:bin" ,glib "bin")))
-    (propagated-inputs `(("glib" ,glib))) ; required by garcon-1.pc
-    (inputs `(("libxfce4util" ,libxfce4util)))
+    (propagated-inputs
+     `(("libxfce4ui" ,libxfce4ui))) ; required by garcon-gtk2-1.pc
     (home-page "http://www.xfce.org/")
     (synopsis "Implementation of the freedesktop.org menu specification")
     (description
-- 
2.1.2

Re: [PATCH 06/15] gnu: garcon: Update to 0.4.0.

[David Thompson]

宋文武 <iyzsong@gmail.com> writes:

> * gnu/packages/xfce.scm (garcon): Update to 0.4.0.
> ---
>  gnu/packages/xfce.scm | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/gnu/packages/xfce.scm b/gnu/packages/xfce.scm
> index c2386b5..afc190e 100644
> --- a/gnu/packages/xfce.scm
> +++ b/gnu/packages/xfce.scm
> @@ -193,21 +193,21 @@ development.")
>  (define-public garcon
>    (package
>      (name "garcon")
> -    (version "0.2.0")
> +    (version "0.4.0")
>      (source (origin
>                (method url-fetch)
> -              (uri (string-append "http://archive.xfce.org/xfce/4.10/src/"
> +              (uri (string-append "http://archive.xfce.org/xfce/4.12/src/"
>                                    name "-" version ".tar.bz2"))
>                (sha256
>                 (base32
> -                "0v7pkvxcayi86z4f173z5l7w270f3g369sa88z59w0y0p7ns7ph2"))))
> +                "0wm9pjbwq53s3n3nwvsyf0q8lbmhiy2ln3bn5ncihr9vf5cwhzbq"))))
>      (build-system gnu-build-system)
>      (native-inputs
>       `(("pkg-config" ,pkg-config)
>         ("intltool" ,intltool)
>         ("glib:bin" ,glib "bin")))
> -    (propagated-inputs `(("glib" ,glib))) ; required by garcon-1.pc
> -    (inputs `(("libxfce4util" ,libxfce4util)))
> +    (propagated-inputs
> +     `(("libxfce4ui" ,libxfce4ui))) ; required by garcon-gtk2-1.pc
>      (home-page "http://www.xfce.org/")
>      (synopsis "Implementation of the freedesktop.org menu specification")
>      (description
> -- 
> 2.1.2
>
>

LGTM.

-- 
David Thompson
Web Developer - Free Software Foundation - http://fsf.org
GPG Key: 0FF1D807
Support the FSF: https://fsf.org/donate

[PATCH 07/15] gnu: tumbler: Update to 0.1.31.

[宋文武]

* gnu/packages/xfce.scm (tumbler): Update to 0.1.31.
---
 gnu/packages/xfce.scm | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/gnu/packages/xfce.scm b/gnu/packages/xfce.scm
index afc190e..94198c6 100644
--- a/gnu/packages/xfce.scm
+++ b/gnu/packages/xfce.scm
@@ -220,14 +220,14 @@ merging features essential for loading menus modified with menu editors.")
 (define-public tumbler
   (package
     (name "tumbler")
-    (version "0.1.30")
+    (version "0.1.31")
     (source (origin
               (method url-fetch)
               (uri (string-append "http://archive.xfce.org/src/xfce/tumbler/0.1/"
                                   name "-" version ".tar.bz2"))
               (sha256
                (base32
-                "013kacqyy1vya7kp6jgc1almp3cbbvq96a3r7f5myiihr1whvhp7"))))
+                "0wvip28gm2w061hn84zp2q4dv947ihylrppahn4cjspzff935zfh"))))
     (build-system gnu-build-system)
     (native-inputs
      `(("pkg-config" ,pkg-config)
-- 
2.1.2

Re: [PATCH 07/15] gnu: tumbler: Update to 0.1.31.

[David Thompson]

宋文武 <iyzsong@gmail.com> writes:

> * gnu/packages/xfce.scm (tumbler): Update to 0.1.31.
> ---
>  gnu/packages/xfce.scm | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/gnu/packages/xfce.scm b/gnu/packages/xfce.scm
> index afc190e..94198c6 100644
> --- a/gnu/packages/xfce.scm
> +++ b/gnu/packages/xfce.scm
> @@ -220,14 +220,14 @@ merging features essential for loading menus modified with menu editors.")
>  (define-public tumbler
>    (package
>      (name "tumbler")
> -    (version "0.1.30")
> +    (version "0.1.31")
>      (source (origin
>                (method url-fetch)
>                (uri (string-append "http://archive.xfce.org/src/xfce/tumbler/0.1/"
>                                    name "-" version ".tar.bz2"))
>                (sha256
>                 (base32
> -                "013kacqyy1vya7kp6jgc1almp3cbbvq96a3r7f5myiihr1whvhp7"))))
> +                "0wvip28gm2w061hn84zp2q4dv947ihylrppahn4cjspzff935zfh"))))
>      (build-system gnu-build-system)
>      (native-inputs
>       `(("pkg-config" ,pkg-config)
> -- 
> 2.1.2
>
>

LGTM.

-- 
David Thompson
Web Developer - Free Software Foundation - http://fsf.org
GPG Key: 0FF1D807
Support the FSF: https://fsf.org/donate

[PATCH 08/15] gnu: xfce4-panel: Update to 4.12.0.

[宋文武]

* gnu/packages/xfce.scm (xfce4-panel): Update to 4.12.0.
---
 gnu/packages/xfce.scm | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/gnu/packages/xfce.scm b/gnu/packages/xfce.scm
index 94198c6..0d247be 100644
--- a/gnu/packages/xfce.scm
+++ b/gnu/packages/xfce.scm
@@ -255,7 +255,7 @@ management D-Bus specification.")
 (define-public xfce4-panel
   (package
     (name "xfce4-panel")
-    (version "4.10.0")
+    (version "4.12.0")
     (source (origin
               (method url-fetch)
               (uri (string-append "http://archive.xfce.org/xfce/"
@@ -263,7 +263,7 @@ management D-Bus specification.")
                                   "/src/" name "-" version ".tar.bz2"))
               (sha256
                (base32
-                "1f8903nx6ivzircl8d8s9zna4vjgfy0qhjk5d2x19g9bmycgj89k"))
+                "1c4p3ckghvsad1sj5v8wmar5mh9cbhail9mmhad2f9pwwb10z4ih"))
               (patches (list (search-patch "xfce4-panel-plugins.patch")))))
     (build-system gnu-build-system)
     (native-inputs
-- 
2.1.2

Re: [PATCH 08/15] gnu: xfce4-panel: Update to 4.12.0.

[David Thompson]

宋文武 <iyzsong@gmail.com> writes:

> * gnu/packages/xfce.scm (xfce4-panel): Update to 4.12.0.
> ---
>  gnu/packages/xfce.scm | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/gnu/packages/xfce.scm b/gnu/packages/xfce.scm
> index 94198c6..0d247be 100644
> --- a/gnu/packages/xfce.scm
> +++ b/gnu/packages/xfce.scm
> @@ -255,7 +255,7 @@ management D-Bus specification.")
>  (define-public xfce4-panel
>    (package
>      (name "xfce4-panel")
> -    (version "4.10.0")
> +    (version "4.12.0")
>      (source (origin
>                (method url-fetch)
>                (uri (string-append "http://archive.xfce.org/xfce/"
> @@ -263,7 +263,7 @@ management D-Bus specification.")
>                                    "/src/" name "-" version ".tar.bz2"))
>                (sha256
>                 (base32
> -                "1f8903nx6ivzircl8d8s9zna4vjgfy0qhjk5d2x19g9bmycgj89k"))
> +                "1c4p3ckghvsad1sj5v8wmar5mh9cbhail9mmhad2f9pwwb10z4ih"))
>                (patches (list (search-patch "xfce4-panel-plugins.patch")))))
>      (build-system gnu-build-system)
>      (native-inputs
> -- 
> 2.1.2
>
>

LGTM.

-- 
David Thompson
Web Developer - Free Software Foundation - http://fsf.org
GPG Key: 0FF1D807
Support the FSF: https://fsf.org/donate

[PATCH 09/15] gnu: xfce4-appfinder: Update to 4.12.0.

[宋文武]

* gnu/packages/xfce.scm (xfce4-appfinder): Update to 4.12.0.
---
 gnu/packages/xfce.scm | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/gnu/packages/xfce.scm b/gnu/packages/xfce.scm
index 0d247be..3b0f9f2 100644
--- a/gnu/packages/xfce.scm
+++ b/gnu/packages/xfce.scm
@@ -320,7 +320,7 @@ applications menu, workspace switcher and more.")
 (define-public xfce4-appfinder
   (package
     (name "xfce4-appfinder")
-    (version "4.10.0")
+    (version "4.12.0")
     (source (origin
               (method url-fetch)
               (uri (string-append "http://archive.xfce.org/xfce/"
@@ -328,7 +328,7 @@ applications menu, workspace switcher and more.")
                                   "/src/" name "-" version ".tar.bz2"))
               (sha256
                (base32
-                "0falckrziw8m1a72nxd7fqq84r3xfbrb6lv35flsca346rzawah4"))))
+                "0ry5hin8xhgnkmm9vs7jq8blk1cnbyr0s18nm1j6nsm7360abm1a"))))
     (build-system gnu-build-system)
     (native-inputs
      `(("pkg-config" ,pkg-config)
-- 
2.1.2

Re: [PATCH 09/15] gnu: xfce4-appfinder: Update to 4.12.0.

[David Thompson]

宋文武 <iyzsong@gmail.com> writes:

> * gnu/packages/xfce.scm (xfce4-appfinder): Update to 4.12.0.
> ---
>  gnu/packages/xfce.scm | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/gnu/packages/xfce.scm b/gnu/packages/xfce.scm
> index 0d247be..3b0f9f2 100644
> --- a/gnu/packages/xfce.scm
> +++ b/gnu/packages/xfce.scm
> @@ -320,7 +320,7 @@ applications menu, workspace switcher and more.")
>  (define-public xfce4-appfinder
>    (package
>      (name "xfce4-appfinder")
> -    (version "4.10.0")
> +    (version "4.12.0")
>      (source (origin
>                (method url-fetch)
>                (uri (string-append "http://archive.xfce.org/xfce/"
> @@ -328,7 +328,7 @@ applications menu, workspace switcher and more.")
>                                    "/src/" name "-" version ".tar.bz2"))
>                (sha256
>                 (base32
> -                "0falckrziw8m1a72nxd7fqq84r3xfbrb6lv35flsca346rzawah4"))))
> +                "0ry5hin8xhgnkmm9vs7jq8blk1cnbyr0s18nm1j6nsm7360abm1a"))))
>      (build-system gnu-build-system)
>      (native-inputs
>       `(("pkg-config" ,pkg-config)
> -- 
> 2.1.2
>
>

LGTM.

-- 
David Thompson
Web Developer - Free Software Foundation - http://fsf.org
GPG Key: 0FF1D807
Support the FSF: https://fsf.org/donate

[PATCH 10/15] gnu: xfce4-session: Update to 4.12.0.

[宋文武]

* gnu/packages/xfce.scm (xfce4-session): Update to 4.12.0.
---
 gnu/packages/xfce.scm | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/gnu/packages/xfce.scm b/gnu/packages/xfce.scm
index 3b0f9f2..40f75aa 100644
--- a/gnu/packages/xfce.scm
+++ b/gnu/packages/xfce.scm
@@ -346,7 +346,7 @@ your system in categories, so you can quickly find and launch them.")
 (define-public xfce4-session
   (package
     (name "xfce4-session")
-    (version "4.10.0")
+    (version "4.12.0")
     (source (origin
               (method url-fetch)
               (uri (string-append "http://archive.xfce.org/xfce/"
@@ -354,7 +354,7 @@ your system in categories, so you can quickly find and launch them.")
                                   "/src/" name "-" version ".tar.bz2"))
               (sha256
                (base32
-                "1kj65jkjhd0ysf0yxsf88wzpyv6n8i8qgd3gb502hf1x9jksk2mv"))))
+                "01kvbd09c06j20n155hracsgrq06rlmfgdywffjsvlwpn19m9j38"))))
     (build-system gnu-build-system)
     (arguments
      '(#:configure-flags
-- 
2.1.2

Re: [PATCH 10/15] gnu: xfce4-session: Update to 4.12.0.

[David Thompson]

宋文武 <iyzsong@gmail.com> writes:

> * gnu/packages/xfce.scm (xfce4-session): Update to 4.12.0.
> ---
>  gnu/packages/xfce.scm | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/gnu/packages/xfce.scm b/gnu/packages/xfce.scm
> index 3b0f9f2..40f75aa 100644
> --- a/gnu/packages/xfce.scm
> +++ b/gnu/packages/xfce.scm
> @@ -346,7 +346,7 @@ your system in categories, so you can quickly find and launch them.")
>  (define-public xfce4-session
>    (package
>      (name "xfce4-session")
> -    (version "4.10.0")
> +    (version "4.12.0")
>      (source (origin
>                (method url-fetch)
>                (uri (string-append "http://archive.xfce.org/xfce/"
> @@ -354,7 +354,7 @@ your system in categories, so you can quickly find and launch them.")
>                                    "/src/" name "-" version ".tar.bz2"))
>                (sha256
>                 (base32
> -                "1kj65jkjhd0ysf0yxsf88wzpyv6n8i8qgd3gb502hf1x9jksk2mv"))))
> +                "01kvbd09c06j20n155hracsgrq06rlmfgdywffjsvlwpn19m9j38"))))
>      (build-system gnu-build-system)
>      (arguments
>       '(#:configure-flags
> -- 
> 2.1.2
>
>

LGTM.

-- 
David Thompson
Web Developer - Free Software Foundation - http://fsf.org
GPG Key: 0FF1D807
Support the FSF: https://fsf.org/donate

[PATCH 11/15] gnu: xfce4-settings: Update to 4.12.0.

[宋文武]

* gnu/packages/xfce.scm (xfce4-settings): Update to 4.12.0.
---
 gnu/packages/xfce.scm | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/gnu/packages/xfce.scm b/gnu/packages/xfce.scm
index 40f75aa..1c45c20 100644
--- a/gnu/packages/xfce.scm
+++ b/gnu/packages/xfce.scm
@@ -377,7 +377,7 @@ allows you to shutdown the computer from Xfce.")
 (define-public xfce4-settings
   (package
     (name "xfce4-settings")
-    (version "4.10.0")
+    (version "4.12.0")
     (source (origin
               (method url-fetch)
               (uri (string-append "http://archive.xfce.org/xfce/"
@@ -385,7 +385,7 @@ allows you to shutdown the computer from Xfce.")
                                   "/src/" name "-" version ".tar.bz2"))
               (sha256
                (base32
-                "0zppq747z9lrxyv5zrrvpalq7hb3gfhy9p7qbldisgv7m6dz0hq8"))))
+                "108za1cmjslwzkdl76x9kwxkq8z734kg9nz8rxk057f10pqwxgh4"))))
     (build-system gnu-build-system)
     (native-inputs
      `(("pkg-config" ,pkg-config)
-- 
2.1.2

Re: [PATCH 11/15] gnu: xfce4-settings: Update to 4.12.0.

[David Thompson]

宋文武 <iyzsong@gmail.com> writes:

> * gnu/packages/xfce.scm (xfce4-settings): Update to 4.12.0.
> ---
>  gnu/packages/xfce.scm | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/gnu/packages/xfce.scm b/gnu/packages/xfce.scm
> index 40f75aa..1c45c20 100644
> --- a/gnu/packages/xfce.scm
> +++ b/gnu/packages/xfce.scm
> @@ -377,7 +377,7 @@ allows you to shutdown the computer from Xfce.")
>  (define-public xfce4-settings
>    (package
>      (name "xfce4-settings")
> -    (version "4.10.0")
> +    (version "4.12.0")
>      (source (origin
>                (method url-fetch)
>                (uri (string-append "http://archive.xfce.org/xfce/"
> @@ -385,7 +385,7 @@ allows you to shutdown the computer from Xfce.")
>                                    "/src/" name "-" version ".tar.bz2"))
>                (sha256
>                 (base32
> -                "0zppq747z9lrxyv5zrrvpalq7hb3gfhy9p7qbldisgv7m6dz0hq8"))))
> +                "108za1cmjslwzkdl76x9kwxkq8z734kg9nz8rxk057f10pqwxgh4"))))
>      (build-system gnu-build-system)
>      (native-inputs
>       `(("pkg-config" ,pkg-config)
> -- 
> 2.1.2
>
>

LGTM.

-- 
David Thompson
Web Developer - Free Software Foundation - http://fsf.org
GPG Key: 0FF1D807
Support the FSF: https://fsf.org/donate

[PATCH 12/15] gnu: thunar: Update to 1.6.6.

[宋文武]

* gnu/packages/xfce.scm (thunar): Update to 1.6.6.
---
 gnu/packages/xfce.scm | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/gnu/packages/xfce.scm b/gnu/packages/xfce.scm
index 1c45c20..a5422c4 100644
--- a/gnu/packages/xfce.scm
+++ b/gnu/packages/xfce.scm
@@ -408,14 +408,14 @@ like appearance, display, keyboard and mouse settings.")
 (define-public thunar
   (package
     (name "thunar")
-    (version "1.4.0")
+    (version "1.6.6")
     (source (origin
               (method url-fetch)
-              (uri (string-append "http://archive.xfce.org/xfce/4.10/src/"
+              (uri (string-append "http://archive.xfce.org/xfce/4.12/src/"
                                   "Thunar-" version ".tar.bz2"))
               (sha256
                (base32
-                "1fn8wjzkfvnx2giv3rrg2cyrr2c96f9mskgvcji0ixyfcjga249c"))))
+                "1cl9v3rdzipyyxml3pyrzspxfmmssz5h5snpj18irq4an42539dr"))))
     (build-system gnu-build-system)
     (native-inputs
      `(("pkg-config" ,pkg-config)
-- 
2.1.2

Re: [PATCH 12/15] gnu: thunar: Update to 1.6.6.

[David Thompson]

宋文武 <iyzsong@gmail.com> writes:

> * gnu/packages/xfce.scm (thunar): Update to 1.6.6.
> ---
>  gnu/packages/xfce.scm | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/gnu/packages/xfce.scm b/gnu/packages/xfce.scm
> index 1c45c20..a5422c4 100644
> --- a/gnu/packages/xfce.scm
> +++ b/gnu/packages/xfce.scm
> @@ -408,14 +408,14 @@ like appearance, display, keyboard and mouse settings.")
>  (define-public thunar
>    (package
>      (name "thunar")
> -    (version "1.4.0")
> +    (version "1.6.6")
>      (source (origin
>                (method url-fetch)
> -              (uri (string-append "http://archive.xfce.org/xfce/4.10/src/"
> +              (uri (string-append "http://archive.xfce.org/xfce/4.12/src/"
>                                    "Thunar-" version ".tar.bz2"))
>                (sha256
>                 (base32
> -                "1fn8wjzkfvnx2giv3rrg2cyrr2c96f9mskgvcji0ixyfcjga249c"))))
> +                "1cl9v3rdzipyyxml3pyrzspxfmmssz5h5snpj18irq4an42539dr"))))
>      (build-system gnu-build-system)
>      (native-inputs
>       `(("pkg-config" ,pkg-config)
> -- 
> 2.1.2
>
>

LGTM.

-- 
David Thompson
Web Developer - Free Software Foundation - http://fsf.org
GPG Key: 0FF1D807
Support the FSF: https://fsf.org/donate

[PATCH 13/15] gnu: thunar-volman: Update to 0.8.1.

[宋文武]

* gnu/packages/xfce.scm (thunar-volman): Update to 0.8.1.
---
 gnu/packages/xfce.scm | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/gnu/packages/xfce.scm b/gnu/packages/xfce.scm
index a5422c4..0f8de9d 100644
--- a/gnu/packages/xfce.scm
+++ b/gnu/packages/xfce.scm
@@ -439,14 +439,14 @@ fast.")
 (define-public thunar-volman
   (package
     (name "thunar-volman")
-    (version "0.8.0")
+    (version "0.8.1")
     (source (origin
               (method url-fetch)
-              (uri (string-append "http://archive.xfce.org/xfce/4.10/src/"
+              (uri (string-append "http://archive.xfce.org/xfce/4.12/src/"
                                   name "-" version ".tar.bz2"))
               (sha256
                (base32
-                "1sxw09fwyn5sr6ipxk7r8gqjyf41c2v7vkgl0l6mhy5mcb48f27z"))))
+                "1gf259n1v3y23n1zlkhyr6r0i8j59rnl1cmxvxj6la9cwdfbn22s"))))
     (build-system gnu-build-system)
     (native-inputs
      `(("pkg-config" ,pkg-config)
-- 
2.1.2

Re: [PATCH 13/15] gnu: thunar-volman: Update to 0.8.1.

[David Thompson]

宋文武 <iyzsong@gmail.com> writes:

> * gnu/packages/xfce.scm (thunar-volman): Update to 0.8.1.
> ---
>  gnu/packages/xfce.scm | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/gnu/packages/xfce.scm b/gnu/packages/xfce.scm
> index a5422c4..0f8de9d 100644
> --- a/gnu/packages/xfce.scm
> +++ b/gnu/packages/xfce.scm
> @@ -439,14 +439,14 @@ fast.")
>  (define-public thunar-volman
>    (package
>      (name "thunar-volman")
> -    (version "0.8.0")
> +    (version "0.8.1")
>      (source (origin
>                (method url-fetch)
> -              (uri (string-append "http://archive.xfce.org/xfce/4.10/src/"
> +              (uri (string-append "http://archive.xfce.org/xfce/4.12/src/"
>                                    name "-" version ".tar.bz2"))
>                (sha256
>                 (base32
> -                "1sxw09fwyn5sr6ipxk7r8gqjyf41c2v7vkgl0l6mhy5mcb48f27z"))))
> +                "1gf259n1v3y23n1zlkhyr6r0i8j59rnl1cmxvxj6la9cwdfbn22s"))))
>      (build-system gnu-build-system)
>      (native-inputs
>       `(("pkg-config" ,pkg-config)
> -- 
> 2.1.2
>
>

LGTM.

-- 
David Thompson
Web Developer - Free Software Foundation - http://fsf.org
GPG Key: 0FF1D807
Support the FSF: https://fsf.org/donate

[PATCH 14/15] gnu: xfwm4: Update to 4.12.0.

[宋文武]

* gnu/packages/xfce.scm (xfwm4): Update to 4.12.0.
  Add 'libdrm' and 'libxdamage' to inputs.
---
 gnu/packages/xfce.scm | 12 +++++++-----
 1 file changed, 7 insertions(+), 5 deletions(-)

diff --git a/gnu/packages/xfce.scm b/gnu/packages/xfce.scm
index 0f8de9d..7d93de7 100644
--- a/gnu/packages/xfce.scm
+++ b/gnu/packages/xfce.scm
@@ -469,7 +469,7 @@ and import the new pictures from your camera.")
 (define-public xfwm4
   (package
     (name "xfwm4")
-    (version "4.10.0")
+    (version "4.12.0")
     (source (origin
               (method url-fetch)
               (uri (string-append "http://archive.xfce.org/xfce/"
@@ -477,16 +477,18 @@ and import the new pictures from your camera.")
                                   "/src/" name "-" version ".tar.bz2"))
               (sha256
                (base32
-                "170zzs7adj47srsi2cl723w9pl8k8awd7w1bpzxby7hj92zmf8s9"))))
+                "0fnc2ps4k733n9qfpxrz047h1myyqjzxczl7fmkjmqwshvicpx19"))))
     (build-system gnu-build-system)
     (native-inputs
      `(("pkg-config" ,pkg-config)
        ("intltool" ,intltool)))
     (inputs
-     `(("libwnck", libwnck-1)
+     `(("libdrm" ,libdrm)
+       ("libwnck" ,libwnck-1)
+       ("libxcomposite" ,libxcomposite)
+       ("libxdamage" ,libxdamage)
        ("libxfce4ui" ,libxfce4ui)
-       ("libxrandr" ,libxrandr)
-       ("libxcomposite" ,libxcomposite)))
+       ("libxrandr" ,libxrandr)))
     (home-page "http://www.xfce.org/")
     (synopsis "Xfce window manager")
     (description
-- 
2.1.2

Re: [PATCH 14/15] gnu: xfwm4: Update to 4.12.0.

[David Thompson]

宋文武 <iyzsong@gmail.com> writes:

> * gnu/packages/xfce.scm (xfwm4): Update to 4.12.0.
>   Add 'libdrm' and 'libxdamage' to inputs.
> ---
>  gnu/packages/xfce.scm | 12 +++++++-----
>  1 file changed, 7 insertions(+), 5 deletions(-)
>
> diff --git a/gnu/packages/xfce.scm b/gnu/packages/xfce.scm
> index 0f8de9d..7d93de7 100644
> --- a/gnu/packages/xfce.scm
> +++ b/gnu/packages/xfce.scm
> @@ -469,7 +469,7 @@ and import the new pictures from your camera.")
>  (define-public xfwm4
>    (package
>      (name "xfwm4")
> -    (version "4.10.0")
> +    (version "4.12.0")
>      (source (origin
>                (method url-fetch)
>                (uri (string-append "http://archive.xfce.org/xfce/"
> @@ -477,16 +477,18 @@ and import the new pictures from your camera.")
>                                    "/src/" name "-" version ".tar.bz2"))
>                (sha256
>                 (base32
> -                "170zzs7adj47srsi2cl723w9pl8k8awd7w1bpzxby7hj92zmf8s9"))))
> +                "0fnc2ps4k733n9qfpxrz047h1myyqjzxczl7fmkjmqwshvicpx19"))))
>      (build-system gnu-build-system)
>      (native-inputs
>       `(("pkg-config" ,pkg-config)
>         ("intltool" ,intltool)))
>      (inputs
> -     `(("libwnck", libwnck-1)
> +     `(("libdrm" ,libdrm)
> +       ("libwnck" ,libwnck-1)
> +       ("libxcomposite" ,libxcomposite)
> +       ("libxdamage" ,libxdamage)
>         ("libxfce4ui" ,libxfce4ui)
> -       ("libxrandr" ,libxrandr)
> -       ("libxcomposite" ,libxcomposite)))
> +       ("libxrandr" ,libxrandr)))
>      (home-page "http://www.xfce.org/")
>      (synopsis "Xfce window manager")
>      (description
> -- 
> 2.1.2
>
>

LGTM.

-- 
David Thompson
Web Developer - Free Software Foundation - http://fsf.org
GPG Key: 0FF1D807
Support the FSF: https://fsf.org/donate

[PATCH 15/15] gnu: xfdesktop: Update to 4.12.0.

[宋文武]

* gnu/packages/xfce.scm (xfdesktop): Update to 4.12.0.
---
 gnu/packages/xfce.scm | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/gnu/packages/xfce.scm b/gnu/packages/xfce.scm
index 7d93de7..6e24a9a 100644
--- a/gnu/packages/xfce.scm
+++ b/gnu/packages/xfce.scm
@@ -499,7 +499,7 @@ on the screen.")
 (define-public xfdesktop
   (package
     (name "xfdesktop")
-    (version "4.10.0")
+    (version "4.12.0")
     (source (origin
               (method url-fetch)
               (uri (string-append "http://archive.xfce.org/xfce/"
@@ -507,7 +507,7 @@ on the screen.")
                                   "/src/" name "-" version ".tar.bz2"))
               (sha256
                (base32
-                "0yrddj1lgk3xn4w340y89z7x2isks72ia36pka08kk2x8gpfcyl9"))))
+                "1ivzgg4792nid6wcgd1nq5vc3z0y5ip6ymq7ci5j2qkp663qnykf"))))
     (build-system gnu-build-system)
     (native-inputs
      `(("pkg-config" ,pkg-config)
-- 
2.1.2

Re: [PATCH 15/15] gnu: xfdesktop: Update to 4.12.0.

[David Thompson]

宋文武 <iyzsong@gmail.com> writes:

> * gnu/packages/xfce.scm (xfdesktop): Update to 4.12.0.
> ---
>  gnu/packages/xfce.scm | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/gnu/packages/xfce.scm b/gnu/packages/xfce.scm
> index 7d93de7..6e24a9a 100644
> --- a/gnu/packages/xfce.scm
> +++ b/gnu/packages/xfce.scm
> @@ -499,7 +499,7 @@ on the screen.")
>  (define-public xfdesktop
>    (package
>      (name "xfdesktop")
> -    (version "4.10.0")
> +    (version "4.12.0")
>      (source (origin
>                (method url-fetch)
>                (uri (string-append "http://archive.xfce.org/xfce/"
> @@ -507,7 +507,7 @@ on the screen.")
>                                    "/src/" name "-" version ".tar.bz2"))
>                (sha256
>                 (base32
> -                "0yrddj1lgk3xn4w340y89z7x2isks72ia36pka08kk2x8gpfcyl9"))))
> +                "1ivzgg4792nid6wcgd1nq5vc3z0y5ip6ymq7ci5j2qkp663qnykf"))))
>      (build-system gnu-build-system)
>      (native-inputs
>       `(("pkg-config" ,pkg-config)
> -- 
> 2.1.2
>
>

LGTM.

-- 
David Thompson
Web Developer - Free Software Foundation - http://fsf.org
GPG Key: 0FF1D807
Support the FSF: https://fsf.org/donate

Re: [PATCH 01/15] gnu: gtk-xfce-engine: Update to 2.10.0.

[Andreas Enge]

On Sun, Mar 01, 2015 at 01:57:12PM +0800, 宋文武 wrote:
> -    (version "3.0.0")
> +    (version "2.10.0")

Something is suspicious here - a downgrade?

Apart from that, I think you can push without problem updates in which only
the source and the hash change.

Andreas

Re: [PATCH 01/15] gnu: gtk-xfce-engine: Update to 2.10.0.

[宋文武]

Andreas Enge <andreas@enge.fr> writes:

> On Sun, Mar 01, 2015 at 01:57:12PM +0800, 宋文武 wrote:
>> -    (version "3.0.0")
>> +    (version "2.10.0")
>
> Something is suspicious here - a downgrade?
Xfce 4.10 did has a 3.0.0 version.

http://xfce.org/download/changelogs/4.12 has:
Theme Engine (gtk-xfce-engine)
  Gtk+-3 support has been stopped
  
I think that's the reason for a 2.x version.
I feel the commit message or a comment should mention it,
but can't get one myself, any suggestion?

>
> Apart from that, I think you can push without problem updates in which only
> the source and the hash change.
>
> Andreas

Re: [PATCH 01/15] gnu: gtk-xfce-engine: Update to 2.10.0.

[Andreas Enge]

On Sun, Mar 01, 2015 at 06:30:22PM +0800, 宋文武 wrote:
> I think that's the reason for a 2.x version.
> I feel the commit message or a comment should mention it,
> but can't get one myself, any suggestion?

How about in the second part:
Update to 2.... Since upstream stopped support of GTK+ 3, they went back to
version numbers starting with 2.

Andreas

Re: [PATCH 01/15] gnu: gtk-xfce-engine: Update to 2.10.0.

[宋文武]

Andreas Enge <andreas@enge.fr> writes:

> Apart from that, I think you can push without problem updates in which only
> the source and the hash change.
OK, I leave gtk-xfce-engine and xfconf for review with other pushed.
>
> Andreas

Re: [PATCH 01/15] gnu: gtk-xfce-engine: Update to 2.10.0.

[Mark H Weaver]

Andreas Enge <andreas@enge.fr> writes:

> On Sun, Mar 01, 2015 at 01:57:12PM +0800, 宋文武 wrote:
>> -    (version "3.0.0")
>> +    (version "2.10.0")
>
> Something is suspicious here - a downgrade?

Yes, it's strange, but compare the versions of gtk-xfce-engine available
at these two URLs:

  http://archive.xfce.org/xfce/4.10/src/
  http://archive.xfce.org/xfce/4.12/src/

Also see:

  https://mail.xfce.org/pipermail/xfce-announce/2015-February/000368.html

"For Xfce 4.12 the gtk-xfce-engine will be gtk2 only."

I think 宋文武 should push this commit.

     Thanks!
       Mark

Re: [PATCH 01/15] gnu: gtk-xfce-engine: Update to 2.10.0.

[Andreas Enge]

On Mon, Mar 02, 2015 at 01:06:30AM -0500, Mark H Weaver wrote:
> I think 宋文武 should push this commit.

Yes. Unfortunately, automatic upgrades will be broken, so people need to
think of doing them manually.

Andreas

Re: [PATCH 01/15] gnu: gtk-xfce-engine: Update to 2.10.0.

[Mark H Weaver]

Andreas Enge <andreas@enge.fr> writes:

> On Mon, Mar 02, 2015 at 01:06:30AM -0500, Mark H Weaver wrote:
>> I think 宋文武 should push this commit.
>
> Yes. Unfortunately, automatic upgrades will be broken, so people need to
> think of doing them manually.

If they installed 'gtk-xfce-engine' directly, that is true.  However, we
have an 'xfce' meta-package now that includes a union of the packages
needed, including 'gtk-xfce-engine'.  For users who installed the 'xfce'
package (and not 'gtk-xfce-engine') directly, the upgrade will work
automatically.

      Mark

Re: [PATCH 01/15] gnu: gtk-xfce-engine: Update to 2.10.0.

[David Thompson]

宋文武 <iyzsong@gmail.com> writes:

> * gnu/packages/xfce.scm (gtk-xfce-engine): Update to 2.10.0.
> ---
>  gnu/packages/xfce.scm | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/gnu/packages/xfce.scm b/gnu/packages/xfce.scm
> index fb5427c..1be28a7 100644
> --- a/gnu/packages/xfce.scm
> +++ b/gnu/packages/xfce.scm
> @@ -1,5 +1,5 @@
>  ;;; GNU Guix --- Functional package management for GNU
> -;;; Copyright © 2014 Sou Bunnbu <iyzsong@gmail.com>
> +;;; Copyright © 2014, 2015 Sou Bunnbu <iyzsong@gmail.com>
>  ;;; Copyright © 2014 Mark H Weaver <mhw@netris.org>
>  ;;;
>  ;;; This file is part of GNU Guix.
> @@ -43,14 +43,14 @@
>  (define-public gtk-xfce-engine
>    (package
>      (name "gtk-xfce-engine")
> -    (version "3.0.0")
> +    (version "2.10.0")
>      (source (origin
>                (method url-fetch)
> -              (uri (string-append "http://archive.xfce.org/xfce/4.10/src/"
> +              (uri (string-append "http://archive.xfce.org/xfce/4.12/src/"
>                                    name "-" version ".tar.bz2"))
>                (sha256
>                 (base32
> -                "13c3ajfqkdr6jlqjyhcp4nls0ddanypr83q9qib2ciffik78zq4h"))))
> +                "0rqrnjxx1lzla7wp2fadyixs6jy0js6xh005pgwyqbigpl0v7hy1"))))
>      (build-system gnu-build-system)
>      (native-inputs
>       `(("pkg-config" ,pkg-config)
> -- 
> 2.1.2
>
>

LGTM.

-- 
David Thompson
Web Developer - Free Software Foundation - http://fsf.org
GPG Key: 0FF1D807
Support the FSF: https://fsf.org/donate