From: Mark H Weaver <mhw@netris.org>
To: "Ludovic Courtès" <ludo@gnu.org>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH] packages: Add zip archive support to 'patch-and-repack'.
Date: Wed, 25 Mar 2015 09:03:02 -0400 [thread overview]
Message-ID: <87h9t9p6ux.fsf@netris.org> (raw)
In-Reply-To: <87iodq15o4.fsf@gnu.org> ("Ludovic \=\?utf-8\?Q\?Court\=C3\=A8s\=22'\?\= \=\?utf-8\?Q\?s\?\= message of "Tue, 24 Mar 2015 21:50:19 +0100")
ludo@gnu.org (Ludovic Courtès) writes:
> Eric Bavier <bavier@member.fsf.org> skribis:
>
>> * guix/packages.scm (%standard-patch-inputs): Add "unzip".
>> (patch-and-repack)[decompression-type]: Detect zip archive.
>> [build]: Invoke "unzip" when appropriate.
>
> Please add “Fixes <http://bugs.gnu.org/19830>.” right above, and email
> 19830-close@debbugs.gnu.org with the commit id afterwards.
>
>> - (zero? (system* (string-append #$tar "/bin/tar")
>> - "xvf" #$source)))
>> + #$@(if (string=? decompression-type "unzip")
>> + #~((zero? (system* "unzip" #$source)))
>> + #~((zero? (system* (string-append #$tar "/bin/tar")
>> + "xvf" #$source)))))
>
> Simply:
>
> #$(if (string=? decompression-type "unzip")
> #~(zero? (system* "unzip" #$source))
> #~(zero? (system* (string-append #$tar "/bin/tar") ...)))
>
> OK to push with these changes!
This is for core-updates, right?
Mark
next prev parent reply other threads:[~2015-03-25 13:02 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-24 15:56 [PATCH] packages: Add zip archive support to 'patch-and-repack' Eric Bavier
2015-03-24 20:50 ` Ludovic Courtès
2015-03-25 13:03 ` Mark H Weaver [this message]
2015-03-25 15:06 ` Eric Bavier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87h9t9p6ux.fsf@netris.org \
--to=mhw@netris.org \
--cc=guix-devel@gnu.org \
--cc=ludo@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).