From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mark H Weaver Subject: Re: [PATCH] xscreenshot and imagefile Date: Thu, 30 Jul 2015 21:51:05 -0400 Message-ID: <87h9oldrhy.fsf@netris.org> References: <87a8uf2c94.fsf@netris.org> <87oaiue4hh.fsf@netris.org> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:33493) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZKzTh-0008QY-J3 for guix-devel@gnu.org; Thu, 30 Jul 2015 21:51:18 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZKzTe-00027h-1J for guix-devel@gnu.org; Thu, 30 Jul 2015 21:51:17 -0400 Received: from world.peace.net ([50.252.239.5]:59758) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZKzTd-00024L-UA for guix-devel@gnu.org; Thu, 30 Jul 2015 21:51:13 -0400 In-Reply-To: <87oaiue4hh.fsf@netris.org> (Mark H. Weaver's message of "Wed, 29 Jul 2015 22:58:18 -0400") List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: Orchidaceae Phalaenopsis Cc: guix-devel@gnu.org Mark H Weaver writes: > Do other people think that such programs belong in Guix? Okay, it seems that the general feeling is that we should accept these programs, so I'll go along with that. I guess I should apologize for making you feel unwelcome. My social skills leave much to be desired. Anyway, the remaining issues to resolve are: * You should add your copyright notice to suckless.scm. * The version numbers should not be 1.0 unless there is either a tarball release or a tag in the git repo that marks this commit as being version 1.0. If there are no tarball releases and no tags, then the version strings should probably be of the form "YYYYMMDD.". Putting the date in front is important so that version numbers can be compared correctly by the "guix package -u" command. * As Alex pointed out, the license on 'xscreenshot' is actually the expat license, not the X11 license, so the license field needs to be fixed. * As Alex pointed out, the description lines should be wrapped to keep the sources within 80 columns. Would you like to send updated patches? Mark