unofficial mirror of guix-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Mark H Weaver <mhw@netris.org>
To: Orchidaceae Phalaenopsis <orchid.hybrid@gmail.com>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH] xscreenshot and imagefile
Date: Thu, 30 Jul 2015 21:51:05 -0400	[thread overview]
Message-ID: <87h9oldrhy.fsf@netris.org> (raw)
In-Reply-To: <87oaiue4hh.fsf@netris.org> (Mark H. Weaver's message of "Wed, 29 Jul 2015 22:58:18 -0400")

Mark H Weaver <mhw@netris.org> writes:
> Do other people think that such programs belong in Guix?

Okay, it seems that the general feeling is that we should accept these
programs, so I'll go along with that.  I guess I should apologize for
making you feel unwelcome.  My social skills leave much to be desired.

Anyway, the remaining issues to resolve are:

* You should add your copyright notice to suckless.scm.

* The version numbers should not be 1.0 unless there is either a tarball
  release or a tag in the git repo that marks this commit as being
  version 1.0.  If there are no tarball releases and no tags, then the
  version strings should probably be of the form "YYYYMMDD.<commit>".
  Putting the date in front is important so that version numbers can be
  compared correctly by the "guix package -u" command.

* As Alex pointed out, the license on 'xscreenshot' is actually the
  expat license, not the X11 license, so the license field needs to be
  fixed.

* As Alex pointed out, the description lines should be wrapped to keep
  the sources within 80 columns.

Would you like to send updated patches?

     Mark

  parent reply	other threads:[~2015-07-31  1:51 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-27 17:50 [PATCH] xscreenshot and imagefile Orchidaceae Phalaenopsis
2015-07-28 23:33 ` Guix-Bot
2015-08-18 15:22   ` Guix review bot Ludovic Courtès
2015-08-18 23:26     ` Cyril Roelandt
2015-08-25 21:31       ` Ludovic Courtès
2015-07-28 23:34 ` [PATCH] xscreenshot and imagefile Guix-Bot
2015-07-28 23:41 ` Guix-Bot
2015-07-28 23:42 ` Guix-Bot
2015-07-29 15:51 ` Mark H Weaver
2015-07-29 18:24   ` Alex Kost
2015-07-30  2:58   ` Mark H Weaver
2015-07-30  7:04     ` Pjotr Prins
2015-07-30 22:41       ` Cyril Roelandt
2015-07-31 17:59       ` Andreas Enge
2015-08-01  8:09         ` Pjotr Prins
2015-07-30  9:10     ` Mathieu Lirzin
2015-07-30 19:31     ` Packaging vs. Maintaining (was: [PATCH] xscreenshot and imagefile) Jeff Mickey
2015-07-31  1:51     ` Mark H Weaver [this message]
2015-08-18 15:13       ` [PATCH] xscreenshot and imagefile Ludovic Courtès
2015-07-29 17:48 ` Alex Kost

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87h9oldrhy.fsf@netris.org \
    --to=mhw@netris.org \
    --cc=guix-devel@gnu.org \
    --cc=orchid.hybrid@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).