From mboxrd@z Thu Jan  1 00:00:00 1970
From: Paul van der Walt <paul@denknerd.org>
Subject: Re: [PATCH 03/43] gnu: xmonad: Patch to work on new Haskell Platform
Date: Tue, 20 Oct 2015 15:52:27 +0200
Message-ID: <87h9ll4pgk.fsf@denknerd.org>
References: <1444911697-15515-1-git-send-email-paul@denknerd.org>
	<1444911697-15515-3-git-send-email-paul@denknerd.org>
	<20151019083608.2115296f@openmailbox.org>
Content-Type: text/plain
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:60852)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paul@denknerd.org>) id 1ZoXLM-000860-Ox
	for guix-devel@gnu.org; Tue, 20 Oct 2015 09:52:52 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <paul@denknerd.org>) id 1ZoXL5-0007cN-J0
	for guix-devel@gnu.org; Tue, 20 Oct 2015 09:52:35 -0400
Received: from mx01.mykolab.com ([95.128.36.1]:38204 helo=mx-out03.mykolab.com)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paul@denknerd.org>) id 1ZoXL5-0007bx-Ap
	for guix-devel@gnu.org; Tue, 20 Oct 2015 09:52:31 -0400
In-reply-to: <20151019083608.2115296f@openmailbox.org>
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: Eric Bavier <ericbavier@openmailbox.org>
Cc: guix-devel@gnu.org


On 2015-10-19 at 15:36, quoth Eric Bavier:
>> +       ("xmonad-cabal-patch"
>> +        ,(origin
>> +           (method url-fetch)
>> +           (uri (string-append
>> +                 "https://hackage.haskell.org/package/xmonad-" version "/revision/1.cabal"))
>> +           (sha256
>> +            (base32
>> +             "0gdzsn2mv45i67wzmcjxyljr2w9fccc19n0i0f69mwvwcgi9v10j"))))))
>
> Could this instead be formulated as a patch, rather than a complete
> file overwrite?  A diff would help in understanding the rationale for
> the change.

It could, but since hackage provides this new Cabal file, it seemed
"cleanest" to not re-implement it as a patch.  If you prefer, i could do
one of two things:

* Add a comment explaining that the patch simply changed the library
  component's dependency on utf8-string from

     >=0.3 && <0.4

  to

     >=0.3 && <1.1

or,

* Add that as a "(substitute ...)" type patch.

My thinking was that the fact that this new Cabal file comes from
Hackage lends it a certain "credibility", whereas otherwise it might
look like i'm arbitrarily modifying the Cabal file to make it compile.
I admit that this was also the easier approach, it seemed to me.

I'll make it into whatever you prefer, but before messing around i
thought i'd ask.

Cheers, and thanks for all the comments,
p.