unofficial mirror of guix-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: ludo@gnu.org (Ludovic Courtès)
To: Leo Famulari <leo@famulari.name>
Cc: guix-devel@gnu.org
Subject: Re: Lint on line
Date: Mon, 23 Nov 2015 10:46:47 +0100	[thread overview]
Message-ID: <87h9kdvyig.fsf@gnu.org> (raw)
In-Reply-To: <1448238160.3837620.446978289.1EAE4186@webmail.messagingengine.com> (Leo Famulari's message of "Sun, 22 Nov 2015 19:22:40 -0500")

[-- Attachment #1: Type: text/plain, Size: 239 bytes --]

Leo Famulari <leo@famulari.name> skribis:

> What is the recommended way to handle the following warning?
>
> "gnu/packages/firmware.scm:33:12: ath9k-htc-firmware-1.4.0: the source
> file name should contain the package name"

Like this:


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: Type: text/x-patch, Size: 509 bytes --]

diff --git a/gnu/packages/firmware.scm b/gnu/packages/firmware.scm
index 97f2975..271fb49 100644
--- a/gnu/packages/firmware.scm
+++ b/gnu/packages/firmware.scm
@@ -38,6 +38,7 @@
               (sha256
                (base32
                 "16jbj8avg5jkgvq5lxm0hdxxn4c3zn7fx8b4nxllvr024apk9w23"))
+              (file-name (string-append name "-" version "-checkout"))
               (patches (list (search-patch "ath9k-htc-firmware-objcopy.patch")))))
     (build-system gnu-build-system)
     (arguments

[-- Attachment #3: Type: text/plain, Size: 218 bytes --]


I’ll push this one.  ;-)

The goal of this rule is to make sure that checkouts are given
meaningful names.  This does not make any functional difference, but it
helps keep the store tidy.

Thanks,
Ludo’.

  parent reply	other threads:[~2015-11-23  9:46 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-22 23:11 Lint on line Ludovic Courtès
2015-11-23  0:22 ` Leo Famulari
2015-11-23  8:31   ` Alex Kost
2015-11-23  9:46   ` Ludovic Courtès [this message]
2015-11-23  9:28 ` Mathieu Lirzin
2015-11-30 18:27 ` Andreas Enge
2015-12-01 22:04   ` Ludovic Courtès
2015-12-02  7:36     ` Jan Synáček
2015-12-02  8:52       ` Andreas Enge
2015-12-03 10:42         ` Ludovic Courtès

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87h9kdvyig.fsf@gnu.org \
    --to=ludo@gnu.org \
    --cc=guix-devel@gnu.org \
    --cc=leo@famulari.name \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).