From mboxrd@z Thu Jan 1 00:00:00 1970 From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=) Subject: Re: [PATCHES] Add Kodi Date: Wed, 25 Nov 2015 14:38:42 +0100 Message-ID: <87h9kagpwd.fsf@gnu.org> References: <878u5m531a.fsf@izanagi.i-did-not-set--mail-host-address--so-tickle-me> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:36604) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a1aHb-0006J3-19 for guix-devel@gnu.org; Wed, 25 Nov 2015 08:38:52 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a1aHW-0003UT-CU for guix-devel@gnu.org; Wed, 25 Nov 2015 08:38:50 -0500 In-Reply-To: <878u5m531a.fsf@izanagi.i-did-not-set--mail-host-address--so-tickle-me> (David Thompson's message of "Tue, 24 Nov 2015 19:35:45 -0500") List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: David Thompson Cc: guix-devel@gnu.org David Thompson skribis: > This one was a real hairball, but here is a patch set that adds the Kodi > media center! I hope that I've explained all the craziness relatively > well in the comments. Wow, quite an achievement! > From d708d0c36e202bbad7255c3b8a55ca0afdd18cb3 Mon Sep 17 00:00:00 2001 > From: David Thompson > Date: Tue, 24 Nov 2015 13:35:44 -0500 > Subject: [PATCH 1/3] gnu: Add tinyxml. > > * gnu/packages/xml.scm (tinyxml): New variable. > * gnu/packages/patches/tinyxml-use-stl.patch: New file. > * gnu-system.am (dist_patch_DATA): Add it. [...] > +From a53b6ee4519a7657164610ac14a82c57b1273bf6 Mon Sep 17 00:00:00 2001 > +From: David Thompson > +Date: Mon, 23 Nov 2015 06:54:36 -0500 > +Subject: [PATCH] Use STL. Maybe just say why this is needed. > + ;; Generate and install pkg-config file. > + (mkdir-p pkgconfig) > + (call-with-output-file (string-append pkgconfig "/tinyxml= .pc") It=E2=80=99s OK to do that, but only if there are users that expect it (usu= ally because a major distro has been doing it for some time.) Maybe just add a something like =E2=80=9Cbecause Kodi expects it=E2=80=9D, or =E2=80=9Csim= ilar to what Debian does=E2=80=9D. Otherwise LGTM. > From 11b1b337dbd3b245c314b1d22eaeb1331a34e729 Mon Sep 17 00:00:00 2001 > From: David Thompson > Date: Tue, 24 Nov 2015 13:37:34 -0500 > Subject: [PATCH 2/3] gnu: Add jasper. > > * gnu/packages/image.scm (jasper): New variable. LGTM. > From feb1a97e9d3c0e28ee265861bb34c90aa3e06265 Mon Sep 17 00:00:00 2001 > From: David Thompson > Date: Mon, 16 Nov 2015 22:31:26 -0500 > Subject: [PATCH 3/3] gnu: Add kodi. + commit log and copyright header. > + '(#:configure-flags '("--with-ffmpeg=3Dshared") ; don't use bundled= ffmpeg Would it be possible to delete the bundled ffmpeg in a snippet? > + (let ((cwd (getcwd))) > + (dynamic-wind > + (const #t) > + (lambda () > + (chdir "tools/depends/native/JsonSchemaBuilder/src") > + (zero? (system* "sh" "autogen.sh"))) > + (lambda () > + (chdir cwd)))))) Use =E2=80=98with-directory-excursion=E2=80=99 instead. > + (native-inputs > + `(("autoconf" ,autoconf) > + ("automake" ,automake) > + ("cmake" ,cmake) > + ("doxygen" ,doxygen) > + ("gawk" ,gawk) > + ("gettext" ,gnu-gettext) We could remove autoconf/automake/libtool/gettext if they used =E2=80=98make dist=E2=80=99, but I guess they don=E2=80=99t. Bah. We should start a =E2=80=9Cmake dist=E2=80=9D campaign; makedist.org appear= s to be available=E2=80=A6 ;-) > + ("icedtea7" ,icedtea7) Is it a build-only dependency (it=E2=80=99s in =E2=80=98native-inputs=E2=80= =99)? Can it be avoided? Otherwise LGTM. Thank you! Ludo=E2=80=99.