From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: Re: [PATCH] gnu: Add libcanberra-gtk2.
Date: Sun, 07 Feb 2016 21:15:10 +0100
Message-ID: <87h9hktgz5.fsf@gnu.org>
References: <87lh6yctt8.fsf@member.fsf.org>
	<1454784524-9964-1-git-send-email-fhmgufs@web.de>
	<20160206215657.3f9fa800@debian-netbook>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:44279)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1aSVjp-0000SU-T2
	for guix-devel@gnu.org; Sun, 07 Feb 2016 15:15:18 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1aSVjl-0002hL-T4
	for guix-devel@gnu.org; Sun, 07 Feb 2016 15:15:17 -0500
In-Reply-To: <20160206215657.3f9fa800@debian-netbook> (Efraim Flashner's
	message of "Sat, 6 Feb 2016 21:56:57 +0200")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: Efraim Flashner <efraim@flashner.co.il>
Cc: guix-devel@gnu.org

Efraim Flashner <efraim@flashner.co.il> skribis:

> On Sat,  6 Feb 2016 19:48:44 +0100
> Fabian Harfert <fhmgufs@web.de> wrote:
>
>> * gnu/packages/libcanberra.scm (libcanberra/gtk+-2): New variable.

[...]

>> +(define-public libcanberra/gtk+-2
>> +  (package (inherit libcanberra)
>> +    (name "libcanberra-gtk2")
>> +    (inputs
>> +     `(("alsa-lib" ,alsa-lib)
>> +       ("gstreamer" ,gstreamer)
>> +       ("gtk+" ,gtk+-2)
>> +       ("libltdl" ,libltdl)
>> +       ("libvorbis" ,libvorbis)
>> +       ("pulseaudio" ,pulseaudio)
>> +       ("udev" ,eudev)
>> +       ("sound-theme-freedesktop" ,sound-theme-freedesktop)))))
>> +
>>  (define-public sound-theme-freedesktop
>>    (package
>>      (name "sound-theme-freedesktop")
>
> gtk is the only different input between the two variants, how about just
> removing gtk from the list of inherited inputs and adding in gtk+-2?

Agreed.  Fabian: could you send an updated patch?  If you prefer one of
us could adjust your patch to do that.

Thanks,
Ludo=E2=80=99.