From: ludo@gnu.org (Ludovic Courtès)
To: Jan Nieuwenhuizen <janneke@gnu.org>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH] gnu-build-system: do not patch symlinks. Fixes location-aware scripts.
Date: Wed, 10 Feb 2016 22:30:46 +0100 [thread overview]
Message-ID: <87h9hgi77d.fsf@gnu.org> (raw)
In-Reply-To: <87a8n9edir.fsf@gnu.org> (Jan Nieuwenhuizen's message of "Tue, 09 Feb 2016 23:15:40 +0100")
Jan Nieuwenhuizen <janneke@gnu.org> skribis:
> Ludovic Courtès writes:
>
>> How does the script determines its location? Using $0 is unreliable,
>> and using /proc/self/exe is non portable.
>
> It uses node.js's __dirname. I would have to dive into node.js
> internals to figure that out... I would think it does /proc/self/exe
> and has fallbacks for other platforms?
That's plausible.
> From 2d17c6bd7c7dd466c0aee14beaa47055af0ceb6d Mon Sep 17 00:00:00 2001
> From: Jan Nieuwenhuizen <janneke@gnu.org>
> Date: Sun, 7 Feb 2016 16:45:25 +0100
> Subject: [PATCH] build-system/gnu: Do not patch symlinks, v2.
>
> This fixes location-aware scripts.
>
> * guix/build/gnu-build-system.scm (file-is-symlink?): new function.
> (patch-source-shebangs): use it to skip symlinks.
This one changes ‘patch-source-shebangs’, which is about patching files
in the source tree.
It makes sense to avoid patching symlinks there too, but are you sure
this has anything to do with the problem you noticed?
Thanks,
Ludo’.
prev parent reply other threads:[~2016-02-10 21:31 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-06 17:26 [PATCH] gnu-build-system: do not patch symlinks. Fixes location-aware scripts Jan Nieuwenhuizen
2016-02-09 10:41 ` Ludovic Courtès
2016-02-09 19:19 ` Jan Nieuwenhuizen
2016-02-09 20:59 ` Ludovic Courtès
2016-02-09 22:15 ` Jan Nieuwenhuizen
2016-02-10 21:30 ` Ludovic Courtès [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87h9hgi77d.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=guix-devel@gnu.org \
--cc=janneke@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).