From mboxrd@z Thu Jan 1 00:00:00 1970 From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=) Subject: Re: [PATCH] Add GNOME and XFCE desktop services. Date: Thu, 25 Feb 2016 19:46:06 +0100 Message-ID: <87h9gw39xt.fsf@gnu.org> References: <8737sh92n9.fsf@pobox.com> <87lh69qzpt.fsf@member.fsf.org> <87bn75kz10.fsf@igalia.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:50529) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aZ0vW-0004o9-Vy for guix-devel@gnu.org; Thu, 25 Feb 2016 13:46:15 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aZ0vR-0003z6-Uj for guix-devel@gnu.org; Thu, 25 Feb 2016 13:46:14 -0500 In-Reply-To: <87bn75kz10.fsf@igalia.com> (Andy Wingo's message of "Thu, 25 Feb 2016 08:52:11 +0100") List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: Andy Wingo Cc: guix-devel@gnu.org Andy Wingo skribis: > Greets :) > > On Thu 25 Feb 2016 03:40, iyzsong@member.fsf.org (=E5=AE=8B=E6=96=87=E6= =AD=A6) writes: > >>> @@ -717,6 +766,10 @@ when they log out." >>> ;; List of services typically useful for a "desktop" use case. >>> (cons* (slim-service) >>>=20=20 >>> + ;; Polkit permissions for desktops to control brightness, etc. >>> + (gnome-desktop-service) >>> + (xfce-desktop-service) >>> + >>> ;; Screen lockers are a pretty useful thing and these are sma= ll. >>> (screen-locker-service slock) >>> (screen-locker-service xlockmore "xlock") >> It=E2=80=99s confusing, these really are =E2=80=98gnome-settings-daemon-= service=E2=80=99 and >> =E2=80=98thunar-service=E2=80=99 to enable the polkit rules. We would e= xpect a >> =E2=80=98gnome-desktop-service=E2=80=99 to bring a full GNOME environmen= t, which can >> be done by extend =E2=80=98profile-service-type=E2=80=99 with the =E2=80= =98gnome=E2=80=99 meta-package. >> But then the configuable =E2=80=98gnome-settings-daemon=E2=80=99 package= is duplicate, >> roughly speaking we could extracted it from the =E2=80=98propagated-inpu= ts=E2=80=99 of >> the =E2=80=98gnome=E2=80=99 package, which isn=E2=80=99t a straight way= =E2=80=A6 > > I can see how that can be confusing, thanks for the feedback. It=E2=80=99s OK if =E2=80=98gnome-settings-daemon=E2=80=99 appears twice in= the global profile. Or we can modify the =E2=80=98gnome=E2=80=99 meta-package to not depend on = it? But yeah, I agree that full-blown =E2=80=98gnome-desktop-service=E2=80=99 a= nd =E2=80=98xfce-desktop-service=E2=80=99, which also extend =E2=80=98profile-= service-type=E2=80=99, would be nicer. However, =E2=80=98%desktop-services=E2=80=99 should probably include none o= f them by default. > I think Mark has expressed a preference that packages should not add to > services by default: the reason being that you (as a user, as a Guix > developer, patch reviewer, etc) don't really have to trust a package, > whereas services grant special privileges and thus need more scrutiny. > With this in mind, I don't see how to extract GNOME services from a > (meta-)package. > > What do you think is the right solution in the short term? Rename these > services to reflect their package name? Currently SLiM takes .desktop files that it finds at run time, which it not so great for the reasons you give above. The solution will probably be to to have the hypothetical =E2=80=98gnome-desktop=E2=80=99 and =E2=80=98xfce-desktop=E2=80=99 service = extend it via the service extension mechanism. Anyway, thanks for the thorough investigation, sounds like we=E2=80=99re on= the right track! :-) Ludo=E2=80=99.