From mboxrd@z Thu Jan  1 00:00:00 1970
From: Mark H Weaver <mhw@netris.org>
Subject: Re: loudmouth, freetalk
Date: Wed, 30 Mar 2016 12:10:29 -0400
Message-ID: <87h9fo2bgq.fsf@netris.org>
References: <20160329172324.GA4939@protected.rcdrun.com>
	<87mvphaxtq.fsf@grrlz.net>
Mime-Version: 1.0
Content-Type: text/plain
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:53452)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mhw@netris.org>) id 1alIhg-0004Os-AE
	for guix-devel@gnu.org; Wed, 30 Mar 2016 12:10:45 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mhw@netris.org>) id 1alIhc-0003DT-6w
	for guix-devel@gnu.org; Wed, 30 Mar 2016 12:10:44 -0400
Received: from world.peace.net ([50.252.239.5]:40829)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mhw@netris.org>) id 1alIhb-0003DD-RZ
	for guix-devel@gnu.org; Wed, 30 Mar 2016 12:10:39 -0400
In-Reply-To: <87mvphaxtq.fsf@grrlz.net> (Nils Gillmann's message of "Tue, 29
	Mar 2016 21:28:01 +0200")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: Jean Louis <guix@rcdrun.com>
Cc: guix-devel@gnu.org, Nils Gillmann <niasterisk@grrlz.net>

Nils Gillmann <niasterisk@grrlz.net> writes:

> Jean Louis <guix@rcdrun.com> writes:
>
>> (define-public loudmouth
>>   (package
>>     (name "loudmouth")
>>     (version "1.4.3")
>>     (source (origin
>>              (method url-fetch)
>>              (uri (string-append
>>                     "http://ftp.gnome.org/pub/GNOME/sources/loudmouth/1.4"
>>                     "/loudmouth-" version ".tar.bz2"))
>
>                (uri (string-append
>                       "http://ftp.gnome.org/pub/GNOME/sources/" name
>                       "/1.4/" name "-" version ".tar.bz2"))

The "1.4" should also be replaced with (version-major+minor version), so
that this part of the string doesn't have to be manually fixed when the
version changes to 1.5.x or higher.  Using the 'name' variable is less
important, since that's unlikely to change.

>                In addition: there might be an mirror:// thing for
>                gnome ftp

Yes.  So it should be like this:

              (uri (string-append "mirror://gnome/sources/" name "/"
                                  (version-major+minor version) "/"
                                  name "-" version ".tar.bz2"))

      Thanks!
        Mark