From: Andy Wingo <wingo@igalia.com>
To: 宋文武 <iyzsong@gmail.com>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH] gnu-maintenance: update-package-source: Only update the desired package.
Date: Tue, 05 Apr 2016 10:25:59 +0200 [thread overview]
Message-ID: <87h9fgfomg.fsf@igalia.com> (raw)
In-Reply-To: <1459830946-2583-1-git-send-email-iyzsong@gmail.com> ("宋文武"'s message of "Tue, 5 Apr 2016 12:35:46 +0800")
Hi 宋文武 :)
On Tue 05 Apr 2016 06:35, 宋文武 <iyzsong@gmail.com> writes:
> diff --git a/guix/upstream.scm b/guix/upstream.scm
> index cea23fe..f4bc09c 100644
> --- a/guix/upstream.scm
> +++ b/guix/upstream.scm
> @@ -205,6 +209,37 @@ and 'interactive' (default)."
> "Modify the source file that defines PACKAGE to refer to VERSION,
> whose tarball has SHA256 HASH (a bytevector). Return the new version string
> if an update was made, and #f otherwise."
> + (define (substitute+ file start end pattern+procs)
Sorry to tell you mixed signals, but did you consider Ludovic's
suggestion to use `package-field-location' ?
If it turns out that this more textual approach is best, consider
factoring the helper out to a top-level function. Someone else is going
to want to use it later :)
Andy
next prev parent reply other threads:[~2016-04-05 8:26 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-05 4:35 [PATCH] gnu-maintenance: update-package-source: Only update the desired package 宋文武
2016-04-05 8:25 ` Andy Wingo [this message]
2016-04-05 9:47 ` Ludovic Courtès
2016-04-05 10:16 ` Andy Wingo
2016-04-05 14:05 ` 宋文武
2016-04-05 14:52 ` Andy Wingo
2016-04-05 20:20 ` Ludovic Courtès
2016-04-05 9:45 ` Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87h9fgfomg.fsf@igalia.com \
--to=wingo@igalia.com \
--cc=guix-devel@gnu.org \
--cc=iyzsong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).