Re: [PATCH] gnu: Add nlopt.

[ludo@gnu.org (Ludovic Courtès)]

Roel Janssen <roel@gnu.org> skribis:

> Ludovic Courtès writes:

[...]

>> Still, according to luksan/COPYRIGHT, “[s]ubroutines PBUN, PNEW, PVAR,
>> PSEN” are “for your personal use […] [n]ot for redistribution”.
>>
>> So my understanding is that we need to remove those four subroutines.
>> The rest in that directory is LGPLv2.1+.
>>
>> WDYT?
>
> I agree to your understanding.
>
> A little later in the same file I found: "This library (with exception
> of PBUN, PNEW, PVAR, PSEN) is a free software".
>
>> I don’t see it at
>> <https://libreplanet.org/wiki/List_of_software_that_does_not_respect_the_Free_System_Distribution_Guidelines>.
>> Debian has a package: <https://packages.debian.org/source/sid/nlopt>.
>> Could you check if they apply any patches?
>
> I haven't found any patches.  So I dug a little deeper and attempted to
> remove them myself with a patch, but I haven't been able to find these
> subroutines.
>
> I ran the following commands on the root of the source directory:
> grep -i -r "pbun" .
> grep -i -r "pmin" .
> grep -i -r "psen" .
> grep -i -r "pvar" .
>
> And I haven't found the routines.  So I think we're safe.  That could
> also be why Debian doesn't have a patch for this either.

Indeed.  Actually, luksan/README states:

  [We also did not convert the PMIN, PBUN, PNEW, or PVAR subroutines
  since these were published in ACM Trans. on Math. Software (TOMS) and
  are subject to the non-free ACM licensing conditions.]

So indeed, the COPYRIGHT file is confusing, but we’re safe.

Sorry for the false alarm.

>> Besides, I suggest reusing the bits about Guile bindings from the patch
>> I sent.
>
> Shall I prepare a new patch?

Yes please.

Thank you!

Ludo’.