From: ludo@gnu.org (Ludovic Courtès)
To: Kei Yamashita <kei@openmailbox.org>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH] gnu: Correct libical zoneinfo search path.
Date: Tue, 10 May 2016 15:36:19 +0200 [thread overview]
Message-ID: <87h9e6ghm4.fsf@gnu.org> (raw)
In-Reply-To: <20160510000811.42fc6522@openmailbox.org> (Kei Yamashita's message of "Tue, 10 May 2016 00:08:11 -0400")
Hi,
Good catch!
Kei Yamashita <kei@openmailbox.org> skribis:
> + (modify-phases %standard-phases
> + (add-before 'configure 'patch-paths
> + (lambda _
> + (let ((tzdata (assoc-ref %build-inputs "tzdata")))
> + (substitute* "src/libical/icaltz-util.c"
> + (((string-append "\"/usr/share/zoneinfo\","
> + "\"/usr/lib/zoneinfo\","
> + "\"/etc/zoneinfo\","
> + "\"/usr/share/lib/zoneinfo\""))
> + (string-append "\"" tzdata "/share/zoneinfo\""))))
Could you use a literal string for the pattern? Maybe something like
“char \*foo =.*$” would be clearer?
Otherwise LGTM, thanks!
Ludo’.
next prev parent reply other threads:[~2016-05-10 13:36 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-10 4:06 [PATCH] gnu: Correct libical zoneinfo search path Kei Yamashita
2016-05-10 4:08 ` Kei Yamashita
2016-05-10 13:36 ` Ludovic Courtès [this message]
2016-05-10 20:58 ` Kei Yamashita
2016-05-11 13:48 ` Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87h9e6ghm4.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=guix-devel@gnu.org \
--cc=kei@openmailbox.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).