Re: [PATCH] gnu: Add higan.

[ludo@gnu.org (Ludovic Courtès)]

taylanbayirli@gmail.com (Taylan Ulrich "Bayırlı/Kammer") skribis:

> I contacted the maintainer of the repo and asked them to add a tag,
> which is done now.

Great!

> Note: apparently the author re-released 098 with a hotfix very soon
> after releasing it, without making a version change.  In the repository,
> this is tagged as 098b, which I use here.  I.e. this is not a true
> version update; we were already using "this 098".

Not great.  ;-)

>>> Apparently, the files that are part of the distribution are pure data
>>> files, i.e. fine to be read-only.  However, the directory hierarchy of
>>> which they're a part needs to be writable, as higan creates further
>>> files there.  With that cp -r, the directory hierarchy is made sure to
>>> be there, and the data files made sure to be up to date.
>>>
>>> Although I didn't look too closely at the sources, patching higan to do
>>> things differently would presumably be a nontrivial task, since it seems
>>> bent on doing things in terms of this directory structure that contains
>>> both pure data and read-write data files.
>>
>> Hmm OK.  What do other distros do?
>
> More or less the same thing; it's sanctioned by the developers even
> though it's acknowledged not to be a particularly good solution.  Here
> we see Arch do the same:
>
> https://git.archlinux.org/svntogit/community.git/tree/trunk/higan?h=packages/higan
>
> (Though this one seems to have a bug because they copy things to
> ~/Emulation instead of the new ~/.local/share.  I'm confident that
> ~/.local/share is the right location in the latest release.  Also for
> the cheats.bml file.)

Hmmk.

> Here's a patch that, in addition to switching the repo, adds a patch
> removing a -march=native flag (which I assume would break
> cross-compilation),

‘-march=native’ breaks distribution of pre-built binaries since the
binary produced in the build farm may or may not run on the user’s
hardware, depending on the exact CPU being used.  So this patch is the
right thing to do!

> and passes the make flag "profile=balanced" to make higan less CPU
> intensive by emulating a bit less accurately (it was running too slow
> on my i5, so this should be a better default).

OK.

> I just saved a princess from an evil wizard with this so I can confirm
> it runs smooth now.

Wonderful.  :-)

> From 93ccdf075caf462af742cf46cad35697001db124 Mon Sep 17 00:00:00 2001
> From: =?UTF-8?q?Taylan=20Ulrich=20Bay=C4=B1rl=C4=B1/Kammer?=
>  <taylanbayirli@gmail.com>
> Date: Thu, 9 Jun 2016 21:53:02 +0300
> Subject: [PATCH] gnu: higan: Various improvements.
>
> * gnu/packages/games.scm (higan): Use semi-official repository at GitLab
> (using hotfix tag 098b which is equivalent to official release 098).
> Add a patch to remove the build flag -march=native.  Set profile to
> balanced.
> * gnu/packages/patches/higan-remove-march-native-flag.patch: New file.
> * gnu/local.mk (dist_patch_DATA): Add it.

OK!

Thanks,
Ludo’.