From mboxrd@z Thu Jan 1 00:00:00 1970 From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=) Subject: Re: [PATCH v5] gnu: Add teensy-loader-cli. Date: Wed, 15 Jun 2016 15:31:11 +0200 Message-ID: <87h9cuefz4.fsf@gnu.org> References: <1465938855-15618-1-git-send-email-h.goebel@crazy-compilers.com> <1465938855-15618-2-git-send-email-h.goebel@crazy-compilers.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org> Received: from eggs.gnu.org ([2001:4830:134:3::10]:57477) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from <ludo@gnu.org>) id 1bDAue-0004HE-Sf for guix-devel@gnu.org; Wed, 15 Jun 2016 09:31:23 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from <ludo@gnu.org>) id 1bDAuY-0005bT-Q2 for guix-devel@gnu.org; Wed, 15 Jun 2016 09:31:19 -0400 In-Reply-To: <1465938855-15618-2-git-send-email-h.goebel@crazy-compilers.com> (Hartmut Goebel's message of "Tue, 14 Jun 2016 23:14:13 +0200") List-Id: "Development of GNU Guix and the GNU System distribution." <guix-devel.gnu.org> List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>, <mailto:guix-devel-request@gnu.org?subject=unsubscribe> List-Archive: <http://lists.gnu.org/archive/html/guix-devel/> List-Post: <mailto:guix-devel@gnu.org> List-Help: <mailto:guix-devel-request@gnu.org?subject=help> List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>, <mailto:guix-devel-request@gnu.org?subject=subscribe> Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org> To: Hartmut Goebel <h.goebel@crazy-compilers.com> Cc: guix-devel@gnu.org Hello, Hartmut Goebel <h.goebel@crazy-compilers.com> skribis: > * gnu/packages/flashing-tools.scm (teensy-loader-cli): New variable. > * gnu/packages/patches/teensy-loader-cli-Add-support-for-h-help.patch, > gnu/packages/patches/teensy-loader-cli-Change-program-name-in-usage.pat= ch > New files. I=E2=80=99ve finally applied it and took the liberty to make a few changes = (I didn=E2=80=99t want to bother you another time!). > + (patches (search-patches > + "teensy-loader-cli-Add-support-for-h-help.patch" > + "teensy-loader-cli-Change-program-name-in-usage.patch")= ))) I removed the second patch and corresponding renaming (I hadn=E2=80=99t not= iced it before), on the grounds that it=E2=80=99s not our job to rename things; = in general, we should stick to what upstream has chosen. I=E2=80=99ve also added the remaining patch to gnu/local.mk. > +++ b/gnu/packages/patches/teensy-loader-cli-Add-support-for-h-help.patch > @@ -0,0 +1,34 @@ > +Add support for `-h` (help). > +This option was already in the usage message, but not implemented. > + > +Upstream pull-request pending. I added the URL of the pull request instead. Note that, normally, we would not incorporate such patches, because it=E2= =80=99s really upstream=E2=80=99s business, not ours. Thank you! Ludo=E2=80=99.