From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marius Bakke Subject: Re: [PATCH] gnu: Add dlib. Date: Wed, 17 Aug 2016 15:48:24 +0100 Message-ID: <87h9ajzc1z.fsf@ike.i-did-not-set--mail-host-address--so-tickle-me> References: <87twengmbh.fsf@ike.i-did-not-set--mail-host-address--so-tickle-me> <87a8gexyrz.fsf@gmail.com> <87oa4ugsi4.fsf@ike.i-did-not-set--mail-host-address--so-tickle-me> <20160815201528.GA23963@jasmine> <87a8gd22ug.fsf@ike.i-did-not-set--mail-host-address--so-tickle-me> <20160815222840.GA10735@jasmine> <4752bc68-5466-6c26-a7b4-e53aec400ff5@uq.edu.au> <8760r10z7n.fsf@ike.i-did-not-set--mail-host-address--so-tickle-me> <20160816204736.GA25753@jasmine> <993034f9-ceae-525f-01b9-0b8af7a5aafe@uq.edu.au> <20160816234507.GA24224@jasmine> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:40863) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ba293-00016i-P4 for guix-devel@gnu.org; Wed, 17 Aug 2016 10:48:43 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ba290-0001v1-Ep for guix-devel@gnu.org; Wed, 17 Aug 2016 10:48:41 -0400 Received: from out2-smtp.messagingengine.com ([66.111.4.26]:53711) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ba28x-0001pN-VZ for guix-devel@gnu.org; Wed, 17 Aug 2016 10:48:38 -0400 In-Reply-To: List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Ben Woodcroft , Leo Famulari Cc: guix-devel , Alex Kost --=-=-= Content-Type: text/plain Ben Woodcroft writes: > On 17/08/16 09:45, Leo Famulari wrote: >> On Wed, Aug 17, 2016 at 09:31:11AM +1000, Ben Woodcroft wrote: >>> >>> On 17/08/16 06:47, Leo Famulari wrote: >>>> On Tue, Aug 16, 2016 at 11:45:16AM +0100, Marius Bakke wrote: >>>>> I initially made this package on a foreign distro without "lapack" in >>>>> inputs and have verified that dropping LAPACK makes the tests pass. >>>>> >>>>> I also found some other optional dependencies after digging around the >>>>> source, as well as a recommendation to disable/enable asserts: >>>>> >>>>> http://dlib.net/dlib/config.h.html >>>>> >>>>> Ben, Leo: Can you try the following patch and see if that works for you? >>>> Yes, this patch builds for me. >>> Me too, although it appeared non-deterministic. I'm afraid I haven't time to >>> see if this patch is suitable to push just now. Leo? >> How did it appear non-deterministic to you? > Just based on guix build --check: > > guix build: error: build failed: derivation > `/gnu/store/sxybcxw64q1ajzq6dysal75ffgq6238i-dlib-19.1.drv' may not be > deterministic: output > `/gnu/store/il57dcii4pzii11zlixjjxxxw699bg5x-dlib-19.1' differs > > I'm actually not sure, why does it say "may not be deterministic"? If it > builds twice and the second version is different, doesn't that mean it > is definitely not deterministic by counter-example, unless there has > been some leakage into the build container? > > I also tried building it with #parallel-build? #f and #parallel-tests? > #f. It worked in the first round but failed the second. > > Note also that the 'disable-asserts' phase should end with '#t'. I've attached a patch with a #t in the disable-asserts phase, and also deleting the 6MB static library. Since `guix build --rounds=2` passes, is there any reason to delay this patch? I've built this on GuixSD and a foreign distro and naively verified that they are the same (the .so and all headers have the same checksum; some of the recorded cmake input paths are different though). Thanks, Marius --=-=-= Content-Type: text/x-patch; charset=utf-8 Content-Disposition: inline; filename=0001-gnu-Add-dlib.patch Content-Transfer-Encoding: quoted-printable >From 77f74972d095aeb08367e00c9d683137bd7a35f3 Mon Sep 17 00:00:00 2001 From: Marius Bakke Date: Sat, 13 Aug 2016 11:26:10 +0100 Subject: [PATCH] gnu: Add dlib. * gnu/packages/machine-learning.scm (dlib): New variable. --- gnu/packages/machine-learning.scm | 67 +++++++++++++++++++++++++++++++++++= +++- 1 file changed, 66 insertions(+), 1 deletion(-) diff --git a/gnu/packages/machine-learning.scm b/gnu/packages/machine-learn= ing.scm index f96672c..4332045 100644 --- a/gnu/packages/machine-learning.scm +++ b/gnu/packages/machine-learning.scm @@ -1,6 +1,7 @@ ;;; GNU Guix --- Functional package management for GNU ;;; Copyright =C2=A9 2015, 2016 Ricardo Wurmus ;;; Copyright =C2=A9 2016 Efraim Flashner +;;; Copyright =C2=A9 2016 Marius Bakke ;;; ;;; This file is part of GNU Guix. ;;; @@ -27,18 +28,21 @@ #:use-module (guix build-system gnu) #:use-module (guix build-system r) #:use-module (gnu packages) + #:use-module (gnu packages algebra) #:use-module (gnu packages autotools) #:use-module (gnu packages boost) #:use-module (gnu packages compression) #:use-module (gnu packages dejagnu) #:use-module (gnu packages gcc) + #:use-module (gnu packages image) #:use-module (gnu packages maths) #:use-module (gnu packages perl) #:use-module (gnu packages pkg-config) #:use-module (gnu packages python) #:use-module (gnu packages statistics) #:use-module (gnu packages swig) - #:use-module (gnu packages xml)) + #:use-module (gnu packages xml) + #:use-module (gnu packages xorg)) =20 (define-public libsvm (package @@ -467,3 +471,64 @@ geometric models.") "This package provides functions for feed-forward neural networks wit= h a single hidden layer, and for multinomial log-linear models.") (license (list license:gpl2+ license:gpl3+)))) + +(define-public dlib + (package + (name "dlib") + (version "19.1") + (source (origin + (method url-fetch) + (uri (string-append + "http://dlib.net/files/dlib-" version ".tar.bz2")) + (sha256 + (base32 + "0p2pvcdalc6jhb6r99ybvjd9x74sclr0ngswdg9j2xl5pj7knbr4")) + (modules '((guix build utils))) + (snippet + '(begin + ;; Delete ~13MB of bundled dependencies. + (delete-file-recursively "dlib/external") + (delete-file-recursively "docs/dlib/external"))))) + (build-system cmake-build-system) + (arguments + `(#:phases + (modify-phases %standard-phases + (add-after 'unpack 'disable-asserts + (lambda _ + ;; config.h recommends explicitly enabling or disabling asser= ts + ;; when building as a shared library. By default neither is s= et. + (substitute* "dlib/config.h" + (("^//#define DLIB_DISABLE_ASSERTS") "#define DLIB_DISABLE_= ASSERTS")) + #t)) + (replace 'check + (lambda _ + ;; No test target, so we build and run the unit tests here. + (let ((test-dir (string-append "../dlib-" ,version "/dlib/tes= t/build"))) + (mkdir-p test-dir) + (with-directory-excursion test-dir + (and (zero? (system* "cmake" "..")) + (zero? (system* "cmake" "--build" "." "--config" "Re= lease")) + (zero? (system* "./dtest" "--runall"))))))) + (add-after 'install 'delete-static-library + (lambda* (#:key outputs #:allow-other-keys) + (delete-file (string-append (assoc-ref outputs "out") "/lib/l= ibdlib.a"))))))) + (native-inputs + `(("pkg-config" ,pkg-config))) + (inputs + `(("fftw" ,fftw) + ("giflib" ,giflib) + ;("lapack" ,lapack) XXX lapack here causes test failures in some se= tups. + ("libjpeg" ,libjpeg) + ("libpng" ,libpng) + ("libx11" ,libx11) + ("openblas" ,openblas) + ("zlib" ,zlib))) + (synopsis + "Toolkit for making machine learning and data analysis applications i= n C++") + (description + "Dlib is a modern C++ toolkit containing machine learning algorithms = and +tools. It is used in both industry and academia in a wide range of domains +including robotics, embedded devices, mobile phones, and large high perfor= mance +computing environments.") + (home-page "http://dlib.net") + (license license:boost1.0))) --=20 2.9.2 --=-=-=--