Re: [PATCH] gnu: Add praat

[ludo@gnu.org (Ludovic Courtès)]

Hi Brendan,

Brendan Tildesley <brendan.tildesley@openmailbox.org> skribis:

> Please discard the first patch and consider this updated version. I was
> able to identify a timestamp and remove it, make the build reproducible.

Awesome!

> From bdc94ded90345e67885a7aa3b7e649bc546ad22c Mon Sep 17 00:00:00 2001
> From: Brendan Tildesley <brendan.tildesley@openmailbox.org>
> Date: Fri, 2 Sep 2016 03:28:58 +1000
> Subject: [PATCH] gnu: Add praat
>
> * gnu/packages/linguistics.scm (praat): New variable

[...]

> +         (add-after 'unpack 'be-timeless
> +           (lambda _
> +             (substitute* "external/portaudio/pa_front.c"
> +               ((" \\(built \" __DATE__  \" \" __TIME__ \"\\)") ""))
> +             #t))

Could you move it to a ‘snippet’ in the ‘origin’ form?  (See the
‘squeak-vm’ package for an example.)

> +    (license (list
> +              ;; Praat it's self (no version stated => gpl2+ by gpl terms)
> +              ;; EEG/*, FFNet/*, LPC/* external/mp3/*
> +              ;; external/espeak/espeakdata_FileInMemory.*
> +              ;; contrib/ola/*
> +              ;; kar/ipaSerifRegularPS.cpp
> +              ;; dwsys/regularExp.h
> +              ;; dwsys/NUMmathlib.cpp
> +              license:gpl2+
> +              ;; external/gsl/*
> +              ;; external/glpk/*
> +              ;; external/espeak/*
> +              license:gpl3+
> +              ;; external/flac/*
> +              license:bsd-3
> +              ;; external/portaudio/*
> +              license:expat
> +              ;; num/NUMrandom.cpp
> +              license:public-domain
> +              ;; external/flac/flac_share_alloc.h
> +              ;; external/glpk/colamd.c
> +              license:lgpl2.1+
> +              ))))

As Alex Griffin wrote, we should remove all of external/ in ‘snippet’
(see item #9 about “bundling” at
<https://www.gnu.org/software/guix/manual/html_node/Submitting-Patches.html>),
and instead add GSL, GLPK, FLAC, etc. as ‘inputs’ of the package.

Would you like to try it?

I think this is the only remaining blocker here.

Thank you for your work!

Ludo’.