Re: [PATCH 0/1] OpenSSL 1.1.0

[ludo@gnu.org (Ludovic Courtès)]

Leo Famulari <leo@famulari.name> skribis:

> From 2e6f500c7876733206e231fd98ebe7419d9b076f Mon Sep 17 00:00:00 2001
> From: Leo Famulari <leo@famulari.name>
> Date: Fri, 2 Sep 2016 16:07:29 -0400
> Subject: [PATCH] gnu: Add openssl-next.
>
> * gnu/packages/tls.scm (openssl-next): New variable.
> * gnu/packages/patches/openssl-1.1.0-c-rehash-in.patch: New file.
> * gnu/local.mk (dist_patch_DATA): Add it.

[...]

> +    (arguments
> +     `(#:disallowed-references (,perl)
> +       #:parallel-build? #f
> +       #:parallel-tests? #f
> +       #:test-target "test"
> +
> +       ;; Changes to OpenSSL sometimes cause Perl to "sneak in" to the closure,
> +       ;; so we explicitly disallow it here.
> +       #:disallowed-references ,(list (canonical-package perl))
> +       #:phases

Seems like most of the arguments and phases are shared with ‘openssl’,
right?  What about using ‘substitute-keyword-arguments’ to reduce
duplication?  Or are you concerned about potential breakage when one
series or the other changes?

  (arguments
   (substitute-keyword-arguments (package-arguments openssl)
     ((#:phase phases)
      `(modify-phases ,phases
         (add-after 'something 'some-openssl-1.1-specific-phase …)))))

Thanks!

Ludo’.