From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: Re: [PATCH 06/17] gnu: linux-libre: Add support for cross-compilation.
Date: Sun, 11 Sep 2016 22:58:45 +0200
Message-ID: <87h99mi262.fsf@gnu.org>
References: <20160909013641.GA9202@jasmine>
	<20160909123426.18499-1-david@craven.ch>
	<20160909123426.18499-6-david@craven.ch>
Mime-Version: 1.0
Content-Type: text/plain
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:40527)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1bjBq3-0008Ks-M3
	for guix-devel@gnu.org; Sun, 11 Sep 2016 16:58:56 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1bjBpx-00084u-Pz
	for guix-devel@gnu.org; Sun, 11 Sep 2016 16:58:54 -0400
In-Reply-To: <20160909123426.18499-6-david@craven.ch> (David Craven's message
	of "Fri, 9 Sep 2016 14:34:15 +0200")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: David Craven <david@craven.ch>
Cc: guix-devel@gnu.org

David Craven <david@craven.ch> skribis:

> * gnu/packages/linux.scm (linux-libre): Add support for
>   cross-compilation.

[...]

> +               (when target
> +                 (setenv "CROSS_COMPILE" (string-append target "-"))
> +                 (format #t "`CROSS_COMPILE' set to `~a'~%" (getenv "CROSS_COMPILE"))))

[...]

> +                    (mit    (assoc-ref (or native-inputs inputs) "module-init-tools")))

Please keep lines below 80 columns.

Otherwise OK!