From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: Re: [PATCH] gnu: Add gnome-calculator.
Date: Sat, 24 Sep 2016 12:18:54 +0900
Message-ID: <87h996t275.fsf@gnu.org>
References: <601048019f29fb5815582f203f6684b7@openmailbox.org>
	<874m57xvce.fsf@openmailbox.org>
	<1474636075.7646.7.camel@openmailbox.org>
	<87intm7fka.fsf@openmailbox.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:45122)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1bnfPS-00029r-RZ
	for guix-devel@gnu.org; Sat, 24 Sep 2016 01:21:59 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1bnfPM-0003jk-Q2
	for guix-devel@gnu.org; Sat, 24 Sep 2016 01:21:57 -0400
In-Reply-To: <87intm7fka.fsf@openmailbox.org> (Kei Kebreau's message of "Fri,
	23 Sep 2016 12:21:09 -0400")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: Kei Kebreau <kei@openmailbox.org>
Cc: guix-devel@gnu.org, rennes <rennes@openmailbox.org>

Hello,

Kei Kebreau <kei@openmailbox.org> skribis:

> rennes <rennes@openmailbox.org> writes:
>
>> On Thu, 2016-09-22 at 21:23 -0400, Kei Kebreau wrote:
>>>=20
>>> This is a good patch! The only change I recommend is moving the
>>> defintion to gnome.scm.
>>
>> I update the patch,
>> =C2=A0* Create the definition in gnome.scm file.
>> =C2=A0* Move 'glib' to=C2=A0native-inputs.
>> =C2=A0* Delete Copyright duplicate for=C2=A0
>> =C2=A0 =C2=A0';;; Copyright =C2=A9 2016 Rene Saavedra <rennes@openmailbo=
x.org>'
>>
>> Thank you
>
> Looks good and works well.
>
> Does somebody want to commit this to master?
> I'd do it myself, but I'm unfamiliar with the process of commiting
> someone else's code and I don't want to break anything.

It=E2=80=99s a good occasion to try=E2=80=94we need more reviewers!  :-)

The process is essentially to pipe the patch (which includes the commit
log and Subject: line) through =E2=80=9Cgit am -s=E2=80=9D.

If that applies fine, just run =E2=80=98guix lint the-package=E2=80=99 and =
ideally =E2=80=98guix
build --rounds=3D2 the-package=E2=80=99 to catch any issues.

If nothing comes up, just push!

If minor issues (typos, synopsis, etc.) come up, you might commit them
on behalf of the author, or ask them what they prefer.

Could you try and report back?  :-)

Thanks Kei & rennes!

Ludo=E2=80=99.