From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: Re: [PATCH 2/3] gnu: vlc: Add configure flags.
Date: Sat, 24 Sep 2016 13:18:34 +0900
Message-ID: <87h996rkv9.fsf@gnu.org>
References: <87vay4iham.fsf@gmail.com> <20160920200805.GA20679@jasmine>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:45526)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1bnfQC-0002Wd-9S
	for guix-devel@gnu.org; Sat, 24 Sep 2016 01:22:45 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1bnfQ9-0004FF-Vm
	for guix-devel@gnu.org; Sat, 24 Sep 2016 01:22:43 -0400
In-Reply-To: <20160920200805.GA20679@jasmine> (Leo Famulari's message of "Tue,
	20 Sep 2016 16:08:05 -0400")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: Leo Famulari <leo@famulari.name>
Cc: guix-devel@gnu.org

Leo Famulari <leo@famulari.name> skribis:

> On Sat, Sep 10, 2016 at 11:07:29AM +0800, Alex Vong wrote:
>> From 066bee5d7795c6caf2376be4a38e2cf0b397ef98 Mon Sep 17 00:00:00 2001
>> From: Alex Vong <alexvong1995@gmail.com>
>> Date: Sat, 10 Sep 2016 00:32:03 +0800
>> Subject: [PATCH 2/3] gnu: vlc: Add configure flags.
>>=20
>> * gnu/packages/video.scm (vlc)[arguments]: Add configure flags to enable
>>   most fast-math optimizations.
>> ---
>>  gnu/packages/video.scm | 3 +++
>>  1 file changed, 3 insertions(+)
>>=20
>> diff --git a/gnu/packages/video.scm b/gnu/packages/video.scm
>> index 858e007..a041666 100644
>> --- a/gnu/packages/video.scm
>> +++ b/gnu/packages/video.scm
>> @@ -650,7 +650,10 @@ audio/video codec library.")
>>         `(;; Gross workaround for <https://trac.videolan.org/vlc/ticket/=
16907>.
>>           ;; In our case, this led to a test failure:
>>           ;;   test_libvlc_equalizer: libvlc/equalizer.c:122: test_equal=
izer: Assertion `isnan(libvlc_audio_equalizer_get_amp_at_index (equalizer, =
u_bands))' failed.
>> +         ;; FIXME: This bug is fixed upstream. For now, we enable:
>>           "ac_cv_c_fast_math=3Dno"
>> +         "CFLAGS=3D-ffast-math -fno-finite-math-only"
>> +         "CXXFLAGS=3D-ffast-math -fno-finite-math-only"
>
> I don't know much about this subject. Can anyone say if we can expect
> this to work on all our supported architectures?

Dunno; Alex, could you tell more?  :-)  Also, didn=E2=80=99t you mean to re=
move
the ac_cv_c_fast_math=3Dno line altogether?

Ludo=E2=80=99.