From mboxrd@z Thu Jan  1 00:00:00 1970
From: Theodoros Foradis <theodoros.for@openmailbox.org>
Subject: Re: [PATCH 2/3] gnu: Add hidapi.
Date: Wed, 26 Oct 2016 21:29:03 +0300
Message-ID: <87h97zt15c.fsf@openmailbox.org>
References: <20161025132615.20705-1-theodoros.for@openmailbox.org>
	<20161025132615.20705-3-theodoros.for@openmailbox.org>
	<CAL1_imnGMHJoikvoe1zOuOY51CcO3Mrxcy1J7gjXT0-BnhhDWw@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:49303)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <theodoros.for@openmailbox.org>) id 1bzT06-0007hq-9C
	for guix-devel@gnu.org; Wed, 26 Oct 2016 14:32:35 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <theodoros.for@openmailbox.org>) id 1bzT02-000825-9k
	for guix-devel@gnu.org; Wed, 26 Oct 2016 14:32:34 -0400
Received: from smtp10.openmailbox.org ([62.4.1.44]:56736)
	by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <theodoros.for@openmailbox.org>)
	id 1bzT02-00081k-1g
	for guix-devel@gnu.org; Wed, 26 Oct 2016 14:32:30 -0400
In-reply-to: <CAL1_imnGMHJoikvoe1zOuOY51CcO3Mrxcy1J7gjXT0-BnhhDWw@mail.gmail.com>
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: Guix-devel <guix-devel@gnu.org>


David Craven writes:

> I don't think we need this:
>
> (arguments
> +     '(#:phases
> +       (modify-phases %standard-phases
> +         (add-before 'configure 'bootstrap
> +                    (lambda _
> +                      (system* "./bootstrap")
> +                      #t)))))
>
>> +    (native-inputs `(("autoconf" ,autoconf)
>> +                     ("libtool" ,libtool)
>> +                     ("automake" ,automake)
>> +                     ("pkg-config" ,pkg-config)))
>

There is no configure script in the release tarball, so I think we
either need this or:
(lambda _
  (system* "autoreconf" "-vfi")
  #t)

Can't build without neither.
> Is license is gpl3+
>
> +    (license license:gpl3)))
>
LICENSE.txt says:
HIDAPI can be used under one of three licenses.
1. The GNU General Public License, version 3.0, in LICENSE-gpl3.txt

What am I missing?
> Input list indentation.

Thanks for letting me know.
-- 
Theodoros Foradis