unofficial mirror of guix-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Theodoros Foradis <theodoros.for@openmailbox.org>
To: Guix-devel <guix-devel@gnu.org>
Subject: Re: [PATCH 2/3] gnu: Add hidapi.
Date: Wed, 26 Oct 2016 21:29:03 +0300	[thread overview]
Message-ID: <87h97zt15c.fsf@openmailbox.org> (raw)
In-Reply-To: <CAL1_imnGMHJoikvoe1zOuOY51CcO3Mrxcy1J7gjXT0-BnhhDWw@mail.gmail.com>


David Craven writes:

> I don't think we need this:
>
> (arguments
> +     '(#:phases
> +       (modify-phases %standard-phases
> +         (add-before 'configure 'bootstrap
> +                    (lambda _
> +                      (system* "./bootstrap")
> +                      #t)))))
>
>> +    (native-inputs `(("autoconf" ,autoconf)
>> +                     ("libtool" ,libtool)
>> +                     ("automake" ,automake)
>> +                     ("pkg-config" ,pkg-config)))
>

There is no configure script in the release tarball, so I think we
either need this or:
(lambda _
  (system* "autoreconf" "-vfi")
  #t)

Can't build without neither.
> Is license is gpl3+
>
> +    (license license:gpl3)))
>
LICENSE.txt says:
HIDAPI can be used under one of three licenses.
1. The GNU General Public License, version 3.0, in LICENSE-gpl3.txt

What am I missing?
> Input list indentation.

Thanks for letting me know.
-- 
Theodoros Foradis

  reply	other threads:[~2016-10-26 18:32 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-25 13:26 [PATCH 0/3] gnu: Add gdb-arm-none-eabi and openocd Theodoros Foradis
2016-10-25 13:26 ` [PATCH 1/3] gnu: Add gdb-arm-none-eabi Theodoros Foradis
2016-10-26 12:57   ` David Craven
2016-10-25 13:26 ` [PATCH 2/3] gnu: Add hidapi Theodoros Foradis
2016-10-26 12:55   ` David Craven
2016-10-26 18:29     ` Theodoros Foradis [this message]
2016-10-26 18:50       ` David Craven
2016-10-25 13:26 ` [PATCH 3/3] gnu: Add openocd Theodoros Foradis
2016-10-26 12:49   ` David Craven
2016-10-26 21:08     ` [PATCH v2 0/3] gnu: Add gdb-arm-none-eabi and openocd Theodoros Foradis
2016-10-26 21:08       ` [PATCH v2 1/3] gnu: Add gdb-arm-none-eabi Theodoros Foradis
2016-10-26 21:08       ` [PATCH v2 2/3] gnu: Add hidapi Theodoros Foradis
2016-10-28  6:19         ` Ricardo Wurmus
2016-10-28 15:35           ` Theodoros Foradis
2016-10-26 21:08       ` [PATCH v2 3/3] gnu: Add openocd Theodoros Foradis
2016-10-27  6:24         ` Efraim Flashner
2016-10-28  6:14         ` Ricardo Wurmus
2016-10-28 17:36           ` Theodoros Foradis
2016-10-28 17:36             ` [PATCH v3 1/3] gnu: Add gdb-arm-none-eabi Theodoros Foradis
2016-10-28 17:36             ` [PATCH v3 2/3] gnu: Add hidapi Theodoros Foradis
2016-11-09 15:45               ` Ludovic Courtès
2016-10-28 17:36             ` [PATCH v3 3/3] gnu: Add openocd Theodoros Foradis
2016-10-30  1:40               ` David Craven
2016-10-30  5:34                 ` Ricardo Wurmus
2016-10-30 13:05                   ` David Craven
2016-10-30 18:18                     ` Ricardo Wurmus
2016-10-30 18:19                       ` David Craven
2016-10-30 18:24                   ` Ricardo Wurmus
2017-02-13 19:44               ` Leo Famulari

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87h97zt15c.fsf@openmailbox.org \
    --to=theodoros.for@openmailbox.org \
    --cc=guix-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).