From mboxrd@z Thu Jan 1 00:00:00 1970 From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=) Subject: Re: [PATCH] gnu: file-system-shepherd-service: Use mount-file-system. Date: Sun, 04 Dec 2016 22:12:00 +0100 Message-ID: <87h96j5rhb.fsf@gnu.org> References: <1480444419-32288-1-git-send-email-jmd@gnu.org> <87k2blku5w.fsf@gnu.org> <20161202113256.GA30350@jocasta.intra> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:35446) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cDe4t-0004RU-Ha for guix-devel@gnu.org; Sun, 04 Dec 2016 16:12:08 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cDe4p-0004Nv-HQ for guix-devel@gnu.org; Sun, 04 Dec 2016 16:12:07 -0500 In-Reply-To: <20161202113256.GA30350@jocasta.intra> (John Darrington's message of "Fri, 2 Dec 2016 12:32:56 +0100") List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: John Darrington Cc: guix-devel@gnu.org, John Darrington John Darrington skribis: > On Wed, Nov 30, 2016 at 01:51:23PM +0100, Ludovic Court??s wrote: > John Darrington skribis: >=20=20=20=20=20=20 > > * gnu/services/base.scm (file-system-shepherd-service): Use mount-= file-system > > instead of manually mounting the file system. >=20=20=20=20=20=20 > [...] >=20=20=20=20=20=20 > > + #$(if create? > > + #~(mkdir-p #$target) > > + #~#t) >=20=20=20=20=20=20 > #~#t is equivalent to #t. >=20=20=20=20=20=20 > > + (mount-file-system > > + `(#$device #$title #$target #$type #$flags #$options > > + #$check?) #:root "/") > > #t)) >=20=20=20=20=20=20 > #t must be align with the parent of ???(mount-file-system???. >=20=20=20=20=20=20 > If you confirmed that at least ???make check-system TESTS=3Dbasic???= passes, > fine with me. >=20=20=20=20=20=20 > > Perhaps somebody who already has a copy of qemu in their store could chec= k that > for me? hydra.gnu.org has a copy. :-) Anyway, thanks for pushing this! Ludo=E2=80=99.