unofficial mirror of guix-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: ludo@gnu.org (Ludovic Courtès)
To: Ricardo Wurmus <rekado@elephly.net>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH 02/10] gnu: Add propeller-binutils.
Date: Sat, 31 Dec 2016 01:31:36 +0100	[thread overview]
Message-ID: <87h95l547r.fsf@gnu.org> (raw)
In-Reply-To: <20161226160452.19939-2-rekado@elephly.net> (Ricardo Wurmus's message of "Mon, 26 Dec 2016 17:04:44 +0100")

Ricardo Wurmus <rekado@elephly.net> skribis:

> * gnu/packages/embedded.scm (propeller-binutils): New variable.

[...]

> +         ,@(substitute-keyword-arguments (package-arguments xbinutils)
> +             ((#:configure-flags flags)
> +              `(cons "--disable-nls" ,flags)))))

That shouldn't be needed.

> +      (native-inputs
> +       `(("bison" ,bison)
> +         ("flex" ,flex)
> +         ("texinfo" ,texinfo)
> +         ("dejagnu" ,dejagnu)

The test failures you see are because you added DejaGNU here.  The other
Binutils instances don’t have it, so few tests are run I guess.  :-)

If this is not needed for bootstrapping, I’d suggest removing it.

Otherwise LGTM, thanks!

  reply	other threads:[~2016-12-31  0:31 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-12-26 16:04 [PATCH 01/10] gnu: Add dummy linker for propeller-elf Ricardo Wurmus
2016-12-26 16:04 ` [PATCH 02/10] gnu: Add propeller-binutils Ricardo Wurmus
2016-12-31  0:31   ` Ludovic Courtès [this message]
2016-12-31 17:03     ` Ricardo Wurmus
2017-01-02 22:34       ` Ludovic Courtès
2016-12-26 16:04 ` [PATCH 03/10] gnu: Add propeller-gcc Ricardo Wurmus
2016-12-31  0:33   ` Ludovic Courtès
2016-12-26 16:04 ` [PATCH 04/10] gnu: Add proplib Ricardo Wurmus
2016-12-31  0:33   ` Ludovic Courtès
2016-12-26 16:04 ` [PATCH 05/10] gnu: Add propeller-toolchain Ricardo Wurmus
2016-12-31  0:34   ` Ludovic Courtès
2016-12-26 16:04 ` [PATCH 06/10] gnu: Add openspin Ricardo Wurmus
2016-12-31  0:34   ` Ludovic Courtès
2016-12-26 16:04 ` [PATCH 07/10] gnu: Add propeller-load Ricardo Wurmus
2016-12-31  0:35   ` Ludovic Courtès
2016-12-26 16:04 ` [PATCH 08/10] gnu: Add spin2cpp Ricardo Wurmus
2016-12-31  0:36   ` Ludovic Courtès
2016-12-26 16:04 ` [PATCH 09/10] gnu: Add spinsim Ricardo Wurmus
2016-12-31  0:36   ` Ludovic Courtès
2016-12-26 16:04 ` [PATCH 10/10] gnu: Add propeller-development-suite Ricardo Wurmus
2016-12-31  0:37   ` Ludovic Courtès
2016-12-30 21:26 ` [PATCH 01/10] gnu: Add dummy linker for propeller-elf Kei Kebreau
2017-01-01 12:40   ` Ricardo Wurmus
2016-12-31  0:29 ` Ludovic Courtès

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87h95l547r.fsf@gnu.org \
    --to=ludo@gnu.org \
    --cc=guix-devel@gnu.org \
    --cc=rekado@elephly.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).