From: ludo@gnu.org (Ludovic Courtès)
To: Mathieu Lirzin <mthl@gnu.org>
Cc: guix-devel@gnu.org
Subject: Re: Cuirass and duplicate derivations
Date: Mon, 09 Jan 2017 10:11:54 +0100 [thread overview]
Message-ID: <87h958r411.fsf@gnu.org> (raw)
In-Reply-To: <87a8b1xdx5.fsf@gnu.org> (Mathieu Lirzin's message of "Mon, 09 Jan 2017 01:41:42 +0100")
Hello,
Mathieu Lirzin <mthl@gnu.org> skribis:
> Mathieu Lirzin <mthl@gnu.org> writes:
>
>> ludo@gnu.org (Ludovic Courtès) writes:
>>
>>> What change would you suggest to solve this problem? It would be best
>>> if Cuirass allowed several jobs building the same derivations (the key
>>> could be an autoincrement counter instead of the (drv,eval) pair maybe?)
>>
>> Seems reasonable to me. I will do that.
>> Thanks.
>
> After a second thought, I think maybe it is sufficient to just ignore
> when a derivation is added twice by an evaluation. As a consequence
> 'cuirass' will only try to realize the derivation once per evaluation.
Even better, yes.
> From 568d0e1b0866a45e95440d17b6e8f1740cc23e3f Mon Sep 17 00:00:00 2001
> From: Mathieu Lirzin <mthl@gnu.org>
> Date: Mon, 9 Jan 2017 01:29:48 +0100
> Subject: [PATCH] database: db-add-derivation: Don't try to add a derivation
> twice.
>
> * src/cuirass/database.scm (db-add-derivation): Ignore if JOB is already
> present in DB.
OK!
We can update the ‘cuirass’ package in Guix afterwards.
Thank you!
Ludo’.
prev parent reply other threads:[~2017-01-09 9:12 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <87r35o8x0h.fsf@gnu.org>
[not found] ` <87shq35tue.fsf@gnu.org>
[not found] ` <87y3zv4c4i.fsf@gnu.org>
[not found] ` <87fuljj5ku.fsf@gnu.org>
[not found] ` <87tw9mzq4v.fsf@gnu.org>
2017-01-02 21:40 ` Cuirass and duplicate derivations Ludovic Courtès
2017-01-08 23:20 ` Mathieu Lirzin
2017-01-09 0:41 ` Mathieu Lirzin
2017-01-09 9:11 ` Ludovic Courtès [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87h958r411.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=guix-devel@gnu.org \
--cc=mthl@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).