From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mark H Weaver Subject: Re: [PATCH] gnu: mupdf: Fix some security problems in bundled mujs. Date: Sun, 15 Jan 2017 03:20:59 -0500 Message-ID: <87h950ohsk.fsf@netris.org> References: <20170112180655.1588-1-mbakke@fastmail.com> <20170112183017.GB23706@jasmine> <87wpe05adv.fsf@kirby.i-did-not-set--mail-host-address--so-tickle-me> <20170112200346.GA11411@jasmine> <87shonai6b.fsf@netris.org> <20170113173428.GA27117@jasmine> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:37276) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cSg3v-0007a6-On for guix-devel@gnu.org; Sun, 15 Jan 2017 03:21:16 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cSg3s-0005jo-LN for guix-devel@gnu.org; Sun, 15 Jan 2017 03:21:15 -0500 Received: from world.peace.net ([50.252.239.5]:43947) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cSg3s-0005jc-Gg for guix-devel@gnu.org; Sun, 15 Jan 2017 03:21:12 -0500 In-Reply-To: <20170113173428.GA27117@jasmine> (Leo Famulari's message of "Fri, 13 Jan 2017 12:34:28 -0500") List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Leo Famulari Cc: guix-devel@gnu.org Leo Famulari writes: > On Thu, Jan 12, 2017 at 07:59:40PM -0500, Mark H Weaver wrote: >> Leo Famulari writes: >> > If we can't graft it, we should build it on a branch on Hydra. >> >> Here's what we can do: in addition to mupdf itself, we can also add a >> graft for cups-filters (our only package that includes mupdf as an >> input). The replacement for cups-filters would change its mupdf input >> to refer directly to the fixed version of mupdf. >> >> What do you think? > > That's a good idea, and I started implementing it, but then I wondered > how cups-filters was actually using mupdf. The cups-filters package is > only 3.7 MB, while libmupdf.a is 44 MB. > > It turns out that the built cups-filters doesn't refer to mupdf at all; > mupdf is not protected from the garbage collector if you install > cups-filters. Static linking copies segments of code and data from the *.a into whatever is being linked (an executable or library). So, buggy code might be copied from libmupdf.a into 'cups-filters', with no references to 'mupdf' remaining. Also, the fact that cups-filters is smaller than libmupdf.a doesn't prove that code wasn't copied from libmupdf.a. Thanks, Mark