[PATCH] gnu: python-click: Fix test failure.

[PATCH] gnu: python-click: Fix test failure.

[Danny Milosavljevic]

* gnu/packages/python.scm (python-click)[arguments]: Fix test failure.
---
 gnu/packages/python.scm | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/gnu/packages/python.scm b/gnu/packages/python.scm
index 4dc284d03..2f1bd8315 100644
--- a/gnu/packages/python.scm
+++ b/gnu/packages/python.scm
@@ -2383,6 +2383,8 @@ is used by the Requests library to verify HTTPS requests.")
        (modify-phases %standard-phases
          (add-after 'unpack 'fix-paths
            (lambda* (#:key inputs #:allow-other-keys)
+             ;; Causes test failure if present.
+             (delete-file "click/_winconsole.py")
              (let ((glibc (assoc-ref inputs ,(if (%current-target-system)
                                                  "cross-libc" "libc"))))
                (substitute* "click/_unicodefun.py"

Re: [PATCH] gnu: python-click: Fix test failure.

[Ludovic Courtès]

Danny Milosavljevic <dannym@scratchpost.org> skribis:

> * gnu/packages/python.scm (python-click)[arguments]: Fix test failure.
> ---
>  gnu/packages/python.scm | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/gnu/packages/python.scm b/gnu/packages/python.scm
> index 4dc284d03..2f1bd8315 100644
> --- a/gnu/packages/python.scm
> +++ b/gnu/packages/python.scm
> @@ -2383,6 +2383,8 @@ is used by the Requests library to verify HTTPS requests.")
>         (modify-phases %standard-phases
>           (add-after 'unpack 'fix-paths
>             (lambda* (#:key inputs #:allow-other-keys)
> +             ;; Causes test failure if present.
> +             (delete-file "click/_winconsole.py")

If you know more details, you’re welcome to add them in the comment, but
otherwise feel free to push!

Thanks,
Ludo’.

Re: [PATCH] gnu: python-click: Fix test failure.

[Danny Milosavljevic]

Hi Ludo,

> If you know more details, you’re welcome to add them in the comment, but
> otherwise feel free to push!

Does that mean push to master or to python-tests or to both?

Also, I don't really know more details other than that the test framework does autodiscovery and picks up a module for the wrong platform (Windows) just because it's there.

Re: [PATCH] gnu: python-click: Fix test failure.

[Marius Bakke]

[-- Attachment #1: Type: text/plain, Size: 653 bytes --]

Danny Milosavljevic <dannym@scratchpost.org> writes:

> Hi Ludo,
>
>> If you know more details, you’re welcome to add them in the comment, but
>> otherwise feel free to push!
>
> Does that mean push to master or to python-tests or to both?
>
> Also, I don't really know more details other than that the test
> framework does autodiscovery and picks up a module for the wrong
> platform (Windows) just because it's there.

I came across this in python-tests as well, and fixed it by executing
"make test" instead of relying on 'setup.py test'.

Pro tip: Check how upstream runs their test, if they have a CI system
(.travis.yml etc).

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]

Re: [PATCH] gnu: python-click: Fix test failure.

[Ludovic Courtès]

Danny Milosavljevic <dannym@scratchpost.org> skribis:

> Hi Ludo,
>
>> If you know more details, you’re welcome to add them in the comment, but
>> otherwise feel free to push!
>
> Does that mean push to master or to python-tests or to both?

Good question!  That can go to master, but Marius and Leo know better
whether ‘python-tests’ is a better fit.  Thoughts?

Ludo’.

Re: [PATCH] gnu: python-click: Fix test failure.

[Marius Bakke]

[-- Attachment #1: Type: text/plain, Size: 600 bytes --]

Ludovic Courtès <ludo@gnu.org> writes:

> Danny Milosavljevic <dannym@scratchpost.org> skribis:
>
>> Hi Ludo,
>>
>>> If you know more details, you’re welcome to add them in the comment, but
>>> otherwise feel free to push!
>>
>> Does that mean push to master or to python-tests or to both?
>
> Good question!  That can go to master, but Marius and Leo know better
> whether ‘python-tests’ is a better fit.  Thoughts?

This is already fixed in 'python-tests' by
97be1bc23128cf42c49867d984c43f6fea3820d6. I don't think we need to fix
it in 'master', since it "succeeds" anyway.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]

Re: [PATCH] gnu: python-click: Fix test failure.

[Ludovic Courtès]

Marius Bakke <mbakke@fastmail.com> skribis:

> Ludovic Courtès <ludo@gnu.org> writes:
>
>> Danny Milosavljevic <dannym@scratchpost.org> skribis:
>>
>>> Hi Ludo,
>>>
>>>> If you know more details, you’re welcome to add them in the comment, but
>>>> otherwise feel free to push!
>>>
>>> Does that mean push to master or to python-tests or to both?
>>
>> Good question!  That can go to master, but Marius and Leo know better
>> whether ‘python-tests’ is a better fit.  Thoughts?
>
> This is already fixed in 'python-tests' by
> 97be1bc23128cf42c49867d984c43f6fea3820d6. I don't think we need to fix
> it in 'master', since it "succeeds" anyway.

Oh good, makes sense.

Ludo’.