From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: Re: [PATCH 1/2] gnu: Add unibilium.
Date: Thu, 19 Jan 2017 14:03:12 +0100
Message-ID: <87h94vxkvj.fsf@gnu.org>
References: <20170118153419.11126-1-ricardo.wurmus@mdc-berlin.de>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:55705)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1cUCN6-0005OO-HC
	for guix-devel@gnu.org; Thu, 19 Jan 2017 08:03:21 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1cUCN2-0004IA-7i
	for guix-devel@gnu.org; Thu, 19 Jan 2017 08:03:20 -0500
In-Reply-To: <20170118153419.11126-1-ricardo.wurmus@mdc-berlin.de> (Ricardo
	Wurmus's message of "Wed, 18 Jan 2017 16:34:18 +0100")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de>
Cc: guix-devel@gnu.org

Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de> skribis:

> * gnu/packages/terminals.scm (unibilium): New variable.

[...]

> +    (native-inputs
> +     `(("libtool" ,libtool)))

Weird that it needs Libtool without also needing Autoconf and/or
Automake.

> +    (home-page "https://github.com/mauke/unibilium")
> +    (synopsis "Terminfo parsing library")
> +    (description "Unibilium is a very basic terminfo library.  It

s/very basic terminfo library/basic C terminfo library/

Otherise LGTM, thanks!

Ludo=E2=80=99.