unofficial mirror of guix-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Marius Bakke <mbakke@fastmail.com>
To: ng0 <contact.ng0@cryptolab.net>,
	Danny Milosavljevic <dannym@scratchpost.org>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH] gnu: Add python-pyodbc-c.
Date: Thu, 26 Jan 2017 19:14:41 +0100	[thread overview]
Message-ID: <87h94l4rji.fsf@kirby.i-did-not-set--mail-host-address--so-tickle-me> (raw)
In-Reply-To: <87mvedkbgw.fsf@wasp.i-did-not-set--mail-host-address--so-tickle-me>

[-- Attachment #1: Type: text/plain, Size: 1181 bytes --]

ng0 <contact.ng0@cryptolab.net> writes:

> Danny Milosavljevic <dannym@scratchpost.org> writes:
>
>> * gnu/packages/databases.scm (python-pyodbc-c, python2-pyodbc-c):
>>   New variables.

[...]

>> +       (file-name (string-append name "-" version ".tar.gz"))))
>> +    (build-system python-build-system)
>> +    (inputs
>> +     `(("unixodbc" ,unixodbc)))
>> +    (arguments
>> +     `(#:tests? #f ; no tests exist
>> +      ))

Please move these to the previous line.

>> +    (home-page "https://github.com/mkleehammer/pyodbc")
>
> This is pulled from gitlab and the homepage is on gitlab? I think
> it's better to use the gitlab repository as home-page then, or
> what's the reason?

I think this is a better home page since it provides usage instructions:

https://mkleehammer.github.io/pyodbc/
>
>> +    (synopsis "Python ODBC Library")
>> +    (description "This package provides a Python DB-API driver for ODBC.")
>
> If I remember correctly, we should avoid starting synopsis and
> description with words like "This". What about:
>
> (description "@code{python-pyodbc-c} provides …"

Either of these two styles are fine IMO. LGTM!

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]

  reply	other threads:[~2017-01-26 18:14 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-26  0:26 [PATCH] gnu: Add python-pyodbc-c Danny Milosavljevic
2017-01-26 16:55 ` ng0
2017-01-26 18:14   ` Marius Bakke [this message]
2017-01-26 18:21     ` Danny Milosavljevic
2017-01-26 18:33       ` Marius Bakke
2017-01-26 18:27     ` [PATCH v2] " Danny Milosavljevic
2017-02-07 18:36       ` Kei Kebreau

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87h94l4rji.fsf@kirby.i-did-not-set--mail-host-address--so-tickle-me \
    --to=mbakke@fastmail.com \
    --cc=contact.ng0@cryptolab.net \
    --cc=dannym@scratchpost.org \
    --cc=guix-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).