From: ludo@gnu.org (Ludovic Courtès)
To: Julien Lepiller <julien@lepiller.eu>
Cc: guix-devel <guix-devel@gnu.org>
Subject: Re: [PATCH 09/10] gnu: Add ocaml-js-build-tools.
Date: Mon, 30 Jan 2017 23:23:27 +0100 [thread overview]
Message-ID: <87h94gkx0g.fsf@gnu.org> (raw)
In-Reply-To: <20170130220850.77b8e4a4@lepiller.eu> (Julien Lepiller's message of "Mon, 30 Jan 2017 22:08:50 +0100")
Julien Lepiller <julien@lepiller.eu> skribis:
> On Mon, 30 Jan 2017 10:22:13 +0100
> ludo@gnu.org (Ludovic Courtès) wrote:
>
>> Julien Lepiller <julien@lepiller.eu> skribis:
>>
>> > +++ b/gnu/packages/patches/ocaml-janestreet-fix-libdir.patch
>> > @@ -0,0 +1,39 @@
>> > +This patch adds a --libdir option to opam-installer so it installs
>> > the plugin +in the specified directory rather than in the default
>> > one (ocaml's directory in +the store, which is forbidden).
>> > +diff -aur package.pristine/Makefile package.new/Makefile
>> > +--- package.pristine/Makefile 2016-02-06 01:55:14.650150309
>> > +0100 ++++ package.new/Makefile 2016-02-06
>> > 01:57:56.012174364 +0100 +@@ -29,26 +29,26 @@
>> > + ocaml -I js-utils js-utils/gen_install.ml
>> > +
>> > + install: $(NAME).install
>> > +- opam-installer -i --prefix $(PREFIX) $(NAME).install
>> > ++ opam-installer -i --prefix $(PREFIX) --libdir $(LIBDIR)
>> > $(NAME).install +
>> > + uninstall: $(NAME).install
>> > +- opam-installer -u --prefix $(PREFIX) $(NAME).install
>> > ++ opam-installer -u --prefix $(PREFIX) --libdir $(LIBDIR)
>> > $(NAME).install
>>
>> On second thought, I think it’d be simpler and more maintainable to do
>> this as a substitution in the snippet.
>>
>> WDYT?
>>
>> (It will also avoid ‘guix lint’ complaints about the patch file name
>> not matching the package name. :-))
>>
>> Ludo’.
>
> Sure, here it is :)
>
> From 8cd3ba3a3f9702a89f8f52c75c33d3d02f20f60b Mon Sep 17 00:00:00 2001
> From: Julien Lepiller <julien@lepiller.eu>
> Date: Fri, 30 Dec 2016 16:27:27 +0100
> Subject: [PATCH 2/2] gnu: Add ocaml-bin-prot.
>
> * gnu/packages/ocaml.scm (ocaml-bin-prot): New variable.
Wait, I was commenting on ocaml-js-build-tools, not on ocaml-bin-prot:
https://lists.gnu.org/archive/html/guix-devel/2017-01/threads.html#02134
Could it be that you’re replying to the wrong message? :-)
Ludo’.
next prev parent reply other threads:[~2017-01-30 22:23 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-27 22:12 [PATCH 00/10] ocaml patches v2 Julien Lepiller
2017-01-27 22:12 ` [PATCH 01/10] gnu: Add ocaml-base64 Julien Lepiller
2017-01-27 22:12 ` [PATCH 02/10] gnu: Add ocamlify Julien Lepiller
2017-01-27 22:12 ` [PATCH 03/10] gnu: Add omake Julien Lepiller
2017-01-27 22:12 ` [PATCH 04/10] gnu: Add ocaml-batteries Julien Lepiller
2017-01-27 22:12 ` [PATCH 05/10] gnu: Add ocaml-pcre Julien Lepiller
2017-01-27 22:12 ` [PATCH 06/10] gnu: Add ocaml-expect Julien Lepiller
2017-01-27 22:12 ` [PATCH 07/10] gnu: Add ocaml-fileutils Julien Lepiller
2017-01-27 22:12 ` [PATCH 08/10] gnu: Add ocaml-oasis Julien Lepiller
2017-01-27 22:12 ` [PATCH 09/10] gnu: Add ocaml-js-build-tools Julien Lepiller
2017-01-30 9:19 ` Ludovic Courtès
2017-01-30 9:22 ` Ludovic Courtès
2017-01-30 21:08 ` Julien Lepiller
2017-01-30 22:23 ` Ludovic Courtès [this message]
2017-01-30 22:48 ` Julien Lepiller
2017-01-31 9:22 ` Ludovic Courtès
2017-01-27 22:12 ` [PATCH 10/10] gnu: Add ocaml-bin-prot Julien Lepiller
2017-01-30 9:23 ` [PATCH 00/10] ocaml patches v2 Ludovic Courtès
-- strict thread matches above, loose matches on Subject: below --
2017-01-18 20:27 [PATCH 00/10] ocaml patches Julien Lepiller
2017-01-18 20:28 ` [PATCH 09/10] gnu: Add ocaml-js-build-tools Julien Lepiller
2017-01-18 22:21 ` Marius Bakke
2017-01-20 13:28 ` Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87h94gkx0g.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=guix-devel@gnu.org \
--cc=julien@lepiller.eu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).