From mboxrd@z Thu Jan 1 00:00:00 1970 From: Maxim Cournoyer Subject: Re: [PATCH 3/7] gnu: Add python2-ruamel.ordereddict Date: Wed, 01 Feb 2017 20:53:30 -0800 Message-ID: <87h94d9os5.fsf@gmail.com> References: <20160925173931.GD9499@jasmine> <20170131125339.18500-1-contact.ng0@cryptolab.net> <20170131125339.18500-4-contact.ng0@cryptolab.net> Mime-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:44358) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cZ9VJ-0002rZ-EI for guix-devel@gnu.org; Thu, 02 Feb 2017 00:00:18 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cZ9Or-0000a7-1u for guix-devel@gnu.org; Wed, 01 Feb 2017 23:53:38 -0500 Received: from mail-pf0-x242.google.com ([2607:f8b0:400e:c00::242]:35085) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cZ9Oq-0000ZJ-RN for guix-devel@gnu.org; Wed, 01 Feb 2017 23:53:36 -0500 Received: by mail-pf0-x242.google.com with SMTP id f144so543180pfa.2 for ; Wed, 01 Feb 2017 20:53:36 -0800 (PST) In-Reply-To: <20170131125339.18500-4-contact.ng0@cryptolab.net> (contact's message of "Tue, 31 Jan 2017 12:53:35 +0000") List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: contact.ng0@cryptolab.net Cc: guix-devel@gnu.org, ng0 --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Hi, I have a few of comments for this one too. contact.ng0@cryptolab.net writes: > From: ng0 > > * gnu/packages/python.scm (python2-ruamel.ordereddict): New variable. > --- > gnu/packages/python.scm | 28 ++++++++++++++++++++++++++++ > 1 file changed, 28 insertions(+) > > diff --git a/gnu/packages/python.scm b/gnu/packages/python.scm > index f6516d26b..cef9d2a8c 100644 > --- a/gnu/packages/python.scm > +++ b/gnu/packages/python.scm > @@ -583,6 +583,34 @@ the Python logging module that outputs records using= terminal colors.") > (native-inputs > `(("python2-setuptools" ,python2-setuptools)))))) >=20=20 > +(define-public python2-ruamel.ordereddict > + (package > + (name "python2-ruamel.ordereddict") > + (version "0.4.9") > + (source > + (origin > + (method url-fetch) > + (uri (pypi-uri "ruamel.ordereddict" version)) > + (sha256 > + (base32 > + "1xmkl8v9l9inm2pyxgc1fm5005yxm7fkd5gv74q7lj1iy5qc8n3h")))) > + (build-system python-build-system) > + ;; XXX: https://bitbucket.org/ruamel/ordereddict/issues/2 Maybe the comment should say "No ordereddict python3 build available" ? > + (arguments > + `(#:python ,python-2)) > + (inputs > + `(("python2-setuptools" ,python2-setuptools))) Unnecessary, part of our Python2 package. > + (home-page "https://bitbucket.org/ruamel/ordereddict") > + (synopsis "Version of @code{dict} that keeps keys in insertion > +resp. sorted order") > + (description > + "This is an implementation of an ordered dictionary with Key > +Insertion Order and Key Value Insertion Order. The standard library Is the capitalization of Key Insertion Order/Key Value Insertion Order really necessary? Also, there are 2 spaces following the period. > +module OrderedDict, implemented later, implements a subset of > +ordereddict functionality. Sorted dictionaries are also provided. 2 spaces following the period here also. Is this intended? > +Currently only with Key Sorted Order.") Again, I'm not sure about the proper capitalization here. Thanks, Maxim --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEJ9WGpPiQCFQyn/CfEmDkZILmNWIFAliSu0oACgkQEmDkZILm NWLJORAAjxEQYxeXiHuvA2mbE83xMB73xq91zHMBWCOAwHFTB2u/PyQIECWUXn6i Y4AaRRcmEPlcRn0XKDAMxT6RX2z5gxSdm5htYa3RNLPgwFMlqNSLFD5MdHGlvVf0 2yfrm1xi0jXwwFgaw4tVPAlDTMfxCFwTe0sxn27oR7FbdI1VWsegmcF7TS7L4JwE 9RhAErR+YAmNU+luDjkvq2pRwksHh/SvNPIbNca2Lc7dfGk/2wS0HKQDQ1F8P0BH ewVhSJEX+ZtuuyTrDA0/8mczTjjNnvnUTo9tnGQbTNf5nZ2nrtPitor5GPLuJPDO MFj/vwk1IMHQ4jq7VLTMdTdXbrXdFwLvx/CC3poTiTpJe+mVbGfv+kYqe9y6NHc8 1Iw7IC17ds8tGwKt7KYr0oyADlohnE3J8x2mj/SunASmgoLqJErz9SDRv7QetVa7 wPuQxq03k/m6kpBRDxmzcz5lXIlLQwrXLK/sIXhS+gcZRiagb6uKljoAFEETa0iw 0nxrkpXBnal4n1+GaaD7xPFh+GriJmcDOGMSV95CFOpZCQK15DjWOnJgs0Z517WH RwR4fRATnx3Qtw3QjcLID+wE6RLhpb2vNkYYkELo4d09W/Gk6DHZihRFMJfD3Bs0 A0b4Z4RzR6rCcBlJZ7tr2b+cwr2NONYvMqmDFyam0ILvUuKC/KQ= =YF1y -----END PGP SIGNATURE----- --=-=-=--