unofficial mirror of guix-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Ricardo Wurmus <rekado@elephly.net>
To: huang_ying_caritas@163.com
Cc: guix-devel@gnu.org
Subject: Re: [PATCH -v2] Fix gtk-im-modules for Gtk+3
Date: Mon, 06 Feb 2017 02:08:11 +0100	[thread overview]
Message-ID: <87h948yvlw.fsf@elephly.net> (raw)
In-Reply-To: <20170130030649.1716-1-huang_ying_caritas@163.com>


huang_ying_caritas@163.com writes:

> From: Huang Ying <huang.ying.caritas@gmail.com>
>
> Gtk+3 now have multiple outputs, so the gtk-query-immodules-3.0 should be find
> in bin output.

Ah, I was wondering why this broke!  Thanks for investigating it.

> The fix works, but appears hacky, because I haven't read much guix source
> code, so I don't know the best solution.

It’s only hacky because I tried to reuse the code for both versions of
Gtk.  Maybe “gtk+-2” should also get a “bin” output…?

This is acceptable with the changes Danny suggested.  Maybe we can find
a way to make this prettier in the future.

Thanks again for taking the time to investigate and fix it, and to
submit a patch!  I’m very grateful for this contribution.

--
Ricardo

GPG: BCA6 89B6 3655 3801 C3C6  2150 197A 5888 235F ACAC
https://elephly.net

  parent reply	other threads:[~2017-02-06  1:08 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-30  3:06 [PATCH -v2] Fix gtk-im-modules for Gtk+3 huang_ying_caritas
2017-02-03 11:21 ` Huang, Ying
2017-02-04 17:28 ` Danny Milosavljevic
2017-02-04 23:42   ` Huang, Ying
2017-02-06  1:08 ` Ricardo Wurmus [this message]
2017-02-06 10:28   ` Huang, Ying

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87h948yvlw.fsf@elephly.net \
    --to=rekado@elephly.net \
    --cc=guix-devel@gnu.org \
    --cc=huang_ying_caritas@163.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).