From: "Huang\, Ying" <huang_ying_caritas@163.com>
To: Danny Milosavljevic <dannym@scratchpost.org>
Cc: guix-devel@gnu.org, Alex Kost <alezost@gmail.com>
Subject: Re: [PATCH 1/2] build: union: Add create-all-directory? parameter to union-build
Date: Sat, 25 Feb 2017 09:05:59 +0800 [thread overview]
Message-ID: <87h93j9j0o.fsf@163.com> (raw)
In-Reply-To: <20170224150256.641cb08d@scratchpost.org> (Danny Milosavljevic's message of "Fri, 24 Feb 2017 15:02:56 +0100")
Danny Milosavljevic <dannym@scratchpost.org> writes:
> Hi,
>
> yeah, I've looked at it and I see what you are trying to do.
>
> You modified 'union to replicate the directory tree and symlink only the non-directory files - in order to be able to add "fonts.dir" in those directories.
>
> The previous version symlinked entire directories, too, and you wouldn't have been able to add those "fonts.dir" files inside them later.
>
> Your fix seems kinda hacky - but I don't really see a downside.
>
> Thinking about it some more I think it looks good enough to me. I'd like a second opinion, though.
>
> Other than that, the name of the new flag "create-all-directory?" is weird. I'd like it to be something like "create-all-directories?".
OK. Will change it.
Best Regards,
Huang, Ying
> (The non-hacky solution would be to make 'union aware that there are
> "fonts.dir" files to go in there, too. One could do that by adding
> these as an input, too. I'm not sure whether that would be worth the
> added complexity, though - especially since the fonts.dir generator
> needs to have the finished union as input and not just single
> directories one by one. Thoughts?)
next prev parent reply other threads:[~2017-02-25 1:06 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-18 0:44 [PATCH 1/2] build: union: Add create-all-directory? parameter to union-build huang_ying_caritas
2017-02-18 0:44 ` [PATCH 2/2] guix: profiles: create fonts.dir/scale for all fonts directories huang_ying_caritas
2017-02-24 12:40 ` [PATCH 1/2] build: union: Add create-all-directory? parameter to union-build Huang, Ying
2017-02-24 13:32 ` Andy Wingo
2017-02-25 1:03 ` Huang, Ying
2017-02-24 14:02 ` Danny Milosavljevic
2017-02-24 22:13 ` Mark H Weaver
2017-02-25 12:43 ` Huang, Ying
2017-02-27 9:06 ` Danny Milosavljevic
2017-03-03 1:25 ` Mark H Weaver
2017-02-25 1:05 ` Huang, Ying [this message]
2017-02-25 12:30 ` Huang, Ying
2017-02-26 8:23 ` 宋文武
2017-02-27 11:27 ` Huang, Ying
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87h93j9j0o.fsf@163.com \
--to=huang_ying_caritas@163.com \
--cc=alezost@gmail.com \
--cc=dannym@scratchpost.org \
--cc=guix-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).