From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kei Kebreau Subject: Re: [PATCH 01/26] gnu: Add perl-file-pushd. Date: Fri, 24 Mar 2017 10:26:27 -0400 Message-ID: <87h92i3g4s.fsf@openmailbox.org> References: <20170323140056.23173-1-alex@pompo.co> <87lgrv2wht.fsf@openmailbox.org> <87bmsrks7s.fsf@gmail.com> <87inmy4x6c.fsf@gmail.com> Mime-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:54953) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1crQBA-00050l-Hv for guix-devel@gnu.org; Fri, 24 Mar 2017 10:27:01 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1crQB7-000665-8F for guix-devel@gnu.org; Fri, 24 Mar 2017 10:27:00 -0400 Received: from lb1.openmailbox.org ([5.79.108.160]:34678 helo=mail.openmailbox.org) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1crQB6-00065i-VD for guix-devel@gnu.org; Fri, 24 Mar 2017 10:26:57 -0400 In-Reply-To: <87inmy4x6c.fsf@gmail.com> (Alex Sassmannshausen's message of "Fri, 24 Mar 2017 14:32:59 +0100") List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Alex Sassmannshausen Cc: guix-devel@gnu.org --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Alex Sassmannshausen writes: > Hi Ben, > > Ben Woodcroft writes: > >> Hi, >> >> >> On 24/03/17 18:13, Alex Sassmannshausen wrote: >>> Hi Kei, >>> >>> Kei Kebreau writes: >>> >>>> This series of packages builds and lints fine for me. There are over 2= 00 >>>> dependent packages that would have to be rebuilt though, and >>>> core-updates is frozen to my knowledge. We can save this for the next >>>> core-updates cycle, though! >>>> >>>> Other Guix users, please correct me if I'm wrong. >> According to the established guidelines, this should be OK for master >> since it affects <300 packages, so if all dependent packages build then >> I don't see why we shouldn't do that. >> >> https://lists.gnu.org/archive/html/guix-devel/2016-10/msg00933.html > > Cheers for your comments, very enlightening! I'm afraid I'm out of my > depth making this decision here. I'm happy to let my computer rebuild > those 200 packages to see whether the dependent packages build =E2=80=94 = but > I'm not sure how I would go about testing that. See below for a theory= =E2=80=A6? > >>> Thanks for the review! >>> >>> What command do you use to check the number of packages that would have >>> to be rebuilt? I'm asking, because if they are mainly perl libraries >>> then that figure of 200 really isn't that big of a deal: most perl libs >>> build super fast. >> To check the number of packages use "guix refresh -l" > > Interesting=E2=80=A6 so to establish the packages to be rebuilt as a resu= lt of > my patch series, would that be: > > guix refresh -l perl-scalar-list-utils perl-parse-cpan-meta \ > perl-cpan-meta-requirements perl-yaml perl-variable-magic \ > perl-time-duration-parse perl-test-warnings perl-test-simple \ > perl-test-exception perl-test-cleannamespaces perl-sub-name \ > perl-params-validate perl-package-deprecationmanager perl-moose \ > perl-module-runtime-conflicts perl-devel-partialdump \ > perl-devel-overloadinfo perl-cpan-meta-check perl-common-sense \ > perl-clone perl-class-load perl-capture-tiny perl-b-hooks-endofscope > > Building the following 24 packages would ensure 248 dependent packages > are rebuilt: edirect-4.10 perl-modern-perl-1.20150127 > perl-text-neattemplate-0.1101 perl-encode-detect-1.01 > perl-list-someutils-0.52 perl-db-file-1.838 pam-krb5-4.7 > perl-test-trailingspace-0.0300 sslh-1.18 perl-mail-spf-v2.9.0 > gerbv-2.6.1 netsurf-3.6 perl-config-ini-0.025 perl-anyevent-i3-0.16 > tophat-2.1.0 perl-test-class-most-0.08 gnucash-2.6.15 surfraw-2.2.9 > biber-2.5 biber-next-2.6 stow-2.2.2 perl-x11-xcb-0.16 roary-3.7.0 > hydra-20151030.1ff48da > > Does this mean, that in order to test this I would now simply try to > rebuild the 24 listed packages? Yes. Just make sure you use `./pre-inst-env guix build` so that you're testing the updated perl packages. Thanks! > > Cheers, > > Alex --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEg7ZwOtzKO2lLzi2m5qXuPBlGeg0FAljVLJMACgkQ5qXuPBlG eg2LlQ/+ONPYEb/XWSsF7DqB9NzAewurtzoHjn6rRvaA7s7QbTsmOSQeqa/xkjVi sUN6drv4K2TkGvhoHTR1GG70kSBDPesf841JBvvs1MB55nw3iGOmPWyjnzVLsYQX 21LToQ5bDy7d+gyEdPCTRQKHBubAsOLFsOCShE2hna+HSK3Qh9Er8nZO2WYUa/or 3WtOsptqeKMIjx5qaBKkfY76Ep7hWVd/KVT51dzRV3G+pELzNKFuAW2Xlwhtb5Fd AbcTGDvYo76JgGgUBv3eQH7BOyP9J8LPx7BnEATJIF87dSEcE8hxBKkaftP6B28W w57Kx4z4r4L9WnDk54XjmqIm4hnQDZ7ZSCQaXmFS2ff+fiPD7IC1HrcNvUxq/Mfq o/PN/fNhO3m/z2oTBUmSnZ0tZDOyCXmeO2drJUgoOFcNXQ7ohPJ65zCv5vObXswj g7eCTOZGx/iBjbMYHZ2WSch3Ma5D1hipHGlm7MxjAc+BT+CLOLiaS64woB67L99u QF1PO6iGjZJ96Bnwx2YhgQyRn/CwDvIcu0ES//N0rqBTDCCwPRtlWoCghy1ThIM/ xRclFifaperOEKu9Q3fQQi/NcqBHYBUqqy478S6tpXCsjEFWTz7jylHjczpxH/lj EJa7hK2rQGA1L+ulGagwuwhDj/CFAFm2TkFdnrQYH1M+S4QGo04= =8W8K -----END PGP SIGNATURE----- --=-=-=--