From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ricardo Wurmus Subject: Re: Guix build output insufficient Date: Wed, 12 Sep 2018 19:52:45 +0200 Message-ID: <87h8iuk3gy.fsf@elephly.net> References: <20180911082653.27gmposcatilbsuq@thebird.nl> <875zzcl09b.fsf@elephly.net> <87sh2e7ics.fsf@gnu.org> <87k1nqk4qw.fsf@elephly.net> <87pnximx3e.fsf@tobias.gr> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:47067) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1g09KJ-0003tG-Tx for guix-devel@gnu.org; Wed, 12 Sep 2018 13:53:23 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1g09KH-00087h-T7 for guix-devel@gnu.org; Wed, 12 Sep 2018 13:53:19 -0400 In-reply-to: <87pnximx3e.fsf@tobias.gr> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Tobias Geerinckx-Rice Cc: guix-devel Hi Tobias, > Ricardo Wurmus wrote: >> Note that the patch cannot be applied because I had to change how =E2=80= =9C@ >> build-failed=E2=80=9D is treated. The underlying problem here is that t= he >> daemon may send a multi-line message through the port, which >> unfortunately doesn=E2=80=99t necessarily arrive in one piece. >> >> AFAICS the only such message is the hash mismatch error. If we >> could >> force it to remain on one line we could better format that >> single-line >> string in guix/ui.scm. > > Didn't we change this from a one-line message relatively recently? I > vaguely remember supporting such a change (oops... :-) Yes, it was a change to the formatting of the message. I also supported this change because it makes it much easier to see how the hashes differ. Now that we apply post-processing to the build output in guix/ui.scm this early formatting gets in the way. This happened in the daemon, though, and since people don=E2=80=99t update = the daemon as often as they update the rest of Guix, we may need to accomodate both formats for a while. I=E2=80=99d rather wait some more time until more of wip-ui could be merged. (The post-processing itself unfortunately has its own downsides: the Emacs minor mode for build logs can no longer highlight the transformed =E2=80=9C@=E2=80=9D messages.) -- Ricardo