From mboxrd@z Thu Jan 1 00:00:00 1970 From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=) Subject: Re: 01/02: gnu: rhythmbox: Update hash of patch. Date: Sun, 25 Nov 2018 17:24:39 +0100 Message-ID: <87h8g5unug.fsf@gnu.org> References: <20181124183051.23027.37347@vcs0.savannah.gnu.org> <20181124183052.9A76B209A2@vcs0.savannah.gnu.org> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:52813) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gQxDy-0000NW-6E for guix-devel@gnu.org; Sun, 25 Nov 2018 11:25:35 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gQxDK-0002zL-2e for guix-devel@gnu.org; Sun, 25 Nov 2018 11:24:55 -0500 In-Reply-To: <20181124183052.9A76B209A2@vcs0.savannah.gnu.org> (guix-commits's message of "Sat, 24 Nov 2018 13:30:52 -0500 (EST)") List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: guix-devel@gnu.org, Mark H Weaver --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Hello Mark, guix-commits@gnu.org skribis: > commit e1d97c4efc42a661bd2772041371303e4070aa4f > Author: Mark H Weaver > Date: Mon Nov 5 04:04:45 2018 -0500 > > gnu: rhythmbox: Update hash of patch. >=20=20=20=20=20 > * gnu/packages/gnome.scm (rhythmbox)[source]: Update hash of the appl= ied > patch. > --- > gnu/packages/gnome.scm | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/gnu/packages/gnome.scm b/gnu/packages/gnome.scm > index 06ec28b..376cf5a 100644 > --- a/gnu/packages/gnome.scm > +++ b/gnu/packages/gnome.scm > @@ -3746,7 +3746,7 @@ which can read a large number of file formats.") > "b182c6b9e1d09e601bac0b703cc5f8b159ebbc3a.patch")) > (sha256 > (base32 > - "17j45vyyr071ka3nckj2gycgyyv1j08fyrxw89jfdq2442nzrsiy"= ))))) > + "06n87xgf927djmv1vshal84nqx7g8nwgljza3g2vydhy7g2n1csq"= ))))) Could you explain the difference between the two patches? In general I think we should keep providing detailed explanations in the commit log (and possibly in the bug tracker) when such problems occur. The former version of the patch can be found at (I=E2=80=99m attaching it here.) TIA, Ludo=E2=80=99. --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=t.patch Content-Description: the patch >From b182c6b9e1d09e601bac0b703cc5f8b159ebbc3a Mon Sep 17 00:00:00 2001 From: Bastien Nocera Date: Mon, 9 Oct 2017 13:11:47 +0200 Subject: [PATCH] fmradio: Fix build with GStreamer master The plugin description is not supposed to be a string constant, but an unescaped string, to be concatenated with function names. This used to be acceptable (though would have warned), but breaks with the GStreamer 1.13 development branch. rb-fm-radio-gst-src.c:181:6: error: pasting ""rbsilencesrc"" and "_get_desc" does not give a valid preprocessing token "rbsilencesrc", ^ https://bugzilla.gnome.org/show_bug.cgi?id=788706 --- plugins/fmradio/rb-fm-radio-gst-src.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/plugins/fmradio/rb-fm-radio-gst-src.c b/plugins/fmradio/rb-fm-radio-gst-src.c index 09d709c..88abdaf 100644 --- a/plugins/fmradio/rb-fm-radio-gst-src.c +++ b/plugins/fmradio/rb-fm-radio-gst-src.c @@ -178,7 +178,7 @@ plugin_init (GstPlugin *plugin) GST_PLUGIN_DEFINE (GST_VERSION_MAJOR, GST_VERSION_MINOR, - "rbsilencesrc", + rbsilencesrc, "element to output silence", plugin_init, VERSION, -- libgit2 0.27.1 --=-=-=--