unofficial mirror of guix-devel@gnu.org 
 help / color / mirror / code / Atom feed
* Please merge guix-patches bug: 36789-36800
@ 2019-07-24 18:29 zimoun
  2019-07-24 18:47 ` Tobias Geerinckx-Rice
  0 siblings, 1 reply; 4+ messages in thread
From: zimoun @ 2019-07-24 18:29 UTC (permalink / raw)
  To: Guix Devel

Dear,

My apologies!
I did a mistake with `git-send-email`.

I have missed how it works. I simply did:

git send-email -11 --cover-letter --annotate --to=guix-patches@gnu.org

and it is incorrect. Oups!


What is the correct command line to first obtain a debbug number and
second to send the series to this number ?


Thank you in advance. And sorry again for the mistake.

All the best,
simon

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: Please merge guix-patches bug: 36789-36800
  2019-07-24 18:29 Please merge guix-patches bug: 36789-36800 zimoun
@ 2019-07-24 18:47 ` Tobias Geerinckx-Rice
  2019-07-24 19:31   ` zimoun
  0 siblings, 1 reply; 4+ messages in thread
From: Tobias Geerinckx-Rice @ 2019-07-24 18:47 UTC (permalink / raw)
  To: guix-devel

[-- Attachment #1: Type: text/plain, Size: 1375 bytes --]

Zimoun,

zimoun 写道:
> Please merge guix-patches bug: 36789-36800

You can perform actions like this yourself by sending mail to 
control@debbugs.gnu.org.  Here's some documentation[0] and a 
caveat[1].

> I have missed how it works. I simply did:
>
> git send-email -11 --cover-letter --annotate 
> --to=guix-patches@gnu.org
>
> and it is incorrect. Oups!

Indeed!

> What is the correct command line to first obtain a debbug number 
> and
> second to send the series to this number ?

I was certain that this was in the manual, but I can't find it 
quickly.  Hm.

What I do is to just manually write a cover letter in my MUA, send 
it to guix-patches@, and wait for the response with the bug 
number.  I have to keep an eye on my inbox anyway, so I don't see 
the point of doing that on the command line.

Then I git send-email --to=nnnnn@debbugs.gnu.org.

> Thank you in advance. And sorry again for the mistake.

That's quite all right.  Thank you for immediately addressing it!

Kind regards,

T G-R

[0]: https://debbugs.gnu.org/server-control.html
[1]: In practice, there are hard limits on the length of these 
commands (and possibly the number of commands in one mail).  I 
once sent a (scripted) ‘merge a b c d … j k l’ request and 
debbugs (silently) merged only the first n items.  I forget what n 
was.


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 227 bytes --]

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: Please merge guix-patches bug: 36789-36800
  2019-07-24 18:47 ` Tobias Geerinckx-Rice
@ 2019-07-24 19:31   ` zimoun
  2019-07-24 19:55     ` Tobias Geerinckx-Rice
  0 siblings, 1 reply; 4+ messages in thread
From: zimoun @ 2019-07-24 19:31 UTC (permalink / raw)
  To: Tobias Geerinckx-Rice; +Cc: Guix Devel

Hi Tobias,

Thank you for your quick answer.

On Wed, 24 Jul 2019 at 20:47, Tobias Geerinckx-Rice <me@tobias.gr> wrote:

> You can perform actions like this yourself by sending mail to
> control@debbugs.gnu.org.  Here's some documentation[0] and a
> caveat[1].

I did not know. I thought that only person with super power could do that.
So I will do.

However, I am not sure to understand how the merge needs to be ordered.
I have tried with 36789 and 36790.


> What I do is to just manually write a cover letter in my MUA, send
> it to guix-patches@, and wait for the response with the bug
> number.  I have to keep an eye on my inbox anyway, so I don't see
> the point of doing that on the command line.

If I understand well, the basic workflow is:

  git format-patch -N --cover-letter -o patches
  edit patches/0000-cover-letter.patch
  # send as you want patches/0000-cover-letter.patch to guix-patches@
  rm patches/0000-cover-letter.patch
  # wait the bug number
  git send-email --to=nnnnn@debbugs.gnu.org patches/*.patch

Right?



> [0]: https://debbugs.gnu.org/server-control.html
> [1]: In practice, there are hard limits on the length of these
> commands (and possibly the number of commands in one mail).  I
> once sent a (scripted) ‘merge a b c d … j k l’ request and
> debbugs (silently) merged only the first n items.  I forget what n
> was.

Thank you.


All the best,
simon

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: Please merge guix-patches bug: 36789-36800
  2019-07-24 19:31   ` zimoun
@ 2019-07-24 19:55     ` Tobias Geerinckx-Rice
  0 siblings, 0 replies; 4+ messages in thread
From: Tobias Geerinckx-Rice @ 2019-07-24 19:55 UTC (permalink / raw)
  To: zimoun; +Cc: Guix Devel

[-- Attachment #1: Type: text/plain, Size: 2543 bytes --]

Zimoun,

zimoun 写道:
> Hi Tobias,
>
> Thank you for your quick answer.

You're very welcome.

> On Wed, 24 Jul 2019 at 20:47, Tobias Geerinckx-Rice 
> <me@tobias.gr> wrote:
>> You can perform actions like this yourself by sending mail to
>> control@debbugs.gnu.org.  Here's some documentation[0] and a
>> caveat[1].
>
> I did not know. I thought that only person with super power 
> could do that.

Your implication that this is a huge potential security hole is 
correct.  And yet, strangely, it works in practice.

> So I will do.
>
> However, I am not sure to understand how the merge needs to be 
> ordered.
> I have tried with 36789 and 36790.

Your attempt looks successful to me[0]:

  ”Merged [snipped]. Request was from zimoun <…> to control@….
   (Wed, 24 Jul 2019 19:18:02 GMT)”

You should have got a confirmation e-mail as well.

However…  Note[0] that you were attempting to merge two 
already-merged bugs.  Merged bugs act as one flesh, so you got a 
confusing response with all previous 11 numbers and the net effect 
of your command was zero.

>> What I do is to just manually write a cover letter in my MUA, 
>> send
>> it to guix-patches@, and wait for the response with the bug
>> number.  I have to keep an eye on my inbox anyway, so I don't 
>> see
>> the point of doing that on the command line.
>
> If I understand well, the basic workflow is:
>
>   git format-patch -N --cover-letter -o patches

Oh, I really meant ‘manually’ as in I fire up my MUA (emacs in 
this case), write a ‘sup geeks here's a patch series that frobs 
foo’, add ‘[PATCH 0/n]’ to the subject by hand like an animal, 
and send it to guix-patches@.

Does your command above generate a pretty diffstat or something? 
It probably does.

>   edit patches/0000-cover-letter.patch
>   # send as you want patches/0000-cover-letter.patch to 
>   guix-patches@
>   rm patches/0000-cover-letter.patch

If you do want to send a *file* like this then yes, it is indeed 
easier to use sendmail or a similar command-line tool.  I don't 
know the syntax for it by heart, though.

>   # wait the bug number
>   git send-email --to=nnnnn@debbugs.gnu.org patches/*.patch

Since I don't need to edit anything I don't write my patches to 
the file system first.  I use ‘git send-email … -7’ and away 
they go.  But this is getting into personal preference territory 
:-)

Kind regards,

T G-R

[0]: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=36789#30

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 227 bytes --]

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2019-07-24 19:56 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-07-24 18:29 Please merge guix-patches bug: 36789-36800 zimoun
2019-07-24 18:47 ` Tobias Geerinckx-Rice
2019-07-24 19:31   ` zimoun
2019-07-24 19:55     ` Tobias Geerinckx-Rice

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).