git / grep with pcre support?

git / grep with pcre support?

[Pierre Neidhardt]

[-- Attachment #1: Type: text/plain, Size: 482 bytes --]

Hi!

Quite a few packages depend on grep to have PCRE support (e.g. freebayes).

Similarly, some packages (magit-todos) depend on git to be built with
PCRE support.
Compiling Git with USE_LIBPCRE2 would fix this.

I understand that adding PCRE support to those packages might increase
their closure size, which might not be desirable for such fundamental
packages.

What about grep-minimal and git-minimal packages then?

-- 
Pierre Neidhardt
https://ambrevar.xyz/

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]

Re: git / grep with pcre support?

[Efraim Flashner]

[-- Attachment #1: Type: text/plain, Size: 988 bytes --]

On Sun, Jul 07, 2019 at 02:20:52PM +0200, Pierre Neidhardt wrote:
> Hi!
> 
> Quite a few packages depend on grep to have PCRE support (e.g. freebayes).
> 
> Similarly, some packages (magit-todos) depend on git to be built with
> PCRE support.
> Compiling Git with USE_LIBPCRE2 would fix this.
> 
> I understand that adding PCRE support to those packages might increase
> their closure size, which might not be desirable for such fundamental
> packages.
> 
> What about grep-minimal and git-minimal packages then?

We do actually already have a git-minimal, it's used for git-fetch
references :)

'guix size git' => 411 MiB
'guix size git pcre' => 413 MiB

'guix size grep' => 71.4 MiB
'guix size grep pcre' => 71.4 MiB

Looks like a good idea to me.

-- 
Efraim Flashner   <efraim@flashner.co.il>   אפרים פלשנר
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

Re: git / grep with pcre support?

[Tobias Geerinckx-Rice]

[-- Attachment #1: Type: text/plain, Size: 479 bytes --]

Efraim Flashner wrote:
> 'guix size git' => 411 MiB
> 'guix size git pcre' => 413 MiB
>
> 'guix size grep' => 71.4 MiB
> 'guix size grep pcre' => 71.4 MiB

I take this as a clear ‘no -minimal needed’?  PCRE is already 
core-updates material, so no reason there.

> Looks like a good idea to me.

Definitely.  I just noticed that our ‘guix-install.sh’ script 
demands PCRE support from the host grep; it's almost hypocritical 
;-)

Kind regards,

T G-R

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 227 bytes --]

Re: git / grep with pcre support?

[Ludovic Courtès]

Hi!

Tobias Geerinckx-Rice <me@tobias.gr> skribis:

> Efraim Flashner wrote:
>> 'guix size git' => 411 MiB
>> 'guix size git pcre' => 413 MiB
>>
>> 'guix size grep' => 71.4 MiB
>> 'guix size grep pcre' => 71.4 MiB
>
> I take this as a clear ‘no -minimal needed’?  PCRE is already
> core-updates material, so no reason there.

Yeah, it sounds like we should make this change.

However, I hear that ‘core-updates’ is super frozen right now.  But note
that we could change the ‘grep’ package anytime, just note the
‘grep-final’ thing in commencement.scm.

IOW, if we’re cautious, we should be able to add PCRE support to grep
and Git in ‘master’ without triggering a full rebuild.

Thanks,
Ludo’.

Re: git / grep with pcre support?

[Pierre Neidhardt]

[-- Attachment #1: Type: text/plain, Size: 146 bytes --]

OK, I'll look into it unless someone beats me to it.
No clue about grep-final, I'll look at it.

-- 
Pierre Neidhardt
https://ambrevar.xyz/

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]

Re: git / grep with pcre support?

[Pierre Neidhardt]

[-- Attachment #1: Type: text/plain, Size: 889 bytes --]

I've sent patch 37994 for git.
If triggers the rebuilt of just under 300 packages, so I guess it's safe
for master?

For grep:
actually our `grep' package has pcre support.
It's grep-final which doesn't:

--8<---------------cut here---------------start------------->8---
(define grep-final
  ;; The final grep.  Gzip holds a reference to it (via zgrep), so it must be
  ;; built before gzip.
  (let ((grep (with-boot5 (package-with-bootstrap-guile grep))))
    (package/inherit grep
                     (inputs (alist-delete "pcre" (package-inputs grep)))
                     (native-inputs `(("perl" ,perl-boot0))))))
--8<---------------cut here---------------end--------------->8---

Is there a reason for removing pcre here?
It does not add more than 2 MiB to the closure size.  Maybe a graph
simplification issue?

-- 
Pierre Neidhardt
https://ambrevar.xyz/

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]

Re: git / grep with pcre support?

[Pierre Neidhardt]

[-- Attachment #1: Type: text/plain, Size: 884 bytes --]

> I've sent patch 37994 for git.

It's on master.

> For grep:
> actually our `grep' package has pcre support.
> It's grep-final which doesn't:
>
> --8<---------------cut here---------------start------------->8---
> (define grep-final
>   ;; The final grep.  Gzip holds a reference to it (via zgrep), so it must be
>   ;; built before gzip.
>   (let ((grep (with-boot5 (package-with-bootstrap-guile grep))))
>     (package/inherit grep
>                      (inputs (alist-delete "pcre" (package-inputs grep)))
>                      (native-inputs `(("perl" ,perl-boot0))))))
> --8<---------------cut here---------------end--------------->8---
>
> Is there a reason for removing pcre here?
> It does not add more than 2 MiB to the closure size.  Maybe a graph
> simplification issue?

Any thought on the above?

-- 
Pierre Neidhardt
https://ambrevar.xyz/

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]

Re: git / grep with pcre support?

[Pierre Neidhardt]

[-- Attachment #1: Type: text/plain, Size: 67 bytes --]

Friendly ping! ;)

-- 
Pierre Neidhardt
https://ambrevar.xyz/

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]