From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id FmOxDt01zF7TNQAA0tVLHw (envelope-from ) for ; Mon, 25 May 2020 21:17:17 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id QG4fCt01zF58SQAAB5/wlQ (envelope-from ) for ; Mon, 25 May 2020 21:17:17 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 94F65940BD0 for ; Mon, 25 May 2020 21:17:16 +0000 (UTC) Received: from localhost ([::1]:41424 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jdKTD-0008Po-I6 for larch@yhetil.org; Mon, 25 May 2020 17:17:15 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:34864) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jdKT5-0008Pd-Fm for guix-devel@gnu.org; Mon, 25 May 2020 17:17:07 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:57565) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jdKT2-0006nu-Ok; Mon, 25 May 2020 17:17:04 -0400 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=52396 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1jdKT2-0002uG-5U; Mon, 25 May 2020 17:17:04 -0400 From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: Jack Hill Subject: Re: best practise between git-fetch vs url-fetch? References: <20200306091524.5044.11103@vcs0.savannah.gnu.org> <20200306091525.E8A1621163@vcs0.savannah.gnu.org> <87o8t9lfci.fsf@devup.no> <871rq5bjzf.fsf@ambrevar.xyz> <87lfodl6u5.fsf@devup.no> <87tv2vgdlg.fsf@gnu.org> <87lfo72b8i.fsf@ambrevar.xyz> <878shv3dzz.fsf@nckx> <87lflh13fj.fsf@gnu.org> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 7 Prairial an 228 de la =?utf-8?Q?R=C3=A9volution?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Mon, 25 May 2020 23:17:02 +0200 In-Reply-To: (Jack Hill's message of "Mon, 25 May 2020 00:54:25 -0400 (EDT)") Message-ID: <87h7w3u33l.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: guix-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: guix-devel@gnu.org, Brice Waegeneire Errors-To: guix-devel-bounces+larch=yhetil.org@gnu.org Sender: "Guix-devel" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-devel-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-devel-bounces@gnu.org X-Spam-Score: -0.01 X-TUID: VRJM1SIpUnzu Hi, Jack Hill skribis: > On Sun, 24 May 2020, Ludovic Court=C3=A8s wrote: > > [=E2=80=A6] > >>> Another improvement we could make here is improving the message about >>> Software Heritage in guix lint. Most of the other messages it emits >>> are things that the author of a package should consider improving. If >>> the Software Heritage message is less actionable, let's make that >>> clearer so that people don't think there is a problem with their >>> package definition. >> >> What message would you suggest? > > How about expanding section 7.7 "Invoking Guix Lint" in the manual to > include a paragraph of advice in the explanation for each checker. For > example, the advice could be could be "change the source to use > git-fetch" for "source-unstable-tarball", "exercise judgment on the > long-term availability of software sources. We think that code hosted > on the GNU ftp servers will be around for a long time, but code on > people's personal websites may not be. The greater the risk of the > software disappearing, the more important is is to use git-fetch in > sources so we can trigger archiving at Software Heritage" for > "archival", and "double check whether these inputs really should be > native [link to appropriate section of the manual]. If they really > need to be, leave a comment in the code briefly explaining why to help > future contributors" for "inputs-should-be-native". Regarding the =E2=80=98archival=E2=80=99 checker, the manual explains what= =E2=80=99s at stake and what it does: https://guix.gnu.org/manual/en/html_node/Invoking-guix-lint.html I feel like there=E2=80=99s little room for improvement here. Ludo=E2=80=99.